Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Jun 2023 15:52:04 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org,
        Alexander Duyck <alexander.duyck@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH net-next 01/17] net: Copy slab data for
 sendmsg(MSG_SPLICE_PAGES)
Message-ID: <ZI26hJuixlQHOjk4@corigine.com>
References: <ZIy82RjpmQMTNafS@corigine.com>
 <20230616161301.622169-1-dhowells@redhat.com>
 <20230616161301.622169-2-dhowells@redhat.com>
 <708510.1686984195@warthog.procyon.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <708510.1686984195@warthog.procyon.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mtPZohzH0O+JI8bXeCNy6gtpd5KI1MrCMe+kxfNtcv+DHZ+DKWE6PvrADmA1?=
 =?us-ascii?Q?iUPG2b4cFttv9GU/v/ducOn3dxl1r+H7BK29CXOa4514iqQ1mTxQZiUaNqyj?=
 =?us-ascii?Q?XSnpng2vvi3aj9LvTbjogySe4ST9OCFOu2YYS6bTF9Hx3G3G5lJZSGfGOduA?=
 =?us-ascii?Q?DQLnE3LCWrwzlsKv+qjDkSp1ehTtpcsDbQPVpbDoDPWNfjJ8d+HsPTZoeJrg?=
 =?us-ascii?Q?j4rZZFZsn98kOunhscixa1MPiTYuuEfZ/gXPzlvKC7uN240QH7PgyTRdzfu9?=
 =?us-ascii?Q?96qSOgb3iJgeNAeSZe8XqhRurIhLhYqOxZIP1yV7+SptoWWRD6jT21uygQAs?=
 =?us-ascii?Q?VWwDIJhsyLePujDBjTrecExhviBJgyofmRFANdP7eQuRAmYa5YakGe16Jdbk?=
 =?us-ascii?Q?PJ1OedZGP76PRIBPr2jtlEatg6vJi6SLgdbSPNZHPXDumogywg6bNfSX+ZGo?=
 =?us-ascii?Q?IrwosCKvEDIFf5ojL1L7HaoVLpQ4rj6vbBq4LrA03m728EcQJrVfRXhueHzu?=
 =?us-ascii?Q?6IE2mJXB/2ODHu5/EFvZozMFnCSRiIP6B29LEpdq97Wy3/ItClf3QFNtU8VG?=
 =?us-ascii?Q?uEx3WZXedIAWN7hIYdvIJQs3mRT94MqNR/j4Qyrk6KAL8P12FBg5oSeZ7sjE?=
 =?us-ascii?Q?wBFpLmrnBh/m9YvETv2wtn3KWuQFDOohvmSd7uafdUQ81RoL2kHpfPtc217h?=
 =?us-ascii?Q?wDR/OGGIHz6W+D78YRykeY1PUymgTShzDFtqjlIZ5qOPO6cFOrP2/a6jeNPm?=
 =?us-ascii?Q?LONbdX1lLASRiApIZw48U5qnaCEpjUI3bzbgQSaXbV7Ljn9gUNqgcSKkEp6I?=
 =?us-ascii?Q?At++0XUVTxEu2KD6J6MlNzMcwbHmHJkBowEgUN3KFJVnM7If22Ql6gCbeu1l?=
 =?us-ascii?Q?O0kTMmelcrnOROC5Ca0AeqBb0qX7KQO1aRgteIIZt6ZTuFyUm4Q/TK6pDOcZ?=
 =?us-ascii?Q?xlVAW7fow7BQmIA8ejjiLHIfxi/9nGAlji4fcM2OzxoqzHsPF97uZVEU/GsN?=
 =?us-ascii?Q?Oqw8J0Zt8xrH/T3yQ1xCxQp2CUX14PNj1SX4jkTpIOKJYv7pPtDKa2frYQJS?=
 =?us-ascii?Q?0QQ/8Lv6t0Lfr/6LFPjARC2+hwA3YxgymJposUNuqUZ8K3PL9SVFdz3tzcCv?=
 =?us-ascii?Q?qGGs+FLzmkz6iThamTs/gSPro6UbueJD/VWLBx8c863+Y0emW259MLQtKzKT?=
 =?us-ascii?Q?7OCWKzst4gZ9dTDLPGDGDO9yo0xTSsSUgswBzeh0et/UOtO08zEoD7DF42iS?=
 =?us-ascii?Q?sG0X5RXRUI5k91Gs9uk9ba/y6F6LHiolp9BWNiH53ThLt0hm5In3V/YP4v5J?=
 =?us-ascii?Q?q5IT1dbDtdKSlIdnRSDT+YX3eyKKeRBlK5hHO3RPASg8CJ6p6Wjk4/AqeG+6?=
 =?us-ascii?Q?MTpYjiM05wGBF8lAPHZbcGBpVMUnmiSSgv3/47M5p2QnAYSzbWGhzevzaW/M?=
 =?us-ascii?Q?JCSwIm4kYLPyuC7P0aFTJBeFToSGs1TW2/z3ezjXbWXDZca/F0xkhzbn5uu0?=
 =?us-ascii?Q?kh52M71rIVqjj+9z3QRz4LZ3CrLIUMneFGyQx5KsCVdWnqPlmwWq2gM8tETd?=
 =?us-ascii?Q?p9BbA1FbSB8IQs37D0VbFWWx+ykVesLkkvvuGcYiFXphapueWnwPzIRW4yom?=
 =?us-ascii?Q?jrja4demc0pj2Bl/JNLH8CHRKPJstuJjlynp4Cm2qBKK0IY9oXCUfErMMRba?=
 =?us-ascii?Q?XlBjSQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d849ec3-157d-48f2-793a-08db6f3a0cee
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2023 13:52:12.1201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RvbFXz52/IleX5apN+ltwsJjPJxre2Use8mmnB96xDLXiocunECEGwaVMGBZQ3P0gJH8SAvuv0YHyKEPnquoopQpqluUNVSfzqd0qnFOZiM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5757
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jun 17, 2023 at 07:43:15AM +0100, David Howells wrote:
> Simon Horman <simon.horman@corigine.com> wrote:
> 
> > > +	cache = get_cpu_ptr(&skb_splice_frag_cache);
> ...
> > > +	put_cpu_ptr(skb_splice_frag_cache);
> > 
> > Hi David,
> > 
> > I don't think it makes any difference at run-time.
> > But to keep Sparse happy, perhaps this ought to be put_cpu_var()
> 
> Actually, the problem is a missing "&".  I think I should use put_cpu_ptr() to
> match get_cpu_ptr().  It doesn't crash because the argument is ignored.

Thanks David, I agree that is a better idea.