Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4177233rwd; Sat, 17 Jun 2023 08:35:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7iphGM7Voq5jWyAYETdRcIHiOxnB12LcEZnUk3+eaqLyJVMsq0PIXWHGTongukkNKjCkpT X-Received: by 2002:a05:6a20:8f11:b0:11f:84d4:2fa8 with SMTP id b17-20020a056a208f1100b0011f84d42fa8mr768488pzk.40.1687016158371; Sat, 17 Jun 2023 08:35:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687016158; cv=none; d=google.com; s=arc-20160816; b=FMk7r92c1PnByDcH2l1Xtd6ospO/y4a5+l9OA+YO3yM37L4q+I4zISxj6ugd1OEpqt P591+YfA8Z77vDL1fmSoabWe/2xfpsoINlTLAqWCV1eOb1G5hnFEGXGaK0ZO2F6hEtF7 20pYaCETuKZPp1gZwYCxcszfVoTq5iYK55bELCNWSdR1TbeBabvKNJmZ4iVwialtL2LK mWKWTuSU2bstJqgG2oEePLfKxK+wt4XmwYdo9kcdlrygWAFKjIYyFoA5Cucq0ImyLhph 2859p0FqyOOwOwAnVhnc/2G417nx2xzTzuMsuq2uCMnTYNCS5ftSqXy1lsBL5NJaewD1 BcVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=KK2+YFUG/6HmL4tcdhB8f8ESWlAE0VcF40UXIVzAPuo=; b=puN/6jMXiCqVXwpzywBMr0sMLKOJHmRVxFc9f7GqXzvhTFIAKjzamckhjxB3oxUmin fuaQiH9cLUqwD10MWeQe3UWn1kwysX/E3T+DKiZu/QCAnDroic7k8QJUPOKiGSU8coRc dTULRiIrT8VwIAmmAd37NiUe4upY9QVj9qNLgbDMSPl+gLZSux2ruNTehvBY1UOrRN3B LW8PjhFryygXeJaDX+YThO/ZUKJZtdR+H51OY/eGl1mCpP5EyYjwfO6sDNXDQcrD6oCv PQi/CG0YfqYjSUTDI7ZayZ/P4fT3rVk4abNK3v0d7ouibeySaJHLIA4ipdzKn60kgvq3 4VTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uRkenpha; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ba5-20020a170902720500b001b3cf975c79si11296768plb.563.2023.06.17.08.35.45; Sat, 17 Jun 2023 08:35:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uRkenpha; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235652AbjFQOoI (ORCPT + 99 others); Sat, 17 Jun 2023 10:44:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235008AbjFQOoF (ORCPT ); Sat, 17 Jun 2023 10:44:05 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 883971FD7 for ; Sat, 17 Jun 2023 07:44:03 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-51a1d539ffaso3669815a12.0 for ; Sat, 17 Jun 2023 07:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687013042; x=1689605042; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KK2+YFUG/6HmL4tcdhB8f8ESWlAE0VcF40UXIVzAPuo=; b=uRkenpha2+Snmt2ZqLpbiOEu7lU0WybjKCO73iSIQE8Uu9AevsrBAAIbbG0jobIoie g1X3Pql5QlV4aL26S5MbUKVwefxWQP7+8omvrHKRjkh4H7ELph0Udn54Li/0lDgjwCjz PKR1MjnETnS7b9yTta1/+kYxnHiLBYp0cSv97Au6wdgGuNkOyQ+FLyNHRIHcaRlqoXuq abDbL99zb0WRxwoOpWlmA6KtJyPIbjBaamsFOCKdKIA82V2/tP9XCLWW6k+1D1V7hokN JvkjhCZb02tFrqVUb681zLCIW/9T8jSzsSTZxXO1zwQhBCFGCOfmfWJ/qWP3NzUOxo4h A2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687013042; x=1689605042; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KK2+YFUG/6HmL4tcdhB8f8ESWlAE0VcF40UXIVzAPuo=; b=N32kDTUK3np5f/fzbVBTjofcDkqNOaRpzHJnbKBNAUCJqj4crexvB2wRZTX4P2wZvf 0bRtaqNkYqOkRh0fZP4mhTFw2M8AH57ttP0zFf9eY1uc7HBZzk8RjKmKLb1U5tQQj8Au aL3ThhGt3kCyQCApkTR802KlR9pMcMmiOahnIACbrz5RWir+ur32dYtKWA1U2Qeqizxa eUliK6KJNB9qu/1cpNoPYcZN35H9xpT+BVB6QuqpaYMvlqVMPkk6t13lATb9ZlzP2s40 fknUSr2b3GNe3TfYLKtm1tq4atEibeceZ0/4MUxbv5/KoTT13oC3/ppVx53QdbW2ojr2 jo4Q== X-Gm-Message-State: AC+VfDyXzx2scJRhoyBPOdK0NVZB5J1gpmg+UgbZlyEpOC1Q9NB0m3+W FtdXvuvZZoIWm/EPLq8NM352DQ== X-Received: by 2002:a05:6402:18c:b0:518:741e:9314 with SMTP id r12-20020a056402018c00b00518741e9314mr4660226edv.11.1687013042132; Sat, 17 Jun 2023 07:44:02 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id u3-20020aa7d543000000b00514bddcb87csm11293575edr.31.2023.06.17.07.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 07:44:01 -0700 (PDT) Message-ID: Date: Sat, 17 Jun 2023 16:43:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 2/9] clk: ralink: add clock and reset driver for MTMIPS SoCs Content-Language: en-US To: Sergio Paracuellos , Shiji Yang Cc: arinc.unal@arinc9.com, devicetree@vger.kernel.org, john@phrozen.org, krzysztof.kozlowski+dt@linaro.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, matthias.bgg@gmail.com, mturquette@baylibre.com, p.zabel@pengutronix.de, robh+dt@kernel.org, sboyd@kernel.org, tsbogend@alpha.franken.de References: <20230617052435.359177-3-sergio.paracuellos@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2023 15:26, Sergio Paracuellos wrote: >>> void __init plat_time_init(void) >>> { >>> + struct of_phandle_args clkspec; >>> struct clk *clk; >>> + int cpu_clk_idx; >>> >>> ralink_of_remap(); >>> >>> - ralink_clk_init(); >>> - clk = clk_get_sys("cpu", NULL); >>> + cpu_clk_idx = clk_cpu_index(); >>> + if (cpu_clk_idx == -1) >>> + panic("unable to get CPU clock index"); >>> + >>> + of_clk_init(NULL); >>> + clkspec.np = of_find_node_by_name(NULL, "sysc"); >> >> The node name should be "syscon" as the example node name in the >> dt-bindings document is "syscon". > > sysc is label to get this node since it is the one shared by all > different dtsi files. If it is label, why do you use it to get by name? name != label. Best regards, Krzysztof