Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230617052435.359177-1-sergio.paracuellos@gmail.com>
 <20230617052435.359177-9-sergio.paracuellos@gmail.com> <c1a69db7-96c2-f3ad-3ef2-9a655b10bfb5@linaro.org>
In-Reply-To: <c1a69db7-96c2-f3ad-3ef2-9a655b10bfb5@linaro.org>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Sat, 17 Jun 2023 17:35:28 +0200
Message-ID: <CAMhs-H_HjsT2om2CZpMmVDYao=M5FoZwyy0Te1QB9MLj6mAxnw@mail.gmail.com>
Subject: Re: [PATCH v4 8/9] mips: ralink: get cpu rate from new driver code
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-clk@vger.kernel.org, linux-mips@vger.kernel.org,
        tsbogend@alpha.franken.de, john@phrozen.org,
        linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
        mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        devicetree@vger.kernel.org, arinc.unal@arinc9.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jun 17, 2023 at 4:48=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 17/06/2023 07:24, Sergio Paracuellos wrote:
> > At very early stage on boot, there is a need to set 'mips_hpt_frequency=
'.
> > This timer frequency is a half of the CPU frequency. To get clocks prop=
erly
> > set we need to call to 'of_clk_init()' and properly get cpu clock frequ=
ency
> > afterwards. Depending on the SoC, CPU clock index in the clock provider=
 is
> > different being two for MT7620 SoC and one for the rest. Hence, adapt c=
ode
> > to be aligned with new clock driver.
>
>
> >  void __init plat_time_init(void)
> >  {
> > +     struct of_phandle_args clkspec;
> >       struct clk *clk;
> > +     int cpu_clk_idx;
> >
> >       ralink_of_remap();
> >
> > -     ralink_clk_init();
> > -     clk =3D clk_get_sys("cpu", NULL);
> > +     cpu_clk_idx =3D clk_cpu_index();
> > +     if (cpu_clk_idx =3D=3D -1)
> > +             panic("unable to get CPU clock index");
> > +
> > +     of_clk_init(NULL);
> > +     clkspec.np =3D of_find_node_by_name(NULL, "sysc");
> > +     clkspec.args_count =3D 1;
> > +     clkspec.args[0] =3D cpu_clk_idx;
> > +     clk =3D of_clk_get_from_provider(&clkspec);
>
> This is very obfuscated way of getting clock. Why can't you get it from
> "clocks" property of "cpu", like every other recent platform?

I did not find any other approach that works for me. So I ended up in this =
one.
Can you point me out in a sample of code doing the same so I can check
if it works for me then?

>
> Anyway, NAK for of_find_node_by_name(), because you now create ABI for
> node name. It's broken approach.

I will change whatever is needed to provide a valid approach. Please,
point me out in the right direction.

>
> Best regards,
> Krzysztof
>

Thanks in advance for your time.

Best regards,
    Sergio Paracuellos