Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230617052435.359177-3-sergio.paracuellos@gmail.com>
 <TYAP286MB0315AB8274CDD341D49809A2BC59A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
 <CAMhs-H8rt3-ffvjkNSORiNXQUVCUHCc7FNwYN7TOyQ0DxCe2fA@mail.gmail.com> <a61180e8-5732-2208-3a0c-e2b0137f9290@linaro.org>
In-Reply-To: <a61180e8-5732-2208-3a0c-e2b0137f9290@linaro.org>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Sat, 17 Jun 2023 17:31:41 +0200
Message-ID: <CAMhs-H_UZowVdVvQ_G_Jm+yLeCELDxjG=FQDQ-OOLt8FHJUZYg@mail.gmail.com>
Subject: Re: [PATCH v3 2/9] clk: ralink: add clock and reset driver for MTMIPS SoCs
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Shiji Yang <yangshiji66@outlook.com>, arinc.unal@arinc9.com,
        devicetree@vger.kernel.org, john@phrozen.org,
        krzysztof.kozlowski+dt@linaro.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
        matthias.bgg@gmail.com, mturquette@baylibre.com,
        p.zabel@pengutronix.de, robh+dt@kernel.org, sboyd@kernel.org,
        tsbogend@alpha.franken.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jun 17, 2023 at 4:44=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 17/06/2023 15:26, Sergio Paracuellos wrote:
> >>> void __init plat_time_init(void)
> >>> {
> >>> +      struct of_phandle_args clkspec;
> >>>       struct clk *clk;
> >>> +      int cpu_clk_idx;
> >>>
> >>>       ralink_of_remap();
> >>>
> >>> -      ralink_clk_init();
> >>> -      clk =3D clk_get_sys("cpu", NULL);
> >>> +      cpu_clk_idx =3D clk_cpu_index();
> >>> +      if (cpu_clk_idx =3D=3D -1)
> >>> +              panic("unable to get CPU clock index");
> >>> +
> >>> +      of_clk_init(NULL);
> >>> +      clkspec.np =3D of_find_node_by_name(NULL, "sysc");
> >>
> >> The node name should be "syscon" as the example node name in the
> >> dt-bindings document is "syscon".
> >
> > sysc is label to get this node since it is the one shared by all
> > different dtsi files.
>
> If it is label, why do you use it to get by name? name !=3D label.

Sorry I meant both of them, node name in dtsi file and also label for
referring to it from other nodes.

>
> Best regards,
> Krzysztof
>

Best regards,
    Sergio Paracuellos