Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Jun 2023 19:34:23 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     "Paller, Kim Seer" <KimSeer.Paller@analog.com>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "robh@kernel.org" <robh@kernel.org>,
        "krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 2/2] iio: adc: max14001: New driver
Message-ID: <20230617193423.42a4d66c@jic23-huawei>
In-Reply-To: <CAHp75VdQJ39Uw8bPD+y7GS7W2iJhjs2D4L-=-Fo0Jeb+8Ffn8g@mail.gmail.com>
References: <20230614004857.134980-1-kimseer.paller@analog.com>
        <20230614004857.134980-2-kimseer.paller@analog.com>
        <CAHp75VcTXsZZ4JsKWS0RuccPKRLO9ci+87b538BT9V9ZZ_WACg@mail.gmail.com>
        <a6488485909d40b3810ad15787cd2100@analog.com>
        <CAHp75VdQJ39Uw8bPD+y7GS7W2iJhjs2D4L-=-Fo0Jeb+8Ffn8g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 14 Jun 2023 14:53:12 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Jun 14, 2023 at 1:43=E2=80=AFPM Paller, Kim Seer
> <KimSeer.Paller@analog.com> wrote:
> > > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > Sent: Wednesday, June 14, 2023 5:12 PM =20
>=20
> ...
>=20
> > > > +               /* select external voltage reference source for the=
 ADC */
> > > > +               ret =3D max14001_reg_update(st, MAX14001_CFG,
> > > > +                                         MAX14001_CFG_EXRF, 1);
> > > > +
> > > > +               ret =3D regulator_get_voltage(vref);
> > > > +               if (ret < 0)
> > > > +                       return dev_err_probe(dev, ret,
> > > > +                                            "Failed to get vref\n"=
); =20
> > >
> > > Is it important to choose the external reference source _before_ gett=
ing the
> > > voltage of the regulator? If not, I would swap these calls, otherwise=
 the
> > > comment is needed to explain why the sequence is important in the way=
 it's
> > > written. =20
> >
> > It is not important. These calls can be swap without any issues. =20
>=20
> If you send a new version, please swap, otherwise I hope Jonathan can
> do it when applying.
>=20

I made these changes whilst applying...

--- a/drivers/iio/adc/max14001.c
+++ b/drivers/iio/adc/max14001.c
@@ -290,16 +290,19 @@ static int max14001_probe(struct spi_device *spi)
                if (ret)
                        return ret;
=20
-               /* select external voltage reference source for the ADC */
-               ret =3D max14001_reg_update(st, MAX14001_CFG,
-                                         MAX14001_CFG_EXRF, 1);
-
                ret =3D regulator_get_voltage(vref);
                if (ret < 0)
                        return dev_err_probe(dev, ret,
                                             "Failed to get vref\n");
=20
                st->vref_mv =3D ret / 1000;
+
+               /* select external voltage reference source for the ADC */
+               ret =3D max14001_reg_update(st, MAX14001_CFG,
+                                         MAX14001_CFG_EXRF, 1);
+
+               if (ret < 0)
+                       return ret;
        }
=20
        mutex_init(&st->lock);


Note that whilst I've applied this to the togreg branch of iio.git - it is =
just
a tiny bit too late to make the merge window that starts in about a week.
As such I'll only push this out as testing until I can rebase the tree
on rc1 once available.

Thanks,

Jonathan