Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Jun 2023 19:27:29 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Leonard =?UTF-8?B?R8O2aHJz?= <l.goehrs@pengutronix.de>
Cc:     kernel@pengutronix.de, Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] iio: adc: add buffering support to the TI LMP92064
 ADC driver
Message-ID: <20230617192729.4868d96f@jic23-huawei>
In-Reply-To: <20230614075537.3525194-1-l.goehrs@pengutronix.de>
References: <20230614075537.3525194-1-l.goehrs@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 14 Jun 2023 09:55:36 +0200
Leonard G=C3=B6hrs <l.goehrs@pengutronix.de> wrote:

> Enable buffered reading of samples from the LMP92064 ADC.
> The main benefit of this change is being able to read out current and
> voltage measurements in a single transfer, allowing instantaneous power
> measurements.
>=20
> Reads into the buffer can be triggered by any software triggers, e.g.
> the iio-trig-hrtimer:
>=20
>     $ mkdir /sys/kernel/config/iio/triggers/hrtimer/my-trigger
>     $ cat /sys/bus/iio/devices/iio\:device3/name
>     lmp92064
>     $ iio_readdev -t my-trigger -b 16 iio:device3 | hexdump
>     WARNING: High-speed mode not enabled
>     0000000 0000 0176 0101 0001 5507 abd5 7645 1768
>     0000010 0000 016d 0101 0001 ee1e ac6b 7645 1768
>     ...
>=20
> Signed-off-by: Leonard G=C3=B6hrs <l.goehrs@pengutronix.de>
> ---
>  drivers/iio/adc/ti-lmp92064.c | 54 +++++++++++++++++++++++++++++++++++
>  1 file changed, 54 insertions(+)
>=20
> diff --git a/drivers/iio/adc/ti-lmp92064.c b/drivers/iio/adc/ti-lmp92064.c
> index c30ed824924f3..03765c4057dda 100644
> --- a/drivers/iio/adc/ti-lmp92064.c
> +++ b/drivers/iio/adc/ti-lmp92064.c
> @@ -16,7 +16,10 @@
>  #include <linux/spi/spi.h>
> =20
>  #include <linux/iio/iio.h>
> +#include <linux/iio/buffer.h>
>  #include <linux/iio/driver.h>
> +#include <linux/iio/triggered_buffer.h>
> +#include <linux/iio/trigger_consumer.h>
> =20
>  #define TI_LMP92064_REG_CONFIG_A 0x0000
>  #define TI_LMP92064_REG_CONFIG_B 0x0001
> @@ -91,6 +94,13 @@ static const struct iio_chan_spec lmp92064_adc_channel=
s[] =3D {
>  		.address =3D TI_LMP92064_CHAN_INC,
>  		.info_mask_separate =3D
>  			BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE),
> +		.scan_index =3D 0,
> +		.scan_type =3D {
> +			.sign =3D 'u',
> +			.realbits =3D 12,
> +			.storagebits =3D 16,
> +			.shift =3D 0,

As zero is the 'obvious' default for shift (do nothing case) and c will set=
 it to 0 for
you anyway, no need to set it explicitly like this.

> +		},
>  		.datasheet_name =3D "INC",
>  	},
>  	{
> @@ -98,8 +108,16 @@ static const struct iio_chan_spec lmp92064_adc_channe=
ls[] =3D {
>  		.address =3D TI_LMP92064_CHAN_INV,
>  		.info_mask_separate =3D
>  			BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE),
> +		.scan_index =3D 1,
> +		.scan_type =3D {
> +			.sign =3D 'u',
> +			.realbits =3D 12,
> +			.storagebits =3D 16,
> +			.shift =3D 0,

Same here. No need for this last line.

> +		},
>  		.datasheet_name =3D "INV",
>  	},
> +	IIO_CHAN_SOFT_TIMESTAMP(2),
>  };
> =20
>  static int lmp92064_read_meas(struct lmp92064_adc_priv *priv, u16 *res)
> @@ -171,6 +189,37 @@ static int lmp92064_read_raw(struct iio_dev *indio_d=
ev,
>  	}
>  }
> =20
> +static irqreturn_t lmp92064_trigger_handler(int irq, void *p)
> +{
> +	struct iio_poll_func *pf =3D p;
> +	struct iio_dev *indio_dev =3D pf->indio_dev;
> +	struct lmp92064_adc_priv *priv =3D iio_priv(indio_dev);
> +	int i =3D 0, j, ret;
> +	u16 raw[2];
> +	u16 *data;
> +
> +	ret =3D lmp92064_read_meas(priv, raw);
> +	if (ret < 0)
> +		goto done;
> +
> +	data =3D kmalloc(indio_dev->scan_bytes, GFP_KERNEL);

A driver shouldn't be directly accessing scan_bytes.
You will see iio.h that it is marked [INTERN] to show it should only be acc=
essed
by the IIO core code.

The reasoning is closely related to Lars' point. This is almost always a sm=
all
structure with a known maximum size (across all possible channel configurat=
ions)
so allocate that space once not every scan (will be 16 bytes I think)


> +	if (!data)
> +		goto done;
> +
> +	for_each_set_bit(j, indio_dev->active_scan_mask, indio_dev->masklength)
> +		data[i++] =3D raw[j];
When a sensor 'always' reads the two channels, we can leave the necessary d=
ata
mangling up to the IIO core.

Provide available_scan_masks and then always push the lot every time.
Mostly people will want both channels anyway (as they paid for them ;)
so that core code that moves the data around will do nothing.  In the cases
where they only want one channel it will handle the complexity for you.

> +
> +	iio_push_to_buffers_with_timestamp(indio_dev, data,
> +					   iio_get_time_ns(indio_dev));
> +
> +	kfree(data);
> +
> +done:
> +	iio_trigger_notify_done(indio_dev->trig);
> +
> +	return IRQ_HANDLED;
> +}
> +
>  static int lmp92064_reset(struct lmp92064_adc_priv *priv,
>  			  struct gpio_desc *gpio_reset)
>  {
> @@ -302,6 +351,11 @@ static int lmp92064_adc_probe(struct spi_device *spi)
>  	indio_dev->num_channels =3D ARRAY_SIZE(lmp92064_adc_channels);
>  	indio_dev->info =3D &lmp92064_adc_info;
> =20
> +	ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
> +					      lmp92064_trigger_handler, NULL);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to setup buffered read\n");
> +
>  	return devm_iio_device_register(dev, indio_dev);
>  }
> =20
>=20
> base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7