Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4427343rwd; Sat, 17 Jun 2023 13:34:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6oPlcUp3ECaw3ztaTsEFQJ2MmUIQFi789inDG6BVk+DU0BRAD9SG2vw19FVnr23sd6HE4C X-Received: by 2002:a17:902:e807:b0:1b3:d33f:917 with SMTP id u7-20020a170902e80700b001b3d33f0917mr3839563plg.49.1687034086364; Sat, 17 Jun 2023 13:34:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687034086; cv=none; d=google.com; s=arc-20160816; b=aPAEKkcSrK+jSu3oBKp8CPC2l8+2h8DJmuNXFj8TIrxw1Lpobf5zJiWhfiejsTTVpC 6rnvjxCw8vJcyx1ncnXoxlveUv6jjRZYHMJXczOc/zFcLs1UKMGCuU8mesoIz2UqXLRX xqXLANOfnYqEj/ZUUiYsfZjqPkCZlUMV9t+k0xI/gT6NrMbmGJDypE+YCjhMXzZny4aG kn3wwJ2A/to72n92sucGP8z2+FUyGWxLB/JbJ7lxH5xA+uhcaifCX1ZQJce9MFc3Pzdh LFQNZndDetRw8wm//YNLqjO2VvGXfkdWTE3+GaQ7ma1HL6Pp5N43m1rd94pLI55hUeIT ph6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=JpMOu/1hNxHuaKwCQGdnk2FzL/My6PZIjCLG8MrTMrk=; b=VAREkCvCWZgqs5Nzv1DauPiQwD/mGYMBfRxYfXeKi69FVETS9OKAgpYAE3QV7aqtRH Jfh/8NP52lFb3DGGaqbe8XZAVwyQshBQ0w+j/X+yu19AEyZ8QEnWkiNPyGMzsAjZ9Z8K bywHFc6M9XZgtEULwgXaOXAspZjhpoJSeRppNAXBLeFFTMdGZPCXVQy+v/98xG9B/mkq 1kiPEjDNEZq8rl/REGzr95m8Ogz1+y7Gzb/LgNqvWvEGX7vi4c4V4ASBlEPu8RkcWdOa 3MPzhsrbARGSZHwc8a8gei5qCFmVUwskOP5mF1+3e3Pq4hz59llaONvvXV9+8h+zDuXE iJbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa1 header.b=olI+Ud46; dkim=neutral (no key) header.i=@ravnborg.org header.s=ed1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i11-20020a170902c94b00b001b39ba937d1si15607312pla.330.2023.06.17.13.34.27; Sat, 17 Jun 2023 13:34:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa1 header.b=olI+Ud46; dkim=neutral (no key) header.i=@ravnborg.org header.s=ed1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235905AbjFQTtD (ORCPT + 99 others); Sat, 17 Jun 2023 15:49:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346317AbjFQTsx (ORCPT ); Sat, 17 Jun 2023 15:48:53 -0400 Received: from mailrelay1-1.pub.mailoutpod2-cph3.one.com (mailrelay1-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:400::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82C221BF3 for ; Sat, 17 Jun 2023 12:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=JpMOu/1hNxHuaKwCQGdnk2FzL/My6PZIjCLG8MrTMrk=; b=olI+Ud46siOzcq3kqIqwPJ5i5dACaKmPy5sljdckqrt15mByDfSsLsOKxpsY+d1Q8ZOsNY/yq1oIA ulh1AWDpe3MgKw7Vbgs4w4Xrr5NCiCobIuFefe/lku4nOnv+V4NsdLgh6lumQLt5MnnIM8uTOiNSnZ jLWdvw2UMxvk8TRbEF9Boh55EPdfXsgLDa8U8b+C1ZE6N3knAZCGZ5Sa6HhG2lBbZIiCX6eAGTK4aZ C+6xiQBoM/ZO7Ai0Smy6WueXyTSwoyC19PN0XRCNsnh0apc+F7EOI0ZL8wup/9FTtFKce8FGW5g7xk PiLYlUpa+M2Mul8/UfI/PjqhILtGycQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=JpMOu/1hNxHuaKwCQGdnk2FzL/My6PZIjCLG8MrTMrk=; b=iU5ZO50tbDLra8ur+ON9C1XNg0BNwnaNbHntd4Pjwx1O7eY+11EAX0xPMRW6vni1YchwjRSloKQcu qSNMxVZDw== X-HalOne-ID: f63d52c5-0d47-11ee-ada2-99461c6a3fe8 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay1 (Halon) with ESMTPSA id f63d52c5-0d47-11ee-ada2-99461c6a3fe8; Sat, 17 Jun 2023 19:48:45 +0000 (UTC) Date: Sat, 17 Jun 2023 21:48:43 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: Sui Jingfeng , David Airlie , Daniel Vetter , linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO Message-ID: <20230617194843.GA1854380@ravnborg.org> References: <20230607110650.569522-1-suijingfeng@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SCC_BODY_URI_ONLY,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote: > Hi, > > Le mercredi 07 juin 2023 ? 19:06 +0800, Sui Jingfeng a ?crit?: > > Otherwise its failed to pass basic compile test on platform without > > REGMAP_MMIO selected by defconfig > > > > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- > > > > ? SYNC??? include/config/auto.conf.cmd > > ? Checking missing-syscalls for N32 > > ? CALL??? scripts/checksyscalls.sh > > ? Checking missing-syscalls for O32 > > ? CALL??? scripts/checksyscalls.sh > > ? CALL??? scripts/checksyscalls.sh > > ? MODPOST Module.symvers > > ERROR: modpost: "__devm_regmap_init_mmio_clk" > > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 > > make: *** [Makefile:1978: modpost] Error 2 > > > > V2: Order alphabetically > > > > Signed-off-by: Sui Jingfeng > > The patch looks good to me. But I need an ACK from someone else to > apply to drm-misc-next. Reviewed-by: Sam Ravnborg