Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4428859rwd; Sat, 17 Jun 2023 13:37:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5zRf94FNE1oYwpCO4yNbDOgC3X0COO+uX2+5miPbWN+W8NkNXTzCpXN2KmhwMF/IaeLx55 X-Received: by 2002:a05:6a00:10c6:b0:663:ba2c:2381 with SMTP id d6-20020a056a0010c600b00663ba2c2381mr4759275pfu.12.1687034226651; Sat, 17 Jun 2023 13:37:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687034226; cv=none; d=google.com; s=arc-20160816; b=FwLcQP7CSdWNMVlL8plrHWMCrlIslPwf046x4pcVFlbTIqEYvWnp38FOc0Eoix5yT/ jwj0Ab6YRsmSgCBhWA8+QWNPdlQdIG2aLuc1I4ZKLgBCzwwrOkwv/cz67DLLTCrvk96p XqRcX2LjxoJeVEuVEq46QiOcLxkdwrv/MK68G0y+0D11zmo2Bdhh9hy/K/dlE5er63zv eGuucJ8SIPHi3S33TIhg/OQHf/UACoPHwhYZwNHwRu2Q6J8aP6gzwFt9G3Lp9DLzxMMq 9qlnnvqriBa2qpLKfKoXceYNhaPY9SgkRnAEc3LcssQbWJgyu8Vf5a2XJdjEFrcPAr8z mXIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=nmqt6yb4ErstxdwxN6vUxbNPTZ5Zr6NGJzRsFUvY+v0=; b=zlrLHaoXn4o/4ScOp6ij+nvh2NDRk1PH6ZFFFOFUbjD/8U6CktbuSngv8PMXE/cdRN CQXQPDQklMi2siGRAXxXQ85Xg1Ow+iwpxmPa9+gicUmJ4VJo+nryTaTmOX9GZOt51sta HWolPRC3sb4y1n/hgHiXPWpw0p1SRA2xgXntgXz6UO3k55pkZm+xCeuBye+O3pA0ydme ZFfBvIM8/GI+E77fA7245BSwubfKSSbQt/EScO4Bf7gpHl8m6voWrVojh9q1QZ5hTaRu GWbuA22c4G6YZH1oh1zzjwwTothOSPb3M9Z+CQtP00zgQrTJ3U+H7X0jdLWFm5SBY1Rj fF6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=OOz00nZQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e15-20020a056a001a8f00b0064f50a4a515si18691129pfv.37.2023.06.17.13.36.49; Sat, 17 Jun 2023 13:37:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=OOz00nZQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233564AbjFQTNr (ORCPT + 99 others); Sat, 17 Jun 2023 15:13:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjFQTNp (ORCPT ); Sat, 17 Jun 2023 15:13:45 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F1931BD; Sat, 17 Jun 2023 12:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1687029219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nmqt6yb4ErstxdwxN6vUxbNPTZ5Zr6NGJzRsFUvY+v0=; b=OOz00nZQdMdd+W7ZBoXpmcmR97VRcm6Dl09QACAoOMdZdGwp4s9b45sCa1oemF92GyHf5O Tx2u9VE6o1n45/JodiQtehRsHqnsVKHBcEHK2CERDVpOlQ9HqHyg/MrGDvhC1XO4SBnnad /d7zT+NIi02oaTZsIhlGCxPp6CNid/g= Message-ID: Subject: Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO From: Paul Cercueil To: Sui Jingfeng , David Airlie , Daniel Vetter Cc: linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Sat, 17 Jun 2023 21:13:37 +0200 In-Reply-To: <20230607110650.569522-1-suijingfeng@loongson.cn> References: <20230607110650.569522-1-suijingfeng@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le mercredi 07 juin 2023 =C3=A0 19:06 +0800, Sui Jingfeng a =C3=A9crit=C2= =A0: > Otherwise its failed to pass basic compile test on platform without > REGMAP_MMIO selected by defconfig >=20 > make -j$(nproc) ARCH=3Dmips CROSS_COMPILE=3Dmips64el-linux-gnuabi64- >=20 > =C2=A0 SYNC=C2=A0=C2=A0=C2=A0 include/config/auto.conf.cmd > =C2=A0 Checking missing-syscalls for N32 > =C2=A0 CALL=C2=A0=C2=A0=C2=A0 scripts/checksyscalls.sh > =C2=A0 Checking missing-syscalls for O32 > =C2=A0 CALL=C2=A0=C2=A0=C2=A0 scripts/checksyscalls.sh > =C2=A0 CALL=C2=A0=C2=A0=C2=A0 scripts/checksyscalls.sh > =C2=A0 MODPOST Module.symvers > ERROR: modpost: "__devm_regmap_init_mmio_clk" > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 > make: *** [Makefile:1978: modpost] Error 2 >=20 > V2: Order alphabetically >=20 > Signed-off-by: Sui Jingfeng The patch looks good to me. But I need an ACK from someone else to apply to drm-misc-next. Cheers, -Paul > --- > =C2=A0drivers/gpu/drm/ingenic/Kconfig | 2 ++ > =C2=A01 file changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/ingenic/Kconfig > b/drivers/gpu/drm/ingenic/Kconfig > index a53f475d33df..b440e0cdc057 100644 > --- a/drivers/gpu/drm/ingenic/Kconfig > +++ b/drivers/gpu/drm/ingenic/Kconfig > @@ -9,6 +9,8 @@ config DRM_INGENIC > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select DRM_PANEL_BRIDGE > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select DRM_KMS_HELPER > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select DRM_GEM_DMA_HELPER > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select REGMAP > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select REGMAP_MMIO > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select VT_HW_CONSOLE_BIND= ING if FRAMEBUFFER_CONSOLE > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0help > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Choose this option= for DRM support for the Ingenic SoCs.