Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <696b2c4144e454aa194e4487b41706075a70ae95.camel@crapouillou.net>
Subject: Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
From:   Paul Cercueil <paul@crapouillou.net>
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Sui Jingfeng <suijingfeng@loongson.cn>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, linux-mips@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Date:   Sat, 17 Jun 2023 22:41:03 +0200
In-Reply-To: <20230617194843.GA1854380@ravnborg.org>
References: <20230607110650.569522-1-suijingfeng@loongson.cn>
         <c70cb3cb326439a5868beb54d720538923f653d1.camel@crapouillou.net>
         <20230617194843.GA1854380@ravnborg.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hi,

Le samedi 17 juin 2023 =C3=A0 21:48 +0200, Sam Ravnborg a =C3=A9crit=C2=A0:
> Hi Paul,
> On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
> > Hi,
> >=20
> > Le mercredi 07 juin 2023 =C3=A0 19:06 +0800, Sui Jingfeng a =C3=A9crit=
=C2=A0:
> > > Otherwise its failed to pass basic compile test on platform
> > > without
> > > REGMAP_MMIO selected by defconfig
> > >=20
> > > make -j$(nproc) ARCH=3Dmips CROSS_COMPILE=3Dmips64el-linux-gnuabi64-
> > >=20
> > > =C2=A0 SYNC=C2=A0=C2=A0=C2=A0 include/config/auto.conf.cmd
> > > =C2=A0 Checking missing-syscalls for N32
> > > =C2=A0 CALL=C2=A0=C2=A0=C2=A0 scripts/checksyscalls.sh
> > > =C2=A0 Checking missing-syscalls for O32
> > > =C2=A0 CALL=C2=A0=C2=A0=C2=A0 scripts/checksyscalls.sh
> > > =C2=A0 CALL=C2=A0=C2=A0=C2=A0 scripts/checksyscalls.sh
> > > =C2=A0 MODPOST Module.symvers
> > > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error
> > > 1
> > > make: *** [Makefile:1978: modpost] Error 2
> > >=20
> > > V2: Order alphabetically
> > >=20
> > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> >=20
> > The patch looks good to me. But I need an ACK from someone else to
> > apply to drm-misc-next.
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Thanks Sam!

Applied to drm-misc-next.

Cheers,
-Paul