Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230616070041.GA32700@didi-ThinkCentre-M930t-N000>
In-Reply-To: <20230616070041.GA32700@didi-ThinkCentre-M930t-N000>
From:   Lai Jiangshan <jiangshanlai@gmail.com>
Date:   Sun, 18 Jun 2023 09:19:55 +0800
Message-ID: <CAJhGHyDTQFCA1KJGZjnb9yV-es5f_rz2mvoXm-RuiKuW2fXvcQ@mail.gmail.com>
Subject: Re: [PATCH] workqueue: format pr_warn exceeds line length in wq_numa_init
To:     tj@kernel.org, jiangshanlai@gmail.com,
        linux-kernel@vger.kernel.org, zyhtheonly@gmail.com,
        zyhtheonly@yeah.net
Cc:     tiozhang@didiglobal.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 16, 2023 at 3:00=E2=80=AFPM tiozhang <tiozhang@didiglobal.com> =
wrote:
>
> Format this long line which would potentially let checkpatch complain
> "WARNING: line length of 103 exceeds 100 columns".

Hello

This patch hurts the readability actually. A few extra characters exceeding
is Okay for me.

Thanks
Lai

>
> Signed-off-by: tiozhang <tiozhang@didiglobal.com>
> ---
>  kernel/workqueue.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 47e7b29df5fe..4375c7190353 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -5959,7 +5959,8 @@ static void __init wq_numa_init(void)
>
>         for_each_possible_cpu(cpu) {
>                 if (WARN_ON(cpu_to_node(cpu) =3D=3D NUMA_NO_NODE)) {
> -                       pr_warn("workqueue: NUMA node mapping not availab=
le for cpu%d, disabling NUMA support\n", cpu);
> +                       pr_warn("workqueue: NUMA node mapping not availab=
le for cpu%d, disabling NUMA support\n",
> +                               cpu);
>                         return;
>                 }
>         }
> --
> 2.17.1
>