Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 18 Jun 2023 14:30:48 +0900
From:   Sergey Senozhatsky <senozhatsky@chromium.org>
To:     Yosry Ahmed <yosryahmed@google.com>
Cc:     Sergey Senozhatsky <senozhatsky@chromium.org>,
        Domenico Cerasuolo <cerasuolodomenico@gmail.com>,
        vitaly.wool@konsulko.com, minchan@kernel.org, linux-mm@kvack.org,
        ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com,
        hannes@cmpxchg.org, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH v3 1/7] mm: zswap: add pool shrinking mechanism
Message-ID: <20230618053048.GC2417524@google.com>
References: <20230612093815.133504-1-cerasuolodomenico@gmail.com>
 <20230612093815.133504-2-cerasuolodomenico@gmail.com>
 <20230618043857.GA2417524@google.com>
 <CAJD7tkbRn2txAt94keKTRbAA7--XF3rXSa8vsh9eGZa2CUWP8w@mail.gmail.com>
 <20230618052526.GB2417524@google.com>
 <CAJD7tkbcf+MEMJdGeruB7XL=J8tJNgkB7_1UQ2S4VEKjob-NQw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJD7tkbcf+MEMJdGeruB7XL=J8tJNgkB7_1UQ2S4VEKjob-NQw@mail.gmail.com>
Precedence: bulk

On (23/06/17 22:28), Yosry Ahmed wrote:
> > On (23/06/17 21:48), Yosry Ahmed wrote:
> > > > On (23/06/12 11:38), Domenico Cerasuolo wrote:
> > > > > +static int zswap_reclaim_entry(struct zswap_pool *pool)
> > > > > +{
> > > > > +     struct zswap_header *zhdr;
> > > > > +     struct zswap_entry *entry;
> > > > > +     struct zswap_tree *tree;
> > > > > +     pgoff_t swpoffset;
> > > > > +     int ret;
> > > > > +
> > > > > +     /* Get an entry off the LRU */
> > > > > +     spin_lock(&pool->lru_lock);
> > > > > +     if (list_empty(&pool->lru)) {
> > > > > +             spin_unlock(&pool->lru_lock);
> > > > > +             return -EINVAL;
> > > > > +     }
> > > > > +     entry = list_last_entry(&pool->lru, struct zswap_entry, lru);
> > > > > +     list_del_init(&entry->lru);
> > > >
> > > > A quick question: should we zswap_entry_get() here?
> > >
> > > We need to hold the tree lock for that, and the lock ordering is tree
> > > lock -> lru lock. If we try to grab the tree lock here we may
> > > deadlock.
> >
> > We can deadlock doing this?
> >
> >         lock tree_lock
> >         lock lru_lock
> >         list_del_init
> >         unlock lru_lock
> >         entry_get
> >         unlock tree_lock
> >         writeback
> 
> We don't know which tree the zswap entry belongs to

Oh... I must be blind. You are right. Sorry for the noise.