Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sumitra Sharma <sumitraartsy@gmail.com>
Cc:     Ira Weiny <ira.weiny@intel.com>, Deepak R Varma <drv@mailo.com>
Subject: Re: [PATCH v2] lib/test_bpf: Call page_address() on page acquired with
 GFP_KERNEL flag
Date:   Sun, 18 Jun 2023 07:07:00 +0200
Message-ID: <3564297.R56niFO833@suse>
In-Reply-To: <20230613071756.GA359746@sumitra.com>
References: <20230613071756.GA359746@sumitra.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On marted=EC 13 giugno 2023 09:17:56 CEST Sumitra Sharma wrote:
> generate_test_data() acquires a page with alloc_page(GFP_KERNEL). Pages
> allocated with GFP_KERNEL cannot come from Highmem. This is why
> there is no need to call kmap() on them.
>=20
> Therefore, use a plain page_address() on that page.
>=20
> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
>=20
> Changes in v2:
> 	- Remove the kmap() call and call page_address() instead.

NIT: Give credit to whom asked you for this removal and explain why the=20
mapping is not required.

> 	- Change the commit subject and message.
>=20
>  lib/test_bpf.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index ade9ac672adb..70fcd0bcf14b 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -14388,11 +14388,10 @@ static void *generate_test_data(struct bpf_test
> *test, int sub) if (!page)
>  			goto err_kfree_skb;
>=20
> -		ptr =3D kmap(page);
> +		ptr =3D page_address(page);
>  		if (!ptr)
>  			goto err_free_page;

What is the reason of this test? Could "ptr" ever be NULL? What is the code=
=20
checking just few lines above this latter test?

Please, take a deeper look at this function as a whole.

=46abio

>  		memcpy(ptr, test->frag_data, MAX_DATA);
> -		kunmap(page);
>  		skb_add_rx_frag(skb, 0, page, 0, MAX_DATA, MAX_DATA);
>  	}
>=20
> --
> 2.25.1