Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a5abbedd-0b68-f64c-d6d4-2e71e3fb13c4@loongson.cn>
Date:   Sun, 18 Jun 2023 14:22:37 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
To:     Paul Cercueil <paul@crapouillou.net>,
        Sam Ravnborg <sam@ravnborg.org>
Cc:     David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230607110650.569522-1-suijingfeng@loongson.cn>
 <c70cb3cb326439a5868beb54d720538923f653d1.camel@crapouillou.net>
 <20230617194843.GA1854380@ravnborg.org>
 <696b2c4144e454aa194e4487b41706075a70ae95.camel@crapouillou.net>
Content-Language: en-US
From:   Sui Jingfeng <suijingfeng@loongson.cn>
Organization: Loongson
In-Reply-To: <696b2c4144e454aa194e4487b41706075a70ae95.camel@crapouillou.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 2023/6/18 04:41, Paul Cercueil wrote:
> Hi,
>
> Le samedi 17 juin 2023 à 21:48 +0200, Sam Ravnborg a écrit :
>> Hi Paul,
>> On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
>>> Hi,
>>>
>>> Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
>>>> Otherwise its failed to pass basic compile test on platform
>>>> without
>>>> REGMAP_MMIO selected by defconfig
>>>>
>>>> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>>>>
>>>>    SYNC    include/config/auto.conf.cmd
>>>>    Checking missing-syscalls for N32
>>>>    CALL    scripts/checksyscalls.sh
>>>>    Checking missing-syscalls for O32
>>>>    CALL    scripts/checksyscalls.sh
>>>>    CALL    scripts/checksyscalls.sh
>>>>    MODPOST Module.symvers
>>>> ERROR: modpost: "__devm_regmap_init_mmio_clk"
>>>> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
>>>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error
>>>> 1
>>>> make: *** [Makefile:1978: modpost] Error 2
>>>>
>>>> V2: Order alphabetically
>>>>
>>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>> The patch looks good to me. But I need an ACK from someone else to
>>> apply to drm-misc-next.
>> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Thanks Sam!
Sam and Paul, thanks a lot, :-)
> Applied to drm-misc-next.
>
> Cheers,
> -Paul

-- 
Jingfeng