Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5421288rwd; Sun, 18 Jun 2023 11:04:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ457i0kPNZZrw/tWVAu+/7+2FLvus2kTaKkPa69d6PAXTXG417P4l6ldoD2Hh+yi71Noq6Q X-Received: by 2002:a17:90b:440b:b0:25c:308:e19c with SMTP id hx11-20020a17090b440b00b0025c0308e19cmr8390622pjb.25.1687111460143; Sun, 18 Jun 2023 11:04:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687111460; cv=none; d=google.com; s=arc-20160816; b=d41iOBixLGh5oDjp5m/STUIrWiTxTO0pLEUQ8HVT6bvUtaH39K4V2/kVm98uKdLx8I 5HtZH2YWYPj22sot4rW5mXvWMdEcDaOh0B7BvmZuKm6yot7laF2US23q2zuAInTfKwvm cBKQoKJ7PA7sRj8YOpI3d4OcYEVJJa2NxIIIIhhRZO3wWm9oDNQyZkCRnqn71QDRR7Nd kgK+JXTsOjrqaRLziXiVN8Uz3DVLYnPXU1bhuThpgWaVjz2w0AKdoSyyxeVkQGZMOA7t Pi2KTOkrc1AU8VwLpguFPwUe9eAesky5AoRGmSTu/AUPj0xwprL3BciFKF9yG0NmJzbe nhMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:reply-to:in-reply-to:references:mime-version; bh=O7Hb2dWT8B1Mlw123IWnpnFT/wjG+kiN6AocFrtTPYc=; b=D8tVB/BVcnj7AcbDXO9eyoF+2qENR9SRqx7ujo5pVIjRqplIkEkGPMZAOsy6Bjr1e7 kDBUMOFZIMSFVw+OFawaiQJsgQAnintzI4qsv20GPsrOPGwP56iwyxY/2TSpxYYWz1C9 si02BHQBhBbfeoEStNdew5xlnBf+uamegc6E780r9PW3iQvubPM9If87VQFo2tHeDsYF je3kGP8koKgZBc5ujhfcg/wg8idS+PATrIyEshCMShWT4tZSLhxAuLmbK49J8kUQyzu2 25hbRddhppk8NG3Za5kri0/AZ6z+yBUo5pVOxtfdN0w2+UIWH24fJghVQAr+zWdB/Gfs MG9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a17090a728e00b0025eb091e51esi6245223pjg.84.2023.06.18.11.04.02; Sun, 18 Jun 2023 11:04:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229585AbjFRRo4 convert rfc822-to-8bit (ORCPT + 99 others); Sun, 18 Jun 2023 13:44:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbjFRRot (ORCPT ); Sun, 18 Jun 2023 13:44:49 -0400 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CCA0E50; Sun, 18 Jun 2023 10:44:48 -0700 (PDT) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-5701eaf0d04so30726837b3.2; Sun, 18 Jun 2023 10:44:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687110287; x=1689702287; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=y9KdNjinEz6R6TTGochCLoYBY6M9YCjI05gTuZN0owo=; b=K4xWJFsWWR10wQk/m/23ozUX1d9agijoGl1/1kUZdqdCSGUMRQiWQUuBDef8gXRami iL+bbnSTfC2cCGwk2110bDFy18lPfmxu1GoKGAIxv3Oq0ZagFP8iJ4yNEe2Udc3q+oME MWRX4+NgwbVPcQ3Dnd2FuNJlGPlz6iFBn/8gWsFer3P0D/rPjoEzxfMEcbtL3Z7spNO8 m2+CJx9duPAwlUBmiMcCQjar0oECOTwE9RmMnn7jMUgDLKDkDbRD+DeE8B8qM61f9jWu egMUOGLm9UULpWLqGkKan1WIAEe2EOZsVkquNrWafMX+B6olz0isKNdBP5QWbGFnkY1Z tynA== X-Gm-Message-State: AC+VfDwRUO5GoN62ZOEFwB9gy1EiYS5hOgsB5rOtoSYo++VKKEBdBdBi vdXyJjG2WBjq+qcnn6cXdnUXrkOS4A1uoKGg894= X-Received: by 2002:a0d:c6c5:0:b0:56f:ee38:786a with SMTP id i188-20020a0dc6c5000000b0056fee38786amr6764626ywd.24.1687110286888; Sun, 18 Jun 2023 10:44:46 -0700 (PDT) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com. [209.85.219.181]) by smtp.gmail.com with ESMTPSA id o125-20020a815a83000000b00545a08184cesm6274821ywb.94.2023.06.18.10.44.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jun 2023 10:44:45 -0700 (PDT) Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-bb167972cffso2875788276.1; Sun, 18 Jun 2023 10:44:45 -0700 (PDT) X-Received: by 2002:a25:aa72:0:b0:bc9:51a1:5a86 with SMTP id s105-20020a25aa72000000b00bc951a15a86mr4340442ybi.64.1687110285167; Sun, 18 Jun 2023 10:44:45 -0700 (PDT) MIME-Version: 1.0 References: <20230615182938.18487-1-tanure@linux.com> <20230615182938.18487-7-tanure@linux.com> In-Reply-To: Reply-To: tanure@linux.com From: Lucas Tanure Date: Sun, 18 Jun 2023 18:44:33 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/6] arm64: dts: meson-t7-a311d2-khadas-vim4: add initial device-tree To: Yixun Lan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Kevin Hilman , Greg Kroah-Hartman , Nick , Artem , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 18, 2023 at 6:41 PM Lucas Tanure wrote: > > On Fri, Jun 16, 2023 at 1:01 AM Yixun Lan wrote: > > > > Hi Lucas: > > > > On 19:29 Thu 15 Jun , Lucas Tanure wrote: > > > The Khadas VIM4 uses the Amlogic A311D2 SoC, based on the Amlogic T7 SoC > > > family, on a board with the same form factor as the VIM3 models. > > I'd like to see little bit more verbose messages here, like > > which functionality/driver added here - cpu, gic, timer, uart? > Ok, I add this information in the next version. > Its adding CPU, GIC, and UART. > > > > > so, it's capable of booting into a serial console? > yes > > > > > > > > > - 8GB LPDDR4X 2016MHz > > > - 32GB eMMC 5.1 storage > > > - 32MB SPI flash > > > - 10/100/1000 Base-T Ethernet > > > - AP6275S Wireless (802.11 a/b/g/n/ac/ax, BT5.1) > > > - HDMI 2.1 video > > > - HDMI Input > > > - 1x USB 2.0 + 1x USB 3.0 ports > > > - 1x USB-C (power) with USB 2.0 OTG > > > - 3x LED's (1x red, 1x blue, 1x white) > > > - 3x buttons (power, function, reset) > > > - M2 socket with PCIe, USB, ADC & I2C > > > - 40pin GPIO Header > > > - 1x micro SD card slot > > > > > > Signed-off-by: Lucas Tanure > > > --- > > > arch/arm64/boot/dts/amlogic/Makefile | 1 + > > > .../amlogic/meson-t7-a311d2-khadas-vim4.dts | 112 ++++++++++ > > > arch/arm64/boot/dts/amlogic/meson-t7.dtsi | 202 ++++++++++++++++++ > > > 3 files changed, 315 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/amlogic/meson-t7-a311d2-khadas-vim4.dts > > > create mode 100644 arch/arm64/boot/dts/amlogic/meson-t7.dtsi > > > > > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > > > index cd1c5b04890a..1c5846bd1ca0 100644 > > > --- a/arch/arm64/boot/dts/amlogic/Makefile > > > +++ b/arch/arm64/boot/dts/amlogic/Makefile > > > @@ -74,3 +74,4 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb > > > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb > > > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air-gbit.dtb > > > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air.dtb > > > +dtb-$(CONFIG_ARCH_MESON) += meson-t7-a311d2-khadas-vim4.dtb > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-t7-a311d2-khadas-vim4.dts b/arch/arm64/boot/dts/amlogic/meson-t7-a311d2-khadas-vim4.dts > > > new file mode 100644 > > > index 000000000000..46e175536edf > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/amlogic/meson-t7-a311d2-khadas-vim4.dts > > > @@ -0,0 +1,112 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (c) 2022 Wesion, Inc. All rights reserved. > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include "meson-t7.dtsi" > > > + > > > +/ { > > > + model = "Khadas VIM4"; > > > + > > > + aliases { > > > + serial0 = &uart_A; > > > + }; > > > + > > > + reserved-memory { > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges; > > > + > > > + /* 3 MiB reserved for ARM Trusted Firmware (BL31) */ > > > + secmon_reserved: secmon@5000000 { > > > + reg = <0x0 0x05000000 0x0 0x300000>; > > > + no-map; > > > + }; > > > + > > > + /* 32 MiB reserved for ARM Trusted Firmware (BL32) */ > > > + secmon_reserved_bl32: secmon@5300000 { > > > + reg = <0x0 0x05300000 0x0 0x2000000>; > > > + no-map; > > > + }; > > > + }; > > > + > > > + xtal: xtal-clk { > > > + compatible = "fixed-clock"; > > > + clock-frequency = <24000000>; > > > + clock-output-names = "xtal"; > > > + #clock-cells = <0>; > > > + }; > > > + > > > + vddcpu_a: regulator-vddcpu-a { > > > + /* > > > + * MP8756GD Regulator. > > > + */ > > > + compatible = "pwm-regulator"; > > > + > > > + regulator-name = "VDDCPU_A"; > > > + regulator-min-microvolt = <689000>; > > > + regulator-max-microvolt = <1049000>; > > > + > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > + > > > + vddcpu_b: regulator-vddcpu-a { > > > + /* > > > + * MP8756GD Regulator. > > > + */ > > > + compatible = "pwm-regulator"; > > > + > > > + regulator-name = "VDDCPU_B"; > > > + regulator-min-microvolt = <689000>; > > > + regulator-max-microvolt = <1049000>; > > > + > > > + regulator-boot-on; > > > + regulator-always-on; > > > + }; > > > +}; > > > + > > > +&clkc{ > > > + clocks = <&xtal>; > > > + clock-names = "xtal"; > > > + status = "okay"; > > > +}; > > > + > > > +&uart_A { > > > + status = "okay"; > > > +}; > > > + > > > +&cpu0 { > > > + cpu-supply = <&vddcpu_a>; > > > +}; > > > + > > > +&cpu1 { > > > + cpu-supply = <&vddcpu_a>; > > > +}; > > > + > > > +&cpu2 { > > > + cpu-supply = <&vddcpu_a>; > > > +}; > > > + > > > +&cpu3 { > > > + cpu-supply = <&vddcpu_a>; > > > +}; > > > + > > > +&cpu100 { > > > + cpu-supply = <&vddcpu_b>; > > > +}; > > > + > > > +&cpu101 { > > > + cpu-supply = <&vddcpu_b>; > > > +}; > > > + > > > +&cpu102 { > > > + cpu-supply = <&vddcpu_b>; > > > +}; > > > + > > > +&cpu103 { > > > + cpu-supply = <&vddcpu_b>; > > > +}; > > > + > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-t7.dtsi b/arch/arm64/boot/dts/amlogic/meson-t7.dtsi > > > new file mode 100644 > > > index 000000000000..453b3d9cb9d8 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/amlogic/meson-t7.dtsi > > > @@ -0,0 +1,202 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. > > > + */ > > > + > > > +#include > > > +#include > > > + > > > +/ { > > > + compatible = "amlogic,t7"; > > > + interrupt-parent = <&gic>; > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + > > > + cpus { > > > + #address-cells = <0x2>; > > > + #size-cells = <0x0>; > > > + > > > + cpu-map { > > > + cluster0 { > > > + core0 { > > > + cpu = <&cpu100>; > > > + }; > > > + core1 { > > > + cpu = <&cpu101>; > > > + }; > > > + core2 { > > > + cpu = <&cpu102>; > > > + }; > > > + core3 { > > > + cpu = <&cpu103>; > > > + }; > > > + }; > > > + > > > + cluster1 { > > > + core0 { > > > + cpu = <&cpu0>; > > > + }; > > > + core1 { > > > + cpu = <&cpu1>; > > > + }; > > > + core2 { > > > + cpu = <&cpu2>; > > > + }; > > > + core3 { > > > + cpu = <&cpu3>; > > > + }; > > > + }; > > > + }; > > > + > > > + cpu100: cpu@100 { > > > + device_type = "cpu"; > > > + compatible = "arm,cortex-a53"; > > > + reg = <0x0 0x100>; > > > + enable-method = "psci"; > > > + capacity-dmips-mhz = <632>; > > > + dynamic-power-coefficient = <110>; > > > + #cooling-cells = <2>; > > > + }; > > > + > > > + cpu101: cpu@101{ > > > + device_type = "cpu"; > > > + compatible = "arm,cortex-a53"; > > > + reg = <0x0 0x101>; > > > + enable-method = "psci"; > > > + capacity-dmips-mhz = <632>; > > > + dynamic-power-coefficient = <110>; > > > + #cooling-cells = <2>; > > > + }; > > > + > > > + cpu102: cpu@102 { > > > + device_type = "cpu"; > > > + compatible = "arm,cortex-a53"; > > > + reg = <0x0 0x102>; > > > + enable-method = "psci"; > > > + capacity-dmips-mhz = <632>; > > > + dynamic-power-coefficient = <110>; > > > + #cooling-cells = <2>; > > > + }; > > > + > > > + cpu103: cpu@103 { > > > + device_type = "cpu"; > > > + compatible = "arm,cortex-a53"; > > > + reg = <0x0 0x103>; > > > + enable-method = "psci"; > > > + capacity-dmips-mhz = <632>; > > > + dynamic-power-coefficient = <110>; > > > + #cooling-cells = <2>; > > > + }; > > > + > > > + cpu0: cpu@0 { > > > + device_type = "cpu"; > > > + compatible = "arm,cortex-a73"; > > > + reg = <0x0 0x0>; > > > + enable-method = "psci"; > > > + capacity-dmips-mhz = <1024>; > > > + dynamic-power-coefficient = <550>; > > > + #cooling-cells = <2>; > > > + }; > > > + > > > + cpu1: cpu@1 { > > > + device_type = "cpu"; > > > + compatible = "arm,cortex-a73"; > > > + reg = <0x0 0x1>; > > > + enable-method = "psci"; > > > + capacity-dmips-mhz = <1024>; > > > + dynamic-power-coefficient = <550>; > > > + #cooling-cells = <2>; > > > + }; > > > + > > > + cpu2: cpu@2 { > > > + device_type = "cpu"; > > > + compatible = "arm,cortex-a73"; > > > + reg = <0x0 0x2>; > > > + enable-method = "psci"; > > > + capacity-dmips-mhz = <1024>; > > > + dynamic-power-coefficient = <550>; > > > + #cooling-cells = <2>; > > > + }; > > > + > > > + cpu3: cpu@3 { > > > + device_type = "cpu"; > > > + compatible = "arm,cortex-a73"; > > > + reg = <0x0 0x3>; > > > + enable-method = "psci"; > > > + capacity-dmips-mhz = <1024>; > > > + dynamic-power-coefficient = <550>; > > > + #cooling-cells = <2>; > > > + }; > > > + }; > > > + > > > + timer { > > > + compatible = "arm,armv8-timer"; > > > + interrupts = , > > > + , > > > + , > > > + ; > > > + }; > > > + > > > + gic: interrupt-controller@fff01000 { > > > + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; > > > + #interrupt-cells = <3>; > > > + #address-cells = <0>; > > > + interrupt-controller; > > > + reg = <0x0 0xfff01000 0 0x1000>, > > > + <0x0 0xfff02000 0 0x0100>; > > > + interrupts = ; > > > + }; > > > + > > > + psci { > > > + compatible = "arm,psci-0.2"; > > can you double check if it is actual version 0.2? > > most recent Amlogic SoC should support psci-1.0 > > > > > + method = "smc"; > > > + }; > > > + > > > + sm: secure-monitor { > > > + compatible = "amlogic,meson-gxbb-sm"; > > > + }; > > > + > > > + soc { > > > + compatible = "simple-bus"; > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges; > > > + > > > + apb4: apb4@fe000000 { > > > + compatible = "simple-bus"; > > > + reg = <0x0 0xfe000000 0x0 0x480000>; > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; > > > + > > > + clkc: clock-controller { > > > + compatible = "amlogic,t7-clkc"; > > > + #clock-cells = <1>; > > > + reg = <0x0 0x0 0x0 0x49c>, > > > + <0x0 0x8000 0x0 0x320>, > > > + <0x0 0xe040 0x0 0xbc>; > > > + reg-names = "basic", > > > + "pll", > > > + "cpu_clk"; > > > + }; > > > + > > > + ao-secure@140 { > > > + compatible = "amlogic,meson-gx-ao-secure", "syscon"; > > > + reg=<0x0 0x10220 0x0 0x140>; > > > + amlogic,has-chip-id; > > > + }; > > > + }; > > > + > > > + uart_A: serial@fe078000 { > > > + compatible = "amlogic,meson-t7-uart"; > > > + reg = <0x0 0xfe078000 0x0 0x18>; > > > + interrupts = <0 168 1>; > > > + status = "disabled"; > > > + clocks = <&xtal>, <&clkc CLKID_UART_A>, <&xtal>; > > > + clock-names = "xtal", "pclk", "baud"; > > > + fifo-size = < 64 >; > > > + pinctrl-names = "default"; > > > + }; > > I believe there are more uart ports, it's worth the effort to add them all in one run, > > which sounds more consistent to me, anyway you could also choose to add them > > in later patch series, no problem.. > > Yeah, I prefer to add those uarts later, when I can propper test them. > > > > > > + }; > > > +}; > > > + > > > -- > > > 2.41.0 > > > > > > > > > _______________________________________________ > > > linux-amlogic mailing list > > > linux-amlogic@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-amlogic > > > > -- > > Yixun Lan (dlan) > > Gentoo Linux Developer > > GPG Key ID AABEFD55 The datasheet I have doesn't mention the version of PSCI supported, so I can't check. But It continues to work ( serial log ) when using the 1.0 version.