Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5458055rwd; Sun, 18 Jun 2023 11:55:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4DyjZY33OVR8Ee2MTpcQCNKWX6ZmJ2frgYIJufAJh9VLuAfRPMHbdJXfxtLI/hGJgz6xu5 X-Received: by 2002:a17:90a:35b:b0:252:7372:460c with SMTP id 27-20020a17090a035b00b002527372460cmr10244511pjf.4.1687114515493; Sun, 18 Jun 2023 11:55:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687114515; cv=none; d=google.com; s=arc-20160816; b=0aOAzFV6P/YBl9bZJWWNf2P2qkmygop6DV1WmNYZboBic/I4jVtaTd4WMTFmoMPm26 7XcJ1poWQZ68qalvvxdse46bbLqcrys7xoljgsYkm3hFWGVBWkoZuutDJDaRzUpeO+Vi miOC3sQEwIAPklSKmobaZFrUgzYL4By0tLMEH8omnZefHRy2Y98YEZ6UVVfaeEBeszIN /dvxq1++Reyt9pxc0IiYp+YSbAKAJ8I0yKLbQywome4VxkCNZvjD2Vto0fjHCnwwUCd2 zWfPcgOJ65CQUA7nLm2XfOM026exK0YQ0v62K+BWqr1wleQVXu7z4jB/IK6aJrUj30qS g3og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:dkim-signature:date; bh=2gq+bYRas3vv/uVQDWtA3oQ5H+lnWu07gVDXKsDZ16w=; b=lbPEXjuJlNe6jyRNIQiwRKDPExJ6jypXbeG6DEPWy+t1JSf8zNpvLs8igYp+z8X9yo ZyqoMWkpbYfW4UIHNCXbb9h9zm/BwISpGRawRWyUqPG5v9YgmnOsmBvtHBmf+wm+InxX pIpouqZyhNzKIw7lOeCyr8b4Uhu5juhul33a3BcFtMLRgRa4Nq8vpY1lXqkdL9oTmxRS 5CzAZxhpzOmi86h4xCjLLm16tFkGhBlU96NnKAbwAPlJKWio6xGw8VQehjh1M1stuSfp gf2JIHFdPbWBlHhG/tm3Tw/ohleb2sTgVO4WlJz9h+Nn4RsAx9ZG3prjlUy+EJUJnp4E rFow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=q8p6aQpS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a17090a6ac900b0025691c00096si6109251pjm.140.2023.06.18.11.55.01; Sun, 18 Jun 2023 11:55:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=q8p6aQpS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbjFRSx2 (ORCPT + 99 others); Sun, 18 Jun 2023 14:53:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjFRSx1 (ORCPT ); Sun, 18 Jun 2023 14:53:27 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2621BB; Sun, 18 Jun 2023 11:53:23 -0700 (PDT) Date: Sun, 18 Jun 2023 20:53:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1687114395; bh=rLTd3jpeF1FaigKyO68fT4DEucsRqZYkjGpFz56TY1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q8p6aQpS1h6Vj8KyaE/d+OPQtiY0JJejyn81bL5ZMtRTUhripMvDJhsw8hMX2xBmE nMwA3CGF36yE50tujmrVOB8qW98lzXcWPGxE/WDn7rFUv6KXlvkLCEa3kGd5RvciIv q4EpoWDpRxIwsqe9QRnIrVK4l/MXxNfFLUvXisCU= From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jorge Lopez Cc: hdegoede@redhat.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com Subject: Re: [PATCH v17 00/13] hp-bioscfg driver Message-ID: <207d43d3-ae23-4b6e-a75a-5632e0dd66c5@t-8ch.de> References: <20230608163319.18934-1-jorge.lopez2@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230608163319.18934-1-jorge.lopez2@hp.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jorge, On 2023-06-08 11:33:06-0500, Jorge Lopez wrote: > Signed-off-by: Jorge Lopez > > .../testing/sysfs-class-firmware-attributes | 101 +- > MAINTAINERS | 6 + > drivers/platform/x86/hp/Kconfig | 16 + > drivers/platform/x86/hp/Makefile | 1 + > drivers/platform/x86/hp/hp-bioscfg/Makefile | 11 + > .../x86/hp/hp-bioscfg/biosattr-interface.c | 312 +++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 1055 +++++++++++++++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 487 ++++++++ > .../x86/hp/hp-bioscfg/enum-attributes.c | 447 +++++++ > .../x86/hp/hp-bioscfg/int-attributes.c | 409 +++++++ > .../x86/hp/hp-bioscfg/order-list-attributes.c | 436 +++++++ > .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 543 +++++++++ > .../x86/hp/hp-bioscfg/spmobj-attributes.c | 386 ++++++ > .../x86/hp/hp-bioscfg/string-attributes.c | 390 ++++++ > .../x86/hp/hp-bioscfg/surestart-attributes.c | 132 +++ > 15 files changed, 4730 insertions(+), 2 deletions(-) > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/int-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/string-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c That looks much better now! Thanks for all the resubmissions. For the full series: Reviewed-by: Thomas Weißschuh Thomas