Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e80d385d-5515-ed42-e5dd-f9c977f7d4d1@gmail.com>
Date:   Sun, 18 Jun 2023 22:26:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3 0/4] Trivial code cleanup patches
To:     Yogesh Hegde <yogi.kernel@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc:     dan.carpenter@linaro.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        skhan@linuxfoundation.org, ivan.orlov0322@gmail.com
References: <cover.1687092111.git.yogi.kernel@gmail.com>
Content-Language: en-US
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <cover.1687092111.git.yogi.kernel@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/18/23 15:03, Yogesh Hegde wrote:
> Rename variables in struct rtllib_device to avoid CamelCase which is not
> accepted by checkpatch.
> 
> ---
> v3: The driver is split into 2 modules, calling the functions directly which
>      the v2 of the patchset does breaks compile. So reverting back to v1 of
>      the patch as suggested by Greg Kroah-Hartman <gregkh@linuxfoundation.org>.
> 
> v2: Removed the variable and called the function directly instead of
>      just renaming the variable as suggested by Greg Kroah-Hartman
>      <gregkh@linuxfoundation.org>.
> 
> 
> 
> Yogesh Hegde (4):
>    staging: rtl8192e: Rename variable SetWirelessMode
>    staging: rtl8192e: Rename variable SetBWModeHandler
>    staging: rtl8192e: Rename variable LeisurePSLeave
>    staging: rtl8192e: Rename variable InitialGainHandler
> 
>   drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c |  4 ++--
>   drivers/staging/rtl8192e/rtl8192e/rtl_core.c   |  8 ++++----
>   drivers/staging/rtl8192e/rtl819x_HTProc.c      |  4 ++--
>   drivers/staging/rtl8192e/rtllib.h              | 12 ++++++------
>   drivers/staging/rtl8192e/rtllib_rx.c           |  2 +-
>   drivers/staging/rtl8192e/rtllib_softmac.c      | 12 ++++++------
>   drivers/staging/rtl8192e/rtllib_softmac_wx.c   |  6 +++---
>   7 files changed, 24 insertions(+), 24 deletions(-)
>
This patch series alone is fine. But when my patch series ([PATCH 0/9] 
staging: rtl8192e: Remove unsupported modes a and 5G) is applied before 
it fails as we change same lines. Will see what happens.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>