Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <348fbe1a-6c2d-68d2-b4fc-278407ede33c@amd.com>
Date:   Sun, 18 Jun 2023 20:58:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v2 1/5] cpupower: Recognise amd-pstate active mode driver
To:     Wyes Karny <wyes.karny@amd.com>, trenn@suse.com, shuah@kernel.org
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        rafael@kernel.org, gautham.shenoy@amd.com, Ray.Huang@amd.com,
        Perry.Yuan@amd.com
References: <20230616120620.147643-1-wyes.karny@amd.com>
 <20230616120620.147643-2-wyes.karny@amd.com>
Content-Language: en-US
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230616120620.147643-2-wyes.karny@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzE5K1RPaUVNMmRkSE1kZzdETlI1NllvZy9HTzE0dEJTWTNkcHMyN2FWYnhX?=
 =?utf-8?B?RlF6T3FtM3RsYnplZVZWOXlDQUJYRHR1KzcrWUVqUHpYYWN5VTd5UkdCc3ox?=
 =?utf-8?B?ZzY5NVVlQkUzbG1BMlNHdXZNT1RLYWgvSWQvbkR0aVZKNG1OV2grN1B0aXJZ?=
 =?utf-8?B?QTdGNTIrMkN4cU96ME95bnFZSGN4Qm5xa3hnWDVad2hsUFBhMDZHdFhNVWhQ?=
 =?utf-8?B?MmdxUnBZdkRGU2g2Qk91RTlEVEdMRlJHUllDTEcwc0tHSXhGTkZMbU9ESFha?=
 =?utf-8?B?cmxnRlZ1M1hBLzdabFNEemlRdXMxQWt2Q0VyVkNjTUxobW9hNktuczNFNE5R?=
 =?utf-8?B?eWN1UHpnTDdvY0xEUXJKcXk1TCtGR0lvT3YyM25ZYkFLYUpUaHZiVElKeWZo?=
 =?utf-8?B?UG8xdm1uQjBnc0JoUlpRWm9YTS9VdXNGT3NrOUpHY2F2S1VGTmRncU5ocWdm?=
 =?utf-8?B?OEJSMWdJQVdhRUFtR2xSY3BNUzZ2MjdpU3o1NllxK0xoVGdXaFIxdlNzb2I0?=
 =?utf-8?B?UlY2eVJHdnd4OWYwMENpNnlyQkxQMmtZc3VYZ3VBYW5IMlBjRlNyS3UwaHFC?=
 =?utf-8?B?WGFOcXdPOXB6NXY0a3ZKY2R5aGhQaEhxTU81ZVVnYUdWb211cHJTRzVOTWcr?=
 =?utf-8?B?ZWpxL2E5aFJhbndROWx1SW85UXhyQ1hyNEVjWmFPQUZBNjhxdVZINHl2Y2Yr?=
 =?utf-8?B?R3piUXR1SERmOWJDQnNYKzBXbHRaMEdJNlZNZm9yazliNGZ4U1N6TlNna0Zy?=
 =?utf-8?B?ZHRXcmNlQ0ppMVdEK3I5Q2F0R3l4ejduMFpuaXdrNUY0THpEUWF6YnEvT2pG?=
 =?utf-8?B?cjZMNmc4RmlxWURsVURYUURPaE83ZzBRYk9aZndLZkhHRU5RM3JLbVlDVDhv?=
 =?utf-8?B?dEczamNzYkdzS05iL21kUkp2TFBCNkhXNUlwZXBOVVZzdnN6TVYwdjdDTlJ2?=
 =?utf-8?B?ajNRVTRJOG54U2lGT2dxa21rTjRDYVVVZ1BZR1doUzJJdnYwU2MrcEQzRmxZ?=
 =?utf-8?B?VS9UQmUwYjJ2QkpjT3pFcnZlOUNMZGNGY3pOQ05wY1U0YlpsUE91clBiQ24y?=
 =?utf-8?B?Q3IyVTBlbmt4L1JMTytJOE4rNk5WUVkxNlRZcEp4US9ra0JlY0Vva1lROU5Y?=
 =?utf-8?B?SU0xMHRKblg4MDdIbGErdmF5cHhsMDJPL2dTWVBQdUI3ZTAwQVJzbnhMTzFW?=
 =?utf-8?B?MndSZTY3ZlFiOGdqTno0TFoyWVpud0hSWmpiK0pSZDhPRDlpTk0zNHlkdnZn?=
 =?utf-8?B?WE9LT0R4cXpnTVFza1dGNit2clZIdW5iZjBZMjFseXFiYzluNktDQ1U2M1E0?=
 =?utf-8?B?aTA2RHY3VU1qTWNPTzg1RVRHa3p2VC91QnlOUk41a1N3QStTUlptMHN6U1Mr?=
 =?utf-8?B?UnNSeWJYWUxzdExlUWtyRHhlK0F6RXdKZTVwMGltWjVrMElLbnRQdEtOK0RR?=
 =?utf-8?B?OXUxSlAxMFJNWUZkcHZUUTlBeWhZMThIR1BEYmxVdjNxeGt2UUFPZlMyamVQ?=
 =?utf-8?B?bGdLYjZ2V2FmWmdlK3o2RlFmbFdGV2dWa2hIWjJucUhmQ1lvUTRDRmVtbW5J?=
 =?utf-8?B?MUFJU3NVSmtjZHlJRkg0eXZGbTlRSDhkNTJyUWlIL080RGlNTVpqK09aMzFm?=
 =?utf-8?B?UzFEbDFaa0drSXJPc2F3MTY4S2JFYXNQTldnNkNHeEdLRjRPaDkwNVd2YnRy?=
 =?utf-8?B?dW1nY1RjV2ZXVDRnY1dFeTc1NlFXbXRCakpkaU16ckhPc0l4TEVtcjRnOHpX?=
 =?utf-8?B?dFhhREVXcVRFZk95UkphcU5Qb3NVdFFHaDgwWXhEZmxtY0VnNlYrR0d0RDJt?=
 =?utf-8?B?bm5WMXZLcnA5a2NCTzdBenplZDAvRExMdXh4bGtCdmVXaEtTaTRjbnphdU50?=
 =?utf-8?B?ME1qZVlhUmwzUVo3S09ib2R5RytKL2RORzRtbUsydnU5NzcvTVdsUDRPUTBM?=
 =?utf-8?B?ckVXVGtNUXg0U3JhVDZVQVZ6M2JVbHZXdlFhRUJSMVExYkFiMDRxbDJ0Nk5q?=
 =?utf-8?B?VUIyUjdESU90SUNhU1B2MW81d1k3bWlqMWZWOWFVcDUvUzRuTWRLQkdHOFJQ?=
 =?utf-8?B?TjlMKzE0cTZpNjNaR0RZNmlVbFNlVkhZN3crR3pjbkJwU1Fka3lQdk53S1I0?=
 =?utf-8?B?UGsyYVFsajdtYzBxS0lFN1V4enhYcE1RTlB3K2F3RXB6TEtldkhTRTB5SnNs?=
 =?utf-8?B?ZkE9PQ==?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b0a8872-3ced-4949-6425-08db7068a5b9
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 01:58:16.3940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kK6fVDQPHFYmFRRub+Kru2rF+Z5tlInzs9SmpJj4700kmljl8z99ip+GhP+O2okP/Sax9gx0LAxnOOrQWFIvNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4493
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/16/23 07:06, Wyes Karny wrote:
> amd-pstate active mode driver name is "amd-pstate-epp".  Add this to the
> string matching condition to recognise amd-pstate active mode driver.
> 
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> ---
>   tools/power/cpupower/utils/helpers/misc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> index 9547b29254a7..21f653cd472c 100644
> --- a/tools/power/cpupower/utils/helpers/misc.c
> +++ b/tools/power/cpupower/utils/helpers/misc.c
> @@ -95,7 +95,7 @@ bool cpupower_amd_pstate_enabled(void)
>   	if (!driver)
>   		return ret;
>   
> -	if (!strcmp(driver, "amd-pstate"))
> +	if (!strcmp(driver, "amd-pstate") || !strcmp(driver, "amd-pstate-epp"))

To avoid getting caught in the case that a kernel didn't have the patch 
separated from this series (for example if a distro missed it in a 
backport from separate directories), how about using strncmp() instead 
and just look for the prefix?

This would also let the tool be more future proofed in the case another 
amd-pstate driver was introduced later down the road as long as it stuck 
to "amd-pstate*"

>   		ret = true;
>   
>   	cpufreq_put_driver(driver);