Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eddd118b-a10b-7208-7e96-df909d038233@amd.com>
Date:   Sun, 18 Jun 2023 21:42:18 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v2 0/6] Enhance AMD SMN Error Checking
Content-Language: en-US
To:     Yazen Ghannam <yazen.ghannam@amd.com>, x86@kernel.org
Cc:     linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        markgross@kernel.org, hdegoede@redhat.com,
        Shyam-sundar.S-k@amd.com, linux-edac@vger.kernel.org,
        clemens@ladisch.de, jdelvare@suse.com, linux@roeck-us.net,
        linux-hwmon@vger.kernel.org, babu.moger@amd.com
References: <20230615160328.419610-1-yazen.ghannam@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230615160328.419610-1-yazen.ghannam@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anhVeHR4bHhtMzVic2w0OWVUcjFkbXovYVgyelVEei91TmYrMlRpRlV2UGkr?=
 =?utf-8?B?T0F0Z0dDKzNzV3JwMmNuSldzNTVSS2JvK2QwWEtCdzdtMDVUblcxMnZORUdo?=
 =?utf-8?B?Y1l4ZHlXRG9INFFkMjYvTDdDaExFVEFwci9BdDg4Q2dFblVjWVllbTUrcFBy?=
 =?utf-8?B?ZGVCbTZ1Z1N6WXdvdzZRNmU1Qk5GbkpsYS9odVBzQzVBd3pmTXhzbEZSRFY3?=
 =?utf-8?B?aVhKSzcrc0tYTCt5SlNUU0ZVb3p3RjZackxlYWFtYlhtVFBna2poenkxMlcx?=
 =?utf-8?B?NFE5VWQzc2dkV0t6Q2xtYkdNdjFrQi9tUHcxZmhjb2FocHVDbm1kdkVrWGVS?=
 =?utf-8?B?VUN0N1hNYUcxYWNUOHRrZmN0bHE3Q2VsaCtpeTk5akxHQVc4VTBHNXd2bDMw?=
 =?utf-8?B?UExKSHBFeDgxRkZEejFrY2RPRHRzMjZPN201VlhENnBUamlaTjhJQ1BNU1NI?=
 =?utf-8?B?SVJ2OG5KZVVHUFljQmM5UFBmM1RBSVV2Yi9PMXlnOHdaUGJyMGVJdmdOSGtX?=
 =?utf-8?B?eUZrMncxVnAvNmRrUlJ3RHFUTnFYcHFIaXRXWkJ6YUlsMU16d1ZYamZxd3gy?=
 =?utf-8?B?cUJSV0tmRGdLMGJzRGI0NFoxQU90amdzNmRadk1obkdUZUhTQUFid1RKYWJI?=
 =?utf-8?B?clluSWxpOHc2SjVrNHNKMHFGWnZ5clk2ZkZrMjVyYmVyYytHTm11R1Z1MTlF?=
 =?utf-8?B?R3ZvMUlHdEk2ME1pLzZHQStkNXZhQjRyTzFMdkE5cFpHTHgvY1hWcTI2TVJa?=
 =?utf-8?B?Vkp1Q3B5RkR5emVzRndtbUZDeUx0TE1SYlhPSzZxbTVoTFpKZ1NIOUpWbEIy?=
 =?utf-8?B?aGZ0WHdOSnIvVWl2V05zajJtd3laZGp2MnZlLy9jM0ZOaEI0K3VYOE1telpi?=
 =?utf-8?B?cklKaS9CcEVTRjQrbWFFb0ZwOU9zQThuWEhEZlBJbm1nd0ZQdHdQUHJWTFds?=
 =?utf-8?B?a0p4MkhxU1BqVkxZaUZpZXlGZm9iZlZ0K2orTHRYcTZPK3BhenNndlJUaWd3?=
 =?utf-8?B?ckRhKzV6bXMvaGNCTWY0TnUyMS9kV1hjMXlFeU9NNDFHWmNDdld0TE53VlAz?=
 =?utf-8?B?VUFkM0k1L2tFdXc0TldlbVNrZENwYUFFM3F0MTlXZEJVU1BKTFdHSndxQ3h4?=
 =?utf-8?B?VjhETXZMT2NLbU44cHhQRWpIQmVpMWNBTUovYXVxWGVLc0FuYW5xY2F3bWlL?=
 =?utf-8?B?bWxLSTNVeHc1L1Y3bERWK1E0MnhOQkRYMVZnQjNEbXF4Qjc1NDlFZ2l5VmpX?=
 =?utf-8?B?TzJIdnJja3Z5WUhhRHhMNXFuZEI5b0V4N003TWZSRVd3c1crSklCQy9wYmE1?=
 =?utf-8?B?M1c4STBuQVRHNm9hd0ZEb2Y3SzdrOFRISnpYSTJkVHNNUjcyTGU3cXhCeUg4?=
 =?utf-8?B?dzdZcFpOWjVlR1dCdmV1b3RoOXlHWHdRREZrNEIxODdLdnd0MGR3bnhOTkx0?=
 =?utf-8?B?S0xWVmgyWHJya3JNLzNWSkJnWjU5Ni9hdzNlcDNlUkh3QnVybFRyZkN4Wndl?=
 =?utf-8?B?UkM5Y3MrZU9hNWJ4RFY2QXdTcG5SdTR4RHNmTDNUWDJ0NTBrOVVYOW5SME1R?=
 =?utf-8?B?c2l1SUpGejE4Y2xBZzNiYkd2clFTRTBqdXhHYXZNT2dOOGxxQ3JsQWdZSERn?=
 =?utf-8?B?eG03SWQ0T3Q2QlY0VHlKL2VwUFRIVFJkUkVDdEtKaWRBTWtNYi9Sc2JnZEtk?=
 =?utf-8?B?bUk4T2dPRkFTVGdXY2w5VzVMQU8rSDNtZ0FtdWZMdGFCRjF0RVI1WUVVWnRX?=
 =?utf-8?B?dHBDQ0Zub2daeVZlYlRUOWtMWGRha3ppZjR0eFdBMVBXd01xVExWR29nTUps?=
 =?utf-8?B?US9JWmZGVkpmSEZlVmFFeTl6YU1iTy80M2ZDenc4cmdZVW13aHVHT2NJNjE0?=
 =?utf-8?B?V01MdUE3KzhLMk1pZE03L3hhdHVmcC9GUkphTVI5VFpZWHIzd1lQbGJJZUhz?=
 =?utf-8?B?S1VYYk9nV2Y5Y3JPZzhLU0JHeW1BZktkYlFnd2Q2bWZhVldnL0ova29LUlRU?=
 =?utf-8?B?Yzc5dDFkQTByVmIybXBaZllHS2VMUjNFQXV0TjNrNEgwWkhqYXhHcXFSNDFD?=
 =?utf-8?B?RkwrVi9KZDJXenNzNnFwYzE2TWVOR0ptQ1FUTjQweGpPKzBFT3UvZkJmQmI1?=
 =?utf-8?B?NzBzNDBvZDhIazVJQXgxOWtmUTNwNmZ4cXhLdE1LK1NyWVBOaVlnYzhnbGRV?=
 =?utf-8?B?d0E9PQ==?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b0879cc-89f1-4bc4-128c-08db706ece47
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 02:42:21.3751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Q3jBY+XKJgNS3H/kADbZ4JdEGg7o2Yrv0C4q94I9K89c0e6h0krAt8BXSnI+wguDHvcSxUKG6g0celB4PP4/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9046
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/15/23 11:03, Yazen Ghannam wrote:
> Hi all,
> 
> This set implements more robust error checking for AMD System Management
> Network (SMN) accesses.
> 
> This set is a follow up to this discussion:
> https://lore.kernel.org/lkml/20230403164244.471141-1-yazen.ghannam@amd.com/
> 
> Patches 1-3:
> 	- Pre-patches in AMD64 EDAC and K10Temp modules.
> 	- Required in order to avoid build warnings with the
> 	  introduction of the __must_check attribute in patch 4.
> Patch 4:
> 	- Introduces __must_check attribute for SMN access functions.
> 	- Handles "PCI Error Response" behavior for SMN reads.
> Patches 5-6:
> 	- Optional cleanup patches in k10temp.
> 	- Not required for the SMN access issue, but I thought they may
> 	  be good to do.
> 

Each of the patches in the series looks good to me.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> I've included x86 platform driver folks for awareness, since there are
> some AMD SMN users there.

These uses seem to be handled fine by the existing error checking to me.
There is also a consumer of amd_smn_read/amd_smn_write in 
arch/x86/pci/fixup.c that I think looks fine still.

> 
> Thanks,
> Yazen
> 
> Link:
> https://lore.kernel.org/r/20230516202430.4157216-1-yazen.ghannam@amd.com
> 
> v1->v2:
> * Rebase on tip/master.
> * Address comments from Guenter.
> 
> Yazen Ghannam (6):
>    EDAC/amd64: Remove unused register accesses
>    EDAC/amd64: Check return value of amd_smn_read()
>    hwmon: (k10temp) Check return value of amd_smn_read()
>    x86/amd_nb: Enhance SMN access error checking
>    hwmon: (k10temp) Define helper function to read CCD temp
>    hwmon: (k10temp) Reduce k10temp_get_ccd_support() parameters
> 
>   arch/x86/include/asm/amd_nb.h |  4 +--
>   arch/x86/kernel/amd_nb.c      | 46 ++++++++++++++++++++----
>   drivers/edac/amd64_edac.c     | 68 +++++++++++++++++++----------------
>   drivers/edac/amd64_edac.h     |  4 ---
>   drivers/hwmon/k10temp.c       | 57 +++++++++++++++++++----------
>   5 files changed, 119 insertions(+), 60 deletions(-)
>