Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 0/9] MIPS: CI20: Add WiFi / Bluetooth support
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <ebf776a8fb8dee045e7661daaca4564fe39917a6.camel@crapouillou.net>
Date:   Mon, 19 Jun 2023 06:42:46 +0200
Cc:     list@opendingux.net, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Conor Dooley <conor+dt@kernel.org>, linux-mips@vger.kernel.org,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Paul Boddie <paul@boddie.org.uk>,
        Paul Burton <paulburton@kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <92BF3D49-42EB-4153-BB64-20031CF25A11@goldelico.com>
References: <20230615084006.79194526F801@goldelico.com>
 <C1924536-FA97-4E75-9D22-99E5AF24EE5B@goldelico.com>
 <A8EBCBA4-D9BA-4C2F-9C91-38128D06EDBA@goldelico.com>
 <AA802E24-A97B-42B6-90A4-5ECB1E4D9294@goldelico.com>
 <5EF6B0D2-2B84-4C98-B799-88062E035EC1@goldelico.com>
 <43DCEEA5-C013-44BE-85C7-D61A980B0EA5@goldelico.com>
 <ebf776a8fb8dee045e7661daaca4564fe39917a6.camel@crapouillou.net>
To:     Paul Cercueil <paul@crapouillou.net>
Precedence: bulk

Hi Paul,

> Am 18.06.2023 um 13:51 schrieb Paul Cercueil <paul@crapouillou.net>:

>> And the issue seems to be that without matching the node names the
>> voltages in the device tree may have been ignored completely all the
>> time... Now it sets up voltages, which should happen. But different
>> ones for my board which breaks boot.
>=20
> So the node names fix caused the driver to actually use the info from
> DT, which doesn't allow the board to boot. Nice.

Very good summary :)

As usual the fix is just a one-liner, finding what to do is multi-hours.

>=20
>> Finally I did risk (I have no replacement CI20 board and they are no
>> longer
>> on sale... RS part# was 125-3305 Mouser 456-VL-62851) to run a test
>> with
>> rename to "DCDC1" but changing the voltage to 1200mV. And this
>> version boots.
>=20
> Looking at the JZ4780_DS.PDF file, the SoC actually wants 1.1V so the
> DT is not wrong - in theory. But in practice it does not work, as you
> experienced yourself. However, if the ACT8600 defaults to 1.2V, or if
> the bootloader configures it to 1.2V, I would think that this is
> actually a voltage that the SoC can handle - otherwise the SoC would =
be
> overvolted until the kernel starts, and the board design would be
> flawed.
>=20
> I measured that the old 3.x kernel keeps the SoC voltage at 1.2V, so =
it
> sounds like a better default. Therefore the fix here would be to raise
> the DCDC1 regulator to 1.2V.

I finally found my JZ4780_DS.pdf (Release Date: Nov. 20, 2014).

According to Table 3-1 the absolute maximum for VDDcore is 1.21V.
According to Table 3-2 the recommended range is 0.99V to 1.21V. 1.1V is =
only "typical".
According to 1.3 Characteristic: "the Core should run at 1.1 -0.1/+0.2V"

So 1.1V should be right...

But in practise it may be that the ACT8 seems to come up with 1.2V
as chip-internal default during boot. Or U-Boot is initializing it as =
well.

Maybe I find some time to measure some test point or capacitor while
breaking into U-Boot.

BR,
Nikolaus