Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <93574312-f467-04af-92af-5b5476043977@amd.com>
Date:   Mon, 19 Jun 2023 09:50:40 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3 1/3] perf test: Add metric value validation test
To:     "Wang, Weilin" <weilin.wang@intel.com>
Cc:     Kan Liang <kan.liang@linux.intel.com>,
        "Alt, Samantha" <samantha.alt@intel.com>,
        "Taylor, Perry" <perry.taylor@intel.com>,
        "Biggers, Caleb" <caleb.biggers@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        Ian Rogers <irogers@google.com>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <CAP-5=fVixzBLLiWnim8x6qcDOKH7uVfEWojTCP_H531Fhy7j-g@mail.gmail.com>
 <20230614203824.2895333-1-weilin.wang@intel.com>
 <20230614203824.2895333-2-weilin.wang@intel.com>
 <bc18bc42-3df8-30c9-10ff-8a4ba3d3d9f6@amd.com>
 <CO6PR11MB56353207BBD7BDA6C530EBDEEE5EA@CO6PR11MB5635.namprd11.prod.outlook.com>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CO6PR11MB56353207BBD7BDA6C530EBDEEE5EA@CO6PR11MB5635.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wk5rOWkrVnBMM2lURHZ0Y0p6UVh2b212dDB3cUU3RFBkY1Z1YmpHb1BrUGpu?=
 =?utf-8?B?MHFaRVlzRkRrL3lZQ3dEdlByaVZVK0FTWE1LWFpkQ2wrYVl6THRoYkVUL01o?=
 =?utf-8?B?NWYwRnJRQmlIdmc4V2M1aUpPbnVyTEVDTzhUODhwbjBMcVI1RW8zTzJkS1BD?=
 =?utf-8?B?TXdtNEtQUnkyV2pmajdCTTdLc0xrMjUweHdGaFZ0bE1RNUdXKy9iUGJBcXVN?=
 =?utf-8?B?Q29XU0pyS2pUdnYzMXRUMklNV1dsUDZzalJPdEhGbEJaTkh2UkRxd2hralpz?=
 =?utf-8?B?WVExU241enZneFg5VkpZR3NOa0hJcUZZcFNOSDJJRFlFZWxscUIrcUZpOThn?=
 =?utf-8?B?TkJSWmRKYi90b0lFN2xqaXFRZ3ZmRi9FOUhIWWFSek5LU255YjBQbWFyYnVK?=
 =?utf-8?B?aHJUYW5UZG53RkwyMmMzbG5zaEsrdi9sQXlvQ1FST2tubkJvUkNTRndDSmRD?=
 =?utf-8?B?UnFoamRLS3Y0UGgvcHB5dnljNlN0R0dwYWFCNVFMWXJ1TjlqODdlSTZYc3Yw?=
 =?utf-8?B?SGJzTkk2NEFNVWdkUlE5NkNldC9iVUlpTmxRWmVqSkRES3lObHl6NHJKdzc2?=
 =?utf-8?B?TTA1c1ViQWYzVlJrVWZDdy8rR1BlRDJ5blFRM0xYZVJtdlQ4bWJ5b1dnRmpQ?=
 =?utf-8?B?YWQrUjExR3JLaUVhMTJ1b0UzL1pkSCtFRUE0aUtjdk4rVVo2UWtJTlQ4RWpx?=
 =?utf-8?B?TWZMZU1MWmRyQmltWDBZY3I1WWRYMStBMEFvSGpXcDhZTXFFZTlsVXZJUmFO?=
 =?utf-8?B?TVpweTY1K0lmWkJYNjVCeVo0eXppNzZhRWkyLzNhVVU0SlJKQnlYNmVmQ25E?=
 =?utf-8?B?UFIzYmd0MHVMR2JqOFNQdEd4Nmxxb2hhbUQvMkdZazZNZHYyR3UyL0dmV1RD?=
 =?utf-8?B?emxEMWljWTIzSFBENkZWbUxOaEc1Zm9LelE4L1NSYmFhYURvOUYyWXhZSWFa?=
 =?utf-8?B?anlIdjdJWlp6MklsM3lkM0xOWHRTUGRVT1d2QmpGak8rU0UweTIrZmh3RlVy?=
 =?utf-8?B?RG10SEowdzFTbEM3ZnNMQzRTdnBQZzdhSXorOFJ2SXF6ZDM5UnRQcVEwZlFU?=
 =?utf-8?B?SmpxZXJCY1Q0U3hqNVk3T3ozamJLdThudUhvOVNXTW1CYU5BclZTWm1RaFVD?=
 =?utf-8?B?TTMvZHEzYmpuR3hRSzJEMTVUSjBvM0VYM0xZcEREeDhoc1lNRDR1VkNZZlhx?=
 =?utf-8?B?MjVzRU9UV0JBZWhIYTZqcVVpRXI5Q2p3azlnQkVveEx3c1RHVGdYS2tXTUZk?=
 =?utf-8?B?ODQ2b09vVElqRUdwc3lyS2JBbms0RFk1UWhjTGphSU84cWU3QnA2QmtLTGFL?=
 =?utf-8?B?eW9TalB6UWp5SThsRFAxR25lbHFHODhqN0NpNHZ6OVlOVldSUmhtMmxxOUs5?=
 =?utf-8?B?NDZvTXplR2dSalZjVjJqK1NGejNPVysybXFob095T1FkdDdxdHZMc09uYXNJ?=
 =?utf-8?B?UThqcVBLVjExb29xR2U1Z3g1SzFvalprajVWZTZJZng0M1UwVTI2Y1AzVTNQ?=
 =?utf-8?B?cFp5WjRyQnhyZmQrQS85bGEvS3NxTDMzL1RUcmpaK0xmeTZlZ3lnWkFqaHFV?=
 =?utf-8?B?c3BUYXZWcWdzU01rZW9meVFNeTV6bkttYW5HckJyVWdvL2ZOQWFxb1JhQ1hw?=
 =?utf-8?B?Wld4Z3psYVRRS3VycnR3YWM2THVtem5mV1Nsb3JVTlI5N2o3aitnZVNyTnZm?=
 =?utf-8?B?dTZQbnpod091bE0wTlU1c3RhcE1qVHp4ZE9tWTA3MzhhdzVabHpTL1ZRYkRP?=
 =?utf-8?B?akUrbkJPbWFEWkNtTHBBMnR5WnpncVpmd1J5UEp6Tktaejl4SUY4bmUvVjFH?=
 =?utf-8?B?a2oyaE96UGNpbkdGbE9tTFFoTElXV0NuWkY4M0g2aDVEUHQ1c21JTDZsZlI4?=
 =?utf-8?B?MWpVSjBRODNWME0xeFIyM1YrOGN4eGIrdDRLdndRSllCc3dWK2xTSEhXUWMy?=
 =?utf-8?B?ZGh5ZG15YnhwbkpBVVRyandKQUFLZm9RN1hZMjl4eWYrcTlWYVpaZEkyZU90?=
 =?utf-8?B?MFNCb2JENENrcmgrSmM2RmZ1aktFc1d0R05zcTNldjFxQ25BWnkwcWwvdS9O?=
 =?utf-8?B?cmlnakxBMTZLVWZiQW5rQ3dsMm5YTmc1em51K2p4WTBEYjl1a3pZSXduR3dS?=
 =?utf-8?Q?Yns++M6Ot5m/9HqH63PHedmx2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f28ee2e4-08d4-4121-933e-08db707cb341
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 04:21:49.2227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iGwckIyxfoWbczu+mmy9f3/sutdbi56y59NBPWtqSOZ0melqjylBaRNDizyZcROxnfaIsTAH7N3bscCW/41Q7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8895
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> +grep -q Intel /proc/cpuinfo || (echo Skipping non-Intel; exit 2)
>>
>> This check doesn't seem to be working. On my Zen3 AMD machine:
> 
> Thanks for reporting this! I've update this search to "GenuineIntel" in v4 to help solve this issue. 
> Please check it out. 

I'm sorry. I should have been more elaborative.

What I mean was () in bash creates a sub shell and thus exits from
the sub shell. I think what you need is {}. Ex:

  grep -q Intel /proc/cpuinfo || { echo Skipping non-Intel; exit 2; }


>>   test child finished with 0
>>   ---- end ----
>>   perf metrics value validation: Ok
>>
>> I haven't yet investigated whether it's genuine or false positive.
>>
> Base on this final report, it validated some basic rules like the 12 metrics for positive value test and 2 metrics for single metric value checks. 
> The test script grabs metrics supported on the platform and generates validation rules that only include metrics in the supported list. 
> Therefore, it is not surprising that the check passes on your system. 

Got it.

Thanks,
Ravi