Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ajay Kaher <akaher@vmware.com>
To:     Zheng Yejian <zhengyejian1@huawei.com>
CC:     Steven Rostedt <rostedt@goodmis.org>,
        "mhiramat@kernel.org" <mhiramat@kernel.org>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-trace-kernel@vger.kernel.org" 
        <linux-trace-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "chinglinyu@google.com" <chinglinyu@google.com>,
        Nadav Amit <namit@vmware.com>,
        "srivatsab@vmware.com" <srivatsab@vmware.com>,
        "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
        Alexey Makhalov <amakhalov@vmware.com>,
        Vasavi Sirnapalli <vsirnapalli@vmware.com>,
        Tapas Kundu <tkundu@vmware.com>,
        "er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>
Subject: Re: [PATCH v2 2/9] eventfs: adding eventfs dir add functions
Thread-Topic: [PATCH v2 2/9] eventfs: adding eventfs dir add functions
Thread-Index: AQHZfOihtJyVNC2DX0SIfIcIdDOcAq9QJhqAgANEQYCAPniBgA==
Date:   Mon, 19 Jun 2023 05:24:48 +0000
Message-ID: <5543FD40-36FC-4459-BF78-E2C0A361E9AE@vmware.com>
References: <1683026600-13485-1-git-send-email-akaher@vmware.com>
 <1683026600-13485-3-git-send-email-akaher@vmware.com>
 <ba8b6072-42b6-4275-83fd-5497654d77db@huawei.com>
 <A1697525-CE86-4CA3-A8D5-3452E9310A4C@vmware.com>
In-Reply-To: <A1697525-CE86-4CA3-A8D5-3452E9310A4C@vmware.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ihKMew1L+2LdezHTtuHyyA57US8tmtiEWntmFcxJDKkr4K051kg1CO9dLOr2?=
 =?us-ascii?Q?3iKF5FvFB1wNpPKywpV1sw7u4bgRPVShB9r2Ej2X2w4fcSKw1+zxynDg3ko9?=
 =?us-ascii?Q?2SgEjukTbap6FBgoNqsiSu4B0rfJc/CCJdgxqb3BPMs2BnF54nBP2pyjqSvu?=
 =?us-ascii?Q?5L118x4DKiMMeQMZcDdf5K5IadFwWAEKryRvVfUvjGC8L/drL71Vw9vzViB0?=
 =?us-ascii?Q?R5T/CYxqIkm0Hxem7bVo3qGrtRwyupyZldj6GjXB9DmqSsft7XFT/FYsfFjw?=
 =?us-ascii?Q?At/nwT1jGI18MKux+E/oO2SNaC+3Mo4FurM3Oyphnn2FWLWLlTGf3tmWKRlm?=
 =?us-ascii?Q?D1MYwhD7nmYI21pM6Qic/AjhYCZ/mUyvyyei1r5n7ASda7ztpzCQ+BUeQ44q?=
 =?us-ascii?Q?lmXU5cyW1IR4PmOlRH7XlXvGRoqGOvCOebLK4/OdWb6lx7rk+SPjRa0/xrsz?=
 =?us-ascii?Q?O788m1R3bxJP8F93YQOCX10eiEAcxW108INYbadjUrkrWlseGWcGBmQAEFD9?=
 =?us-ascii?Q?bYY/NIEmCLFFm99C6y3x2U4IACQVouKvGEGTxXVR2tq//Vdu9FndsY0mODu1?=
 =?us-ascii?Q?y45iH0Bvq9HtQo9czrXPfsKmVmc4tstfDCVRbkthaxpNr4RV1uMZODHx7Xjd?=
 =?us-ascii?Q?862Gpep9hNd2TXQ22Y/k71Yjc0fHm/Y3M3M8+S4nOjyxaFBFvHqQLDiG7nMk?=
 =?us-ascii?Q?Qe2nB2fVWERcWCk6nGViWxSpCdGMkJiMMsJJI5SUXomUuaHABSwRWGb+12P5?=
 =?us-ascii?Q?ia1MT9rioA59Pr33tfyVorcQvXFYiDwmrDf6o+qXeUSgrYGcNn40XePA3cgg?=
 =?us-ascii?Q?FplkD8GK3AbjEFge6ZveFBORPlpWTQS/dMTMx3Sur0RoZTvPR5wL3fMwgFls?=
 =?us-ascii?Q?e8dh3EttHVtfB5sX0KceM2f3ZeT3g5SUt2ynfqg/KILo/kYGXBPHUdy5nJuj?=
 =?us-ascii?Q?w1kUM0tXtnYfizUP+IYPe06K/bsPbas+0Z0Lso/EQW35sL9V55hO//8YeqJm?=
 =?us-ascii?Q?9gaId8hZQ+SEOa86eil8fBUJcQhdiNDFWVcw4JsdDY2uKy8FtoSTU7QDx91N?=
 =?us-ascii?Q?2LoSnDctYStpN4naAQLJpRelvUSneHlLu9PzcKKrNZiwADeAwz5a919fs0hh?=
 =?us-ascii?Q?hHV4ugogmyDXKZ1Pg3TmUMhtT1KB045V8yNH0MciE17/VmUpgeXrYj9lEiVH?=
 =?us-ascii?Q?r4AXcuV5VbQs9W4hbUHGrIN6poKLs+oKHDRnSJo1ygbrZ2+glAyWNgPHB4c9?=
 =?us-ascii?Q?yYPQGLw+IEoQWpcek5DWOAYjI6WZW8ySkrFYhwoKL9bjr3y3AVsU1U2PHPyo?=
 =?us-ascii?Q?aK3166mlmoSsjRQyKnP5LgIfwqbOxRbkx0C/X5yUVwC+GbHTsBvmdZmpV/+P?=
 =?us-ascii?Q?d8ebGfMUrJ2oVCxBuC5JPtWMu3LG718gUReq7TKLUrksP/5FB+Xou1D9seeB?=
 =?us-ascii?Q?xB7FRv9VWsUylF3lPQMVROPrXpyAQaILTaz8/qF4wKdlriBx4EBGOy4amnD9?=
 =?us-ascii?Q?o3pWAryqTMuNGFRYooluAI/5bYnuMU1p++kCBcv1jHNNKxTuTw+AUBs2IHZJ?=
 =?us-ascii?Q?Ip/+sQb4itbh1nzrobAbuMfnXQiPy8D2Wv3rVyHh?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0E1CC86D530D6B4FAB533A343D92950C@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8703.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd5f8db7-21f7-4355-d871-08db70858036
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2023 05:24:48.7017
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dm4DGXtLnPH7uvpciHA3n3L0ea6rzCTEtWvl+ogXT6agwslyIiXPjwce2wU3nuMbsVGeJF1WzLX9xdZjfnfVXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR05MB10200
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On 10-May-2023, at 4:55 PM, Ajay Kaher <akaher@vmware.com> wrote:
>>=20
>> Hi,
>> eventfs_add_subsystem_dir() and eventfs_add_dir() are almost the same,
>> how about extract a common help function to simplify them, like:
>>=20
>> +static struct eventfs_file *__eventfs_add_dir(const char *name,
>> +                                             struct dentry *d_parent,
>> +                                             struct eventfs_inode
>> *ei_parent,
>> +                                             struct rw_semaphore
>> *eventfs_rwsem)
>> +{
>> +       struct eventfs_file *ef;
>> +
>> +       ef =3D kzalloc(sizeof(*ef), GFP_KERNEL);
>> +       if (!ef)
>> +               return ERR_PTR(-ENOMEM);
>> +
>> +       ef->ei =3D kzalloc(sizeof(*ef->ei), GFP_KERNEL);
>> +       if (!ef->ei) {
>> +               kfree(ef);
>> +               return ERR_PTR(-ENOMEM);
>> +       }
>> +
>> +       INIT_LIST_HEAD(&ef->ei->e_top_files);
>> +
>> +       ef->name =3D kstrdup(name, GFP_KERNEL);
>> +       if (!ef->name) {
>> +               kfree(ef->ei);
>> +               kfree(ef);
>> +               return ERR_PTR(-ENOMEM);
>> +       }
>> +
>> +       ef->mode =3D S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO;
>> +       ef->iop =3D &eventfs_root_dir_inode_operations;
>> +       ef->fop =3D &eventfs_file_operations;
>> +       ef->dentry =3D NULL;
>> +       ef->created =3D false;
>> +       ef->d_parent =3D d_parent;
>> +       ef->data =3D eventfs_rwsem;
>> +
>> +       eventfs_down_write(eventfs_rwsem);
>> +       list_add_tail(&ef->list, &ei_parent->e_top_files);
>> +       eventfs_up_write(eventfs_rwsem);
>> +       return ef;
>> +}
>> +
>> +struct eventfs_file *eventfs_add_subsystem_dir(const char *name,
>> +                                              struct dentry *parent,
>> +                                              struct rw_semaphore
>> *eventfs_rwsem)
>> +{
>> +       struct tracefs_inode *ti_parent;
>> +       struct eventfs_inode *ei_parent;
>> +
>> +       if (!parent)
>> +               return ERR_PTR(-EINVAL);
>> +       ti_parent =3D get_tracefs(parent->d_inode);
>> +       ei_parent =3D ti_parent->private;
>> +       return __eventfs_add_dir(name, parent, ei_parent, eventfs_rwsem)=
;
>> +}
>> +
>> +struct eventfs_file *eventfs_add_dir(const char *name,
>> +                                    struct eventfs_file *ef_parent,
>> +                                    struct rw_semaphore *eventfs_rwsem)
>> +{
>> +       if (!ef_parent)
>> +               return ERR_PTR(-EINVAL);
>> +       return __eventfs_add_dir(name, NULL, ef_parent->ei, eventfs_rwse=
m);
>> +}
>=20
> Sounds good. Thanks for sharing code snippet. I will consider in v3.
>=20

Hi Zheng, I have moved common code to eventfs_prepare_ef() in v3 3/10, 4/10=
:
https://lore.kernel.org/all/1685610013-33478-1-git-send-email-akaher@vmware=
.com/

-Ajay