Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <79b816e7-c331-49f9-058c-02828623ad94@gmx.de>
Date:   Mon, 19 Jun 2023 06:27:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to
 pte_mkwrite_novma()
Content-Language: en-US
To:     Rick Edgecombe <rick.p.edgecombe@intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Cc:     linux-parisc@vger.kernel.org
References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com>
 <20230613001108.3040476-2-rick.p.edgecombe@intel.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20230613001108.3040476-2-rick.p.edgecombe@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Q3URMTomAwk=;Iq/ukwVLHjd5s1CHDl+VsOB0F4B
 8TnW0jk7VIRTsMwACfoXCavITJZ+RO71QddeHEkNrpKC5980P45PR7twjf3p3Q7D0Qz2P8tqA
 /XDaGjgEVoXzNKfBuO8Ep/jYEwIDgaDbvK37acFmM+Bolub/PwcmkGYPX1qj9gxPCl7CocyZt
 rZ+FxNcF2IBiksTAnVLU7ewz78SDZYH2khNEuiLo0fPkL7J7NFexfh9E+ygl38bBFTtlGzC4f
 vRueC9MGLD4DleuUfc2ycBs3ApmB7m78bE1Tyvz78eon40gtr9VKeJ9P/EgdKP+4jNwyVOHjT
 J/O8XgRAQ9EVFjUv9RyKqEZwXQcklGCmfAdOe4VHW4eqEkfgmYi93GHlC9wfG52q5X9kwT6jK
 +KQvuHrV8NjYQSvZZLZN5LlzitNvdrl9FQ7qZ2ax4jokWZI6xcSt/9sdRGE9HEx8oCl4HOvXE
 i/04l7PrmCzIrp92dN8ikjGg06yJKu9mglmk6ka98P5DkKfEVCLYxbK95KN0g992kCPJphzUW
 0/CTdsZhl0Nf8p67cQPXv+BGgFk62IS3+EjQ9xPna5LpJhq199uFASfzGyJC94k9j6sKdm2jd
 oAFBlkrQDe61LnRjDP5Uq2mF5Wt72KUPspzinDDKmPLd26C+NWiTy1omRKOoeRBdX2jGHSgzr
 7Qry5BXxIRKm68TuEmmGcpVh9d6L21/y0hzLQsW6qS1FALz9EvhClHv0pqKXsS0JAvilx+bVz
 LyqyZGp2duVkNTPzuwx4Oo9VOBpg0XXS12zBy3y2XSROnqadqmGRAWvjk6Owoxi4Y1ukEvDyg
 i3vakQcp7veDUSIy1BJiflPhJ/EXg8sie0bOkCfzXKFLv5KoVZRGINt6P3myqQ158Z+YenJeJ
 Q+NUuyUeS3Cp3oW8chby1NEsMma7WNMKN5AojipQZu5J2CQlvJVhuWGXO8nXDMjES8PmlKJQd
 Ju/N+L9TBexz2jkHcF3qUwbzK/o=
Precedence: bulk

On 6/13/23 02:10, Rick Edgecombe wrote:
> The x86 Shadow stack feature includes a new type of memory called shadow
> stack. This shadow stack memory has some unusual properties, which requi=
res
> some core mm changes to function properly.
>
> One of these unusual properties is that shadow stack memory is writable,
> but only in limited ways. These limits are applied via a specific PTE
> bit combination. Nevertheless, the memory is writable, and core mm code
> will need to apply the writable permissions in the typical paths that
> call pte_mkwrite(). Future patches will make pte_mkwrite() take a VMA, s=
o
> that the x86 implementation of it can know whether to create regular
> writable memory or shadow stack memory.
>
> But there are a couple of challenges to this. Modifying the signatures o=
f
> each arch pte_mkwrite() implementation would be error prone because some
> are generated with macros and would need to be re-implemented. Also, som=
e
> pte_mkwrite() callers operate on kernel memory without a VMA.
>
> So this can be done in a three step process. First pte_mkwrite() can be
> renamed to pte_mkwrite_novma() in each arch, with a generic pte_mkwrite(=
)
> added that just calls pte_mkwrite_novma(). Next callers without a VMA ca=
n
> be moved to pte_mkwrite_novma(). And lastly, pte_mkwrite() and all calle=
rs
> can be changed to take/pass a VMA.
>
> Start the process by renaming pte_mkwrite() to pte_mkwrite_novma() and
> adding the pte_mkwrite() wrapper in linux/pgtable.h. Apply the same
> pattern for pmd_mkwrite(). Since not all archs have a pmd_mkwrite_novma(=
),
> create a new arch config HAS_HUGE_PAGE that can be used to tell if
> pmd_mkwrite() should be defined. Otherwise in the !HAS_HUGE_PAGE cases t=
he
> compiler would not be able to find pmd_mkwrite_novma().
>
> No functional change.
>
> Cc: linux-doc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-alpha@vger.kernel.org
> Cc: linux-snps-arc@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-csky@vger.kernel.org
> Cc: linux-hexagon@vger.kernel.org
> Cc: linux-ia64@vger.kernel.org
> Cc: loongarch@lists.linux.dev
> Cc: linux-m68k@lists.linux-m68k.org
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: linux-mips@vger.kernel.org
> Cc: openrisc@lists.librecores.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-riscv@lists.infradead.org
> Cc: linux-s390@vger.kernel.org
> Cc: linux-sh@vger.kernel.org
> Cc: sparclinux@vger.kernel.org
> Cc: linux-um@lists.infradead.org
> Cc: linux-arch@vger.kernel.org
> Cc: linux-mm@kvack.org
> Suggested-by: Linus Torvalds <torvalds@linuxfoundation.org>
> Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
> Link: https://lore.kernel.org/lkml/CAHk-=3DwiZjSu7c9sFYZb3q04108stgHff2w=
fbokGCCgW7riz+8Q@mail.gmail.com/
> ---
> Hi Non-x86 Arch=E2=80=99s,
>
> x86 has a feature that allows for the creation of a special type of
> writable memory (shadow stack) that is only writable in limited specific
> ways. Previously, changes were proposed to core MM code to teach it to
> decide when to create normally writable memory or the special shadow sta=
ck
> writable memory, but David Hildenbrand suggested[0] to change
> pXX_mkwrite() to take a VMA, so awareness of shadow stack memory can be
> moved into x86 code. Later Linus suggested a less error-prone way[1] to =
go
> about this after the first attempt had a bug.
>
> Since pXX_mkwrite() is defined in every arch, it requires some tree-wide
> changes. So that is why you are seeing some patches out of a big x86
> series pop up in your arch mailing list. There is no functional change.
> After this refactor, the shadow stack series goes on to use the arch
> helpers to push arch memory details inside arch/x86 and other arch's
> with upcoming shadow stack features.
>
> Testing was just 0-day build testing.
>
> Hopefully that is enough context. Thanks!
>
> [0] https://lore.kernel.org/lkml/0e29a2d0-08d8-bcd6-ff26-4bea0e4037b0@re=
dhat.com/
> [1] https://lore.kernel.org/lkml/CAHk-=3DwiZjSu7c9sFYZb3q04108stgHff2wfb=
okGCCgW7riz+8Q@mail.gmail.com/
> ---
>   arch/parisc/include/asm/pgtable.h            |  2 +-

Acked-by: Helge Deller <deller@gmx.de> # parisc

Helge