Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Hennerich, Michael" <Michael.Hennerich@analog.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: RE: [PATCH] Input: adp5588-keys - Use devm_regulator_get_enable()
Thread-Topic: [PATCH] Input: adp5588-keys - Use devm_regulator_get_enable()
Thread-Index: AQHZoOsKoEunsN+aiU2H1tZ+fhc5Dq+Rphbw
Date:   Mon, 19 Jun 2023 06:05:06 +0000
Message-ID: <SN7PR03MB7132B49CE99BBB1CFB53E7F38E5FA@SN7PR03MB7132.namprd03.prod.outlook.com>
References: <af343b5b0d740cc9f8863264c30e3da4215721d7.1686985911.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <af343b5b0d740cc9f8863264c30e3da4215721d7.1686985911.git.christophe.jaillet@wanadoo.fr>
Accept-Language: de-DE, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yIfZDjb/WAiDx7JGmsgpZzBM2Oz2YLUkXTvD3bTGHNB06+VaVlmyeFOBR7px?=
 =?us-ascii?Q?z5RJbG56q/a23jGLV2KqRFoc3Ci5rgof8w6TOM6/gqHjsbe4T6FYVlGN6P51?=
 =?us-ascii?Q?0TdlmHShtzRFw4v0focAhfZLflgd4Jh3Qk9GjOhaYnP32C2yhM/k0SQwOO1i?=
 =?us-ascii?Q?L+RwhEFHsAQivyDkWMzQWSpdKusvvRxg3VhzvK60gAc2SoOwsjbBN1xSGQ6c?=
 =?us-ascii?Q?xJrrNMAxfwP/eW5FWCvZK/FJepSWOyRs7yFBTi6QT6J3sdSYvInNwYsC/g6A?=
 =?us-ascii?Q?oDWl4T+m1R+72PjQum30xLJLH26nc4gvBfXOKC7gdpptu5Pd6jA617ujQb2o?=
 =?us-ascii?Q?YE4lXHjufhQYF9I0WGZxOhY8yxSV+qd2QCxTrqKHgURnjCJ6NafrbxC/6fNU?=
 =?us-ascii?Q?SffevbMjJH1OiXtPLI9zwg14WW7wNfzmJPP72CvH/N1yC6RNOZ59A7icyvDi?=
 =?us-ascii?Q?5K0B2pWzzSPCzBKMCbS+7RjKRdlxzG87f1VR7t8itESYtAliuz/5QwOAr6s2?=
 =?us-ascii?Q?vRyedMcwf2MKyD098A2KOk71y3PqoWXn/HogTQrTYryLAEwvXK1eDjL4Dso2?=
 =?us-ascii?Q?hWoZIa8lqj46w5ue8AZVOVrw4av3r9siPKfod2qtCLqOkH+TabIsvWVi39UY?=
 =?us-ascii?Q?7FqUa/qqhR20Oj03bcrC1yX+Gms+PLG4al0zwxTXzU3bgia/v/5ECLIbv5Wm?=
 =?us-ascii?Q?3XqR8XEpxJs6HXlUMy3VoS22X6OAzFABQBH4Ml6Jp+4Nb6KEPGk9XHcBEyPt?=
 =?us-ascii?Q?399bBolaxhXolZyfwcn3hbgl2MJiGxPspHvcNp3h4h8O8lDgLMrVdyiL6C74?=
 =?us-ascii?Q?YI8EUn25KZMlLLfxWnAenuGTclN2crzFddbfUzhQQtwSjnTwET20YnoPYdv2?=
 =?us-ascii?Q?n6rf1dIhnv1yVuuBbGJrlUisSH/0A0b5ltpv4TudaqDgKBHh3sHYylxqQw2+?=
 =?us-ascii?Q?OoZcyoIYjUHrPidZ7uImflCu2QzpvGAQjGRMiQ/qs1qoWhZgVzUl2so/FOxs?=
 =?us-ascii?Q?dW1HvqYB2rt0AOyrhadcwRnEAA9e/XB6m8dQzDMebeTxTNWzgZ6QFy/ygYV0?=
 =?us-ascii?Q?sEJTQ6BESmrd6YayXev5BR3/O+UQz0R9M91vFIL1oOyBGlkoniXVvTtn6fFI?=
 =?us-ascii?Q?DvYhxdj2Nvjq8CyHz+ELjG5oOkMUuJ0dwNe/j0KvJWou2TnNNXe3KtUZKvnh?=
 =?us-ascii?Q?HfUF4QC6Y9jlExdW8TaSPD1qg1+s32fxWIN3zy8cVMQpetyhi7sKuaX01aPo?=
 =?us-ascii?Q?KSWs2odnFDbyTmHouu4+kJELDuKUO3zLpHFXL5Q5Uz3zLTiSq0eQ9fCWIzAl?=
 =?us-ascii?Q?yjaqt/6Px1wfUY0JEANOm216LUJfT2A40UMD+rfhZ0SPPtMBg/kXTvRz9xrN?=
 =?us-ascii?Q?IYqoYn/Wtlc3GfI0bf1A6QJZQ/4q0X0B1aBPMrtHWuH/uYYcFLT7rYEVxwmU?=
 =?us-ascii?Q?Avk1W3xnXAY2F/RV703pRGxJ1fX/AYA4bJ1oJukhxMcB1zLY5KEpHZ/FnRoC?=
 =?us-ascii?Q?C1XyQuZKPCjyrKl2DiTXYrSKewgBEKjM5LbLd5tuenqrodklgGwzhCCVlpR0?=
 =?us-ascii?Q?PRfD8yxNE/B7SE0H/rXIM/ECu6V/lLciQ9ThzxHssZQ2GRdVIUTsuHOsmvVD?=
 =?us-ascii?Q?/Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR03MB7132.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00139839-a21c-4adf-7693-08db708b2155
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2023 06:05:06.4597
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: q+bupwBjnM1/4Khy8uk18ECpOb6jgh8r8XegOX4mgetIHNv9Wvc9VM6wmw67vSnBshg1xpefhviBb6NaHcrk2XbCDYMn3N21O/FwzP51vcw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR03MB7270
X-Proofpoint-ORIG-GUID: A93hOAO90UBMvIvItQKzPIPn6c5EJlcO
X-Proofpoint-GUID: A93hOAO90UBMvIvItQKzPIPn6c5EJlcO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-19_03,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 suspectscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 spamscore=0
 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1011 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306190055
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Samstag, 17. Juni 2023 09:12
> To: Hennerich, Michael <Michael.Hennerich@analog.com>; Dmitry Torokhov
> <dmitry.torokhov@gmail.com>
> Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christ=
ophe
> JAILLET <christophe.jaillet@wanadoo.fr>; linux-input@vger.kernel.org
> Subject: [PATCH] Input: adp5588-keys - Use devm_regulator_get_enable()
>=20
> Use devm_regulator_get_enable() instead of hand writing it. It saves some=
 line
> of code.
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/input/keyboard/adp5588-keys.c | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
>=20
> diff --git a/drivers/input/keyboard/adp5588-keys.c
> b/drivers/input/keyboard/adp5588-keys.c
> index 896a5a989ddc..61e8e43e9c2b 100644
> --- a/drivers/input/keyboard/adp5588-keys.c
> +++ b/drivers/input/keyboard/adp5588-keys.c
> @@ -713,17 +713,11 @@ static int adp5588_fw_parse(struct adp5588_kpad
> *kpad)
>  	return 0;
>  }
>=20
> -static void adp5588_disable_regulator(void *reg) -{
> -	regulator_disable(reg);
> -}
> -
>  static int adp5588_probe(struct i2c_client *client)  {
>  	struct adp5588_kpad *kpad;
>  	struct input_dev *input;
>  	struct gpio_desc *gpio;
> -	struct regulator *vcc;
>  	unsigned int revid;
>  	int ret;
>  	int error;
> @@ -749,16 +743,7 @@ static int adp5588_probe(struct i2c_client *client)
>  	if (error)
>  		return error;
>=20
> -	vcc =3D devm_regulator_get(&client->dev, "vcc");
> -	if (IS_ERR(vcc))
> -		return PTR_ERR(vcc);
> -
> -	error =3D regulator_enable(vcc);
> -	if (error)
> -		return error;
> -
> -	error =3D devm_add_action_or_reset(&client->dev,
> -					 adp5588_disable_regulator, vcc);
> +	error =3D devm_regulator_get_enable(&client->dev, "vcc");
>  	if (error)
>  		return error;
>=20
> --
> 2.34.1