Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cf24db95-9c91-5d30-fe83-3a1e2cbf0cc1@suse.com>
Date:   Mon, 19 Jun 2023 09:28:22 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3 5/5] x86/entry: Make IA32 syscalls' availability depend
 on ia32_enabled()
To:     Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org
Cc:     linux-kernel@vger.kernel.org, mhocko@suse.com, jslaby@suse.cz
References: <20230616125730.1164989-1-nik.borisov@suse.com>
 <20230616125730.1164989-6-nik.borisov@suse.com> <87mt0wqxkt.ffs@tglx>
Content-Language: en-US
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <87mt0wqxkt.ffs@tglx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjQxTjhFekZXQ0QrcU53Uk95YXYvRUdWOFJkOGd3NG9ndmVZeHhsWUU1Ukl4?=
 =?utf-8?B?TldhWDBjUzRYUEJrN0R1NzB3S3VQTHFYYUZFcTkvaFVhMnJUQjVXR1JuRGZi?=
 =?utf-8?B?MjYwOUdCK0N2NGNmWTFJcStyNDJPaWYvTDhpM0xhclR5SnRuZkgwUkI5bE8z?=
 =?utf-8?B?R0ZFeDZ3dnVUUjdlR21Ua2pVU0pwWk5oL2t3RG1scHdlN25ZYm8zcTRjZmRw?=
 =?utf-8?B?anIzeWdVYlhtSTZJSld2UE9ZaENpUloyU2kxUTVVV1dKb09mMXNrOG9kV3RL?=
 =?utf-8?B?K3p3blVwVURmRUluR0RQNGpaR2ZWeENJcUJ6eWZyaHk5NzJnV0hPMDI1SllV?=
 =?utf-8?B?QzE4Yk9yV0FzZHM1anFxMGcwZzhkLzFnN3pYQTVSMndpeXl5RUJOZDZCKzZw?=
 =?utf-8?B?Tkl2Y3J6Y2VRMzlBbDlGdVk1YWZZdEthK2dYMUtTOEUxVTg0M1BSRnAyQUdJ?=
 =?utf-8?B?TXorU1gyOG02WithRkpMbzhScmxKUUxIZCtMUm1iMElzVHlRb05YY2RyUXJz?=
 =?utf-8?B?ZEVLLzA5ZXZnbVhOcFZhZnhueEJVSkFkZExIaklweGY2cThkbDBFbGRwTU9E?=
 =?utf-8?B?QlpYVW1LK0VHYVZrc094dDcvcEp1bWVCejBTZjQ3TFNTbjlkSjBkZk5nREh0?=
 =?utf-8?B?Uk82M2sxQWV6dU5nSE54SC9Pd2FPSWFFRlRWQWhHWUtDajhkYVM4MlRvbm15?=
 =?utf-8?B?YUlMLzZwRmszY2xyNERVVnlGejZBLzhmbUlJdC9meUtmMnkzNUZUcGtBMElj?=
 =?utf-8?B?cUtLVllFRGRlcVVhVFd0NU52UTN0TTFES1lEL2xOVlE2UW53MXJ2K2JSYXEw?=
 =?utf-8?B?Uzdqc1MwSDR1WktudVQxZCtKZkhtbnRsVnAvQUEvRHZxcUwvaHRlOEhXdHQ3?=
 =?utf-8?B?VnR2Wnl3SE04M2gwTVo2dTBwUHdCVjNhWXpuOXdEcFN6RGNGUVdvcXJtbGxJ?=
 =?utf-8?B?b3lrQ0l2Z0tQbzR6c05RWEdWeDFMZ281RUpJK3BkcWZYTnN5empPM0JNc0s4?=
 =?utf-8?B?c3NwUWg1czByN2xUWVRXaS8wR2dMcU5iU3QvSkZETmovZlZVSjZGeXpMWG94?=
 =?utf-8?B?bmNmVVg1dUNKRDcvSklXK3QwZkkrVHRoRnhiTnZRN3dNWlBYU285cUJPZkQ5?=
 =?utf-8?B?TEswRy9lN09Xc05qc0prajhEOVBpaXhhcmxTdWZncVBSVGxmdGU1NThXMkEz?=
 =?utf-8?B?WklVSEJDYVZYeGhXUkN0NDFsdTdTaHV2STR1QUp1Mm02SnVISFJOckh6bDY2?=
 =?utf-8?B?K2pMMzBKR05KODFCdmEvcysrdGdyY1RUZVpHSVhVSkpMZVhtc3JMRFpjTnV4?=
 =?utf-8?B?UDl0bEZwNUlrYW0xYndyUXFGTGx2QjdlQWtGVWZOa1kzS2ZFM0FySnZ5aDBU?=
 =?utf-8?B?N3JHTFpBajNEbmhFRm1QcEhubkJhaDl4R3NNamVkY1N1elJLMlFhYWVhTVg3?=
 =?utf-8?B?Qi96ZHE2YWxGWHJ5VUlJUk0zSGg2NGkzVUFZbGNsVk12QkE0YUhaTm9kb3Zz?=
 =?utf-8?B?R3VtUnI2eE1QS3VzUlppZERNV0xGSXJ3eE5UVHlwem85SmNJa0Nwc1VLY3hi?=
 =?utf-8?B?cnNWbXU3dnM1S3FRUm0xRkU0VGhpMHhnMHUwMDdicVRpRU9WTWE5Wnh0V08z?=
 =?utf-8?B?N09yZ0I0eEF2QXNWQWZYMUpRNHdDMitTSS82czNIMk9UbXN1TndEenJad2VW?=
 =?utf-8?B?dTl0bFk4aHE4b2ZKejIrZTBXRWFueUdCTFluYWlZNjRJUVplalJDdWovcWdo?=
 =?utf-8?B?dy9mTGRLNzU5YUswdTRKZVozVWVCR2k2bExIeWJteHFwdWxZWTVjN3ZKbXRj?=
 =?utf-8?B?b1VBbzZaZGhPUjBkNWhoL2M5MmF3dFArRDVtMGRsOWtYVzEzOXV2VWZkckRm?=
 =?utf-8?B?WlVWYVNSRVhDUHdhZmUwMWRldStGOWxxVXcxek11dnY5MmhCKzNqSi9CeTAr?=
 =?utf-8?B?L2JGTm1NSmFma0pzU1JrRUNyMGJIYkdTWTFHZ1g0TVozcFdPU3dwbjliOEww?=
 =?utf-8?B?cUpna1BaWmtQTnpaZnk0bUU1L2p3U1VhMithenJROW9mWnFqUUVHMk84aVpn?=
 =?utf-8?B?N3FtcXFTTHpBZVd2TzRkR1RqME9ad2ZYWkRDMCtlb2xORjZKZGJIQmZIQXRo?=
 =?utf-8?B?VkNLUm40MWJWRFpBZUJEM1hhQlJseXdWVnJ5aXc5MUdxQUNDeWxpM3ZueitJ?=
 =?utf-8?Q?gls5FyeRQVo0bFrhGggD2VWxSawlC3xZSCQqxq/luQ5h?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6d6da0-766f-429c-5482-08db708e6219
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 06:28:23.8489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RgQW/rINvl7yh2e8A0D4gnN+hWOWb7b7QuUCVZGJD78exN5+sL8PPwn5qo7vAmEkEo4W1cD0nPUrLE1bxFHBhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10071
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 19.06.23 г. 0:17 ч., Thomas Gleixner wrote:
> On Fri, Jun 16 2023 at 15:57, Nikolay Borisov wrote:
>> Another major aspect of supporting running of 32bit processes is the
>> ability to access 32bit syscalls. Such syscalls are invoked either by
>> using the legacy int 0x80 call gate interface or via the newer sysenter
>> instruction.
>>
>> Ensure that if ia32 emulation is disabled (either at compile time or
>> runtime) then those 2 syscall mechanisms are also disabled.
> 
> AFAICT there are _three_ mechanisms for 32bit syscalls, no?

int 0x80 and sysenter make it 2? Which one is the 3rd one - the "native 
64bit syscall" used in for X32 ABI ? This patch specifically deals with 
the first 2?
> 
>>   void __init idt_setup_traps(void)
>>   {
>>   	idt_setup_from_table(idt_table, def_idts, ARRAY_SIZE(def_idts), true);
>> +
>> +	if (ia32_enabled()) {
>> +		idt_setup_from_table(idt_table, ia32_idt, ARRAY_SIZE(ia32_idt),
>> +				     true);
> 
> Just let it stick out. The 80 character limit is history.
> 
> Thanks,
> 
>          tglx