Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 08:45:22 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>, hexingwei001@208suo.com,
        pmladek@suse.com, senozhatsky@chromium.org,
        linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk
Subject: Re: [PATCH] lib/test_printf.c: space required after that ','
Message-ID: <ZI/5guHaSPrld+Cv@duo.ucw.cz>
References: <20230614082523.63191-1-panzhiai@cdjrlc.com>
 <f2d8eb955890bc1db1b307db713d4a4a@208suo.com>
 <ZImzXhc7ZRbSvz7/@smile.fi.intel.com>
 <20230614110640.57817123@gandalf.local.home>
 <ZInZ1BcHHQbok+wg@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="0iEVJC1jAlTlG2fb"
Content-Disposition: inline
In-Reply-To: <ZInZ1BcHHQbok+wg@smile.fi.intel.com>
Precedence: bulk


--0iEVJC1jAlTlG2fb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed 2023-06-14 18:16:36, Andy Shevchenko wrote:
> On Wed, Jun 14, 2023 at 11:06:40AM -0400, Steven Rostedt wrote:
> > On Wed, 14 Jun 2023 15:32:30 +0300
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@208suo.com wro=
te:
> > > > Add missing spaces to clear checkpatch errors:
> > > >=20
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:Vx=
V).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:Vx=
V).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:Vx=
V).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:Vx=
V).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:Vx=
V).
> > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:Vx=
V). =20
> > >=20
> > > Doesn't make any difference to the code, so let do this (unneeded) ch=
urn
> > > to calm checkpatch down.
> > >=20
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >=20
> > checkpatch is for patches (new code) and should not be run on existing =
code.
>=20
> Why does it have -f option? What do you propose to prevent people from us=
ing it?

Brain needs to be used while using checkpatch.

Plus, autosel is "great" trying to backport anything that mentions
"error", so better don't do this.

Best regards,
							Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--0iEVJC1jAlTlG2fb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZI/5ggAKCRAw5/Bqldv6
8vyBAJ4ocqcNDFBf1QDD2WsMcdssX//vvwCgl8k8r9e/JkrXobnf6/zpRDaWFgA=
=xu7X
-----END PGP SIGNATURE-----

--0iEVJC1jAlTlG2fb--