Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp6020020rwd; Mon, 19 Jun 2023 00:44:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7YReeXqUPUpWt5SCydCDxtIqG2LH+Q3+7kPletya/LIJJcAZQf/BTATcGXjskl2RI34cXY X-Received: by 2002:a05:6830:1611:b0:6af:991d:126b with SMTP id g17-20020a056830161100b006af991d126bmr6996282otr.22.1687160661110; Mon, 19 Jun 2023 00:44:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687160661; cv=none; d=google.com; s=arc-20160816; b=JyG08kxQUgZ88/N3g7yNZP8B/seiLcUcZpCOHaAR1/bL3QWZ9/ychVVgCFwm4DchRb iGUjCvLAHXVg75xpJjHS2vAbt5mgKG3v6S15CqkfjQbZhvaUy5HtzhTkaSKStowMHnFu cqwJmkl13CGjOfHWdG5fB17rWhi/iCvbD6W/O+i66VMY/BuUxs3O2YNpZ4OWrJ67EFNG J9wbgeivCiItOxqkWLu6TGFLNoR4YKIoJsJ1fZKxHSKzFCmcU00PGpgySaIUFr2QeMxN 9Rfour/HQcFFC1WP7IHQT2Fwr9F3ZUjKLyFUaDqjKcaBDEvomIVSLOjkLRhp+17h0qXO ZuYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id; bh=GEVksDjljKXDlGxDWtItuy7YmIlAjGPmijKiuOZhD40=; b=s1rgObJOukHmhtuqC+40npnnCLvrtSJ58YI6DIVEzTuYfWJXyHFtA5BNgabF2F+Okh hTwNA2qUejrXL4JQobkBYLNotqpJ9OChT/CwmUmB/fjKXPtCs3ILH0rUFUHigJeBNQ+s Ol3rC0DiLWh0X+49OZz2r6aIf6y8JjsFo6JiMcLvhn+lnEj99nZFmlkqyW79Gaqcaz/I EeYx8Kpn5Azhf1dwppM3ckMFFWfUM+Nmzh833rQvvSulu12dnBMXvw1ZHje/NUOc1L3O FPMx/3aHYC5bxzf3G+UjG445Dwmrruvd7P3exL3dVa8NB1QpZmX8amj7isyMN/L3aIXK dFkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 20-20020a631854000000b0053fc290934dsi19607897pgy.361.2023.06.19.00.44.04; Mon, 19 Jun 2023 00:44:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229482AbjFSH2K (ORCPT + 99 others); Mon, 19 Jun 2023 03:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbjFSH2G (ORCPT ); Mon, 19 Jun 2023 03:28:06 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B8C1121; Mon, 19 Jun 2023 00:27:49 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 0400624E28B; Mon, 19 Jun 2023 15:27:46 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 19 Jun 2023 15:27:45 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 19 Jun 2023 15:27:45 +0800 Message-ID: <8dba5075-3e30-3edd-e66b-199cffefe708@starfivetech.com> Date: Mon, 19 Jun 2023 15:27:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/3] dt-bindings: qspi: cdns,qspi-nor: Add clocks for StarFive JH7110 SoC To: Krzysztof Kozlowski , , , , CC: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Ziv Xu References: <20230602084925.215411-1-william.qiu@starfivetech.com> <20230602084925.215411-2-william.qiu@starfivetech.com> Content-Language: en-US From: William Qiu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/6 20:43, Krzysztof Kozlowski wrote: > On 02/06/2023 10:49, William Qiu wrote: >> The QSPI controller needs three clock items to work properly on StarFive >> JH7110 SoC, so there is need to change the maxItems's value to 3. Other >> platforms do not have this constraint. >> >> Signed-off-by: William Qiu >> Reviewed-by: Hal Feng > > > >> >> @@ -69,9 +81,6 @@ properties: >> interrupts: >> maxItems: 1 >> >> - clocks: >> - maxItems: 1 > > Properties should be defined in top-level properties. Don't remove them > from here. > > Best regards, > Krzysztof > Hi Krzysztof, Sorry for the late reply. I'll fix it in next version. Best regards, William