Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 09:32:12 +0200
From:   Joel Granados <j.granados@samsung.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <linux-kselftest@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/8] Remove child from struct ctl_table
Message-ID: <20230619073212.cwx7qvytrhiyyq74@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="25fuaebjjqwa3iru"
Content-Disposition: inline
In-Reply-To: <ZI7Pbw5WcJDDISYI@bombadil.infradead.org>
CMS-TYPE: 201P
References: <CGME20230616085926eucas1p10709e25a4c0246ed2b22da602f919b4e@eucas1p1.samsung.com>
        <20230616085922.3066990-1-j.granados@samsung.com>
        <ZI7Pbw5WcJDDISYI@bombadil.infradead.org>
Precedence: bulk

--25fuaebjjqwa3iru
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 18, 2023 at 02:33:35AM -0700, Luis Chamberlain wrote:
> On Fri, Jun 16, 2023 at 10:59:14AM +0200, Joel Granados wrote:
> > This is part of the effort to remove the empty element of the ctl_table
> > structures (used to calculate size) and replace it with an ARRAY_SIZE c=
all. By
> > replacing the child element in struct ctl_table with a flags element we=
 make
> > sure that there are no forward recursions on child nodes and therefore =
set
> > ourselves up for just using an ARRAY_SIZE. We also added some self test=
s to
> > make sure that we do not break anything.
> >=20
> > Patchset is separated in 4: parport fixes, selftests fixes, selftests a=
dditions and
> > replacement of child element. Tested everything with sysctl self tests =
and everything
> > seems "ok".
> >=20
> > 1. parport fixes: This is related to my previous series and it plugs a =
sysct
> >    table leak in the parport driver. @mcgrof: I'm just leaving this her=
e so we
> >    don't have to retest the parport stuff
> >=20
> > 2. Selftests fixes: Remove the prefixed zeros when passing a awk field =
to the
> >    awk print command because it was causing $0009 to be interpreted as =
$0.
> >    Replaced continue with return in sysctl.sh(test_case) so the test ac=
tually
> >    gets skipped. The skip decision is now in sysctl.sh(skip_test).
> >=20
> > 3. Selftest additions: New test to confirm that unregister actually rem=
oves
> >    targets. New test to confirm that permanently empty targets are inde=
ed
> >    created and that no other targets can be created "on top".
> >=20
> > 4. Replaced the child pointer in struct ctl_table with an enum which is=
 used to
> >    differentiate between permanently empty targets and non-empty ones.
> >=20
> > V2: Replaced the u8 flag with an enumeration.
>=20
> Thanks, I dropped the old patches and applied this new set. Pushed out
> to sysctl-next.
Awesome! thx.
>=20
>   Luis

--=20

Joel Granados

--25fuaebjjqwa3iru
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmSQBHwACgkQupfNUreW
QU9JFwwAhczAs8To972VFYR8Y1vQt5VoRblkCfKn7tBW2MM0acT3X2Uvjmnbt7qM
/cZXilAewh/4Ds4URg50s74+7+J8rXMyDkORSem6nu5hDZip95e9JbhLQTHLLG5T
Tx9/w9O6rIJq+FOJOYjb9Ei5TUUop86fQjRgkJLS6uqMOkh1f2Mm5Zw6TYM6U7Bs
YhBLkLbOD/vuast69lW+iLSYh6OOFeVaCJ1Ppl7/WH3CK4jpDrOO7wdcZTpC9kuA
DCjoTqIsEY11ZrExZkkQSW/igMr75fGkpHMO+EFew4QVIRdv37zn/c5n0uQCXMZs
L7THfQ3jw4IeAhqMqOR7GlFV38YzqunCW7ZtTLwGYpD1rX+hl201n6VT6keZFUNb
8v3vCW14Ey0F+adVX7PQ30ABn9oBmiXOSVY+GctZWVPC9lv/aC2fFhqpglYggjcl
Fsu1E/hnn/aPFtq7tO926pX4skYfmAj0kqbNQMhhgwbBxWX2hLeX8JSrTGWBc7xi
vj5Tfm0p
=YPb0
-----END PGP SIGNATURE-----

--25fuaebjjqwa3iru--