Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b938709c-fc80-4801-e70f-5ee70a1ae1bd@linux.ibm.com>
Date:   Mon, 19 Jun 2023 09:58:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] perf test: fix failing test cases on linux-next for s390
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        irogers@google.com, sumanthk@linux.ibm.com, hca@linux.ibm.com,
        svens@linux.ibm.com, gor@linux.ibm.com
References: <20230616081437.1932003-1-tmricht@linux.ibm.com>
 <ZIxf7A1jPiDUUdDt@kernel.org>
Content-Language: en-US
From:   Thomas Richter <tmricht@linux.ibm.com>
Organization: IBM
In-Reply-To: <ZIxf7A1jPiDUUdDt@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/16/23 15:13, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 16, 2023 at 10:14:37AM +0200, Thomas Richter escreveu:
>> In linux-next tree the many test cases fail on s390x when running the
>> perf test suite, sometime the perf tool dumps core.
>>
>> Output before:
>>   6.1: Test event parsing                               : FAILED!
>>  10.3: Parsing of PMU event table metrics               : FAILED!
>>  10.4: Parsing of PMU event table metrics with fake PMUs: FAILED!
>>  17: Setup struct perf_event_attr                       : FAILED!
>>  24: Number of exit events of a simple workload         : FAILED!
>>  26: Object code reading                                : FAILED!
>>  28: Use a dummy software event to keep tracking        : FAILED!
>>  35: Track with sched_switch                            : FAILED!
>>  42.3: BPF prologue generation                          : FAILED!
>>  66: Parse and process metrics                          : FAILED!
>>  68: Event expansion for cgroups                        : FAILED!
>>  69.2: Perf time to TSC                                 : FAILED!
>>  74: build id cache operations                          : FAILED!
>>  86: Zstd perf.data compression/decompression           : FAILED!
>>  87: perf record tests                                  : FAILED!
>> 106: Test java symbol                                   : FAILED!
>>
>> The reason for all these failure is a missing PMU. On s390x
>> the PMU is named cpum_cf which is not detected as core PMU.
>> A similar patch was added before, see
>> commit 9bacbced0e32 ("perf list: Add s390 support for detailed PMU event description")
>> which got lost during the recent reworks. Add it again.
>>
>> Output after:
>>  10.2: PMU event map aliases                            : FAILED!
>>  42.3: BPF prologue generation                          : FAILED!
>>
>> Most test cases now work and there is not core dump anymore.
> 
> So you're not fixing 'perf test', that is just what detects the problem,
> the part being fixed is the PMU code, so I'm rewriting the patch subject
> to:
> 
> [PATCH] perf pmu: Fix core PMU detection on s/390
> 
> Have you bisected the problem to the first patch where this problem
> appears?
> 
> - Arnaldo

Thanks for picking this patch, I noticed it is already in linux-next tree.

No I did not do the bisect. That first patch info came from Ian Rogers.

>  
>> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
>> Cc: Ian Rogers <irogers@google.com>
>> ---
>>  tools/perf/util/pmu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
>> index fe64ad292d36..6142e4710a2f 100644
>> --- a/tools/perf/util/pmu.c
>> +++ b/tools/perf/util/pmu.c
>> @@ -1419,7 +1419,7 @@ void perf_pmu__del_formats(struct list_head *formats)
>>  
>>  bool is_pmu_core(const char *name)
>>  {
>> -	return !strcmp(name, "cpu") || is_sysfs_pmu_core(name);
>> +	return !strcmp(name, "cpu") || !strcmp(name, "cpum_cf") || is_sysfs_pmu_core(name);
>>  }
>>  
>>  bool perf_pmu__supports_legacy_cache(const struct perf_pmu *pmu)
>> -- 
>> 2.39.2
>>
> 

-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294