Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230613102905.2808371-1-usama.anjum@collabora.com>
 <20230613102905.2808371-3-usama.anjum@collabora.com> <CABb0KFHWnbrf2ythvO0OKsd1ZS9b4D9BNzwBCbn6g9OX4n6ZOg@mail.gmail.com>
 <0db01d90-09d6-08a4-bbb8-70670d3baa94@collabora.com> <CABb0KFEn5TU480A=YiN82nLRtGyKMABi8cZjuiGUU_jFZZo+8g@mail.gmail.com>
 <34203acf-7270-7ade-a60e-ae0f729dcf70@collabora.com> <CABb0KFFaXgJD99pWfx3MC+qrq5jUaPis_kZo6U8yL_8xdp0GJA@mail.gmail.com>
 <96b7cc00-d213-ad7d-1b48-b27f75b04d22@collabora.com> <CABb0KFEy_mRaT86TEOQ-BoTe_XOVw3Kp5VdzOfEEaiZJuT754g@mail.gmail.com>
 <39bc8212-9ee8-dbc1-d468-f6be438b683b@collabora.com> <CABb0KFHx2hV9M7oinCdKnagRmcrGHagH9eAO3TkVTQH+o9x=5A@mail.gmail.com>
 <2e1b80f1-0385-0674-ae5f-9703a6ef975d@collabora.com>
In-Reply-To: <2e1b80f1-0385-0674-ae5f-9703a6ef975d@collabora.com>
From:   =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <emmir@google.com>
Date:   Mon, 19 Jun 2023 10:16:01 +0200
Message-ID: <CABb0KFGOx69Sz6w9JenYUwSTFmW-Cmcns3X-oDyWsC+H57vkvg@mail.gmail.com>
Subject: Re: [PATCH v18 2/5] fs/proc/task_mmu: Implement IOCTL to get and
 optionally clear info about PTEs
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc:     Peter Xu <peterx@redhat.com>, David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrei Vagin <avagin@gmail.com>,
        Danylo Mocherniuk <mdanylo@google.com>,
        Paul Gofman <pgofman@codeweavers.com>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        Mike Rapoport <rppt@kernel.org>, Nadav Amit <namit@vmware.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Shuah Khan <shuah@kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        Yang Shi <shy828301@gmail.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Liam R . Howlett" <Liam.Howlett@oracle.com>,
        Yun Zhou <yun.zhou@windriver.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Alex Sierra <alex.sierra@amd.com>,
        Matthew Wilcox <willy@infradead.org>,
        Pasha Tatashin <pasha.tatashin@soleen.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        Greg KH <gregkh@linuxfoundation.org>, kernel@collabora.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 16 Jun 2023 at 08:57, Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> On 6/16/23 1:07=E2=80=AFAM, Micha=C5=82 Miros=C5=82aw wrote:
> > On Thu, 15 Jun 2023 at 17:11, Muhammad Usama Anjum
> > <usama.anjum@collabora.com> wrote:
> >> On 6/15/23 7:52=E2=80=AFPM, Micha=C5=82 Miros=C5=82aw wrote:
> >>> On Thu, 15 Jun 2023 at 15:58, Muhammad Usama Anjum
> >>> <usama.anjum@collabora.com> wrote:
> >>>> I'll send next revision now.
> >>>> On 6/14/23 11:00=E2=80=AFPM, Micha=C5=82 Miros=C5=82aw wrote:
> >>>>> (A quick reply to answer open questions in case they help the next =
version.)
[...]
> >>>>> I guess this will be reworked anyway, but I'd prefer this didn't ne=
ed
> >>>>> custom errors etc. If we agree to decoupling the selection and GET
> >>>>> output, it could be:
> >>>>>
> >>>>> bool is_interesting_page(p, flags); // this one does the
> >>>>> required/anyof/excluded match
> >>>>> size_t output_range(p, start, len, flags); // this one fills the
> >>>>> output vector and returns how many pages were fit
> >>>>>
> >>>>> In this setup, `is_interesting_page() && (n_out =3D output_range())=
 <
> >>>>> n_pages` means this is the final range, no more will fit. And if
> >>>>> `n_out =3D=3D 0` then no pages fit and no WP is needed (no other sp=
ecial
> >>>>> cases).
> >>>> Right now, pagemap_scan_output() performs the work of both of these =
two
> >>>> functions. The part can be broken into is_interesting_pages() and we=
 can
> >>>> leave the remaining part as it is.
> >>>>
> >>>> Saying that n_out < n_pages tells us the buffer is full covers one c=
ase.
> >>>> But there is case of maximum pages have been found and walk needs to=
 be
> >>>> aborted.
> >>>
> >>> This case is exactly what `n_out < n_pages` will cover (if scan_outpu=
t
> >>> uses max_pages properly to limit n_out).
> >>> Isn't it that when the buffer is full we want to abort the scan alway=
s
> >>> (with WP if `n_out > 0`)?
> >> Wouldn't it be duplication of condition if buffer is full inside
> >> pagemap_scan_output() and just outside it. Inside pagemap_scan_output(=
) we
> >> check if we have space before putting data inside it. I'm using this s=
ame
> >> condition to indicate that buffer is full.
> >
> > I'm not sure what do you mean? The buffer-full conditions would be
> > checked in ..scan_output() and communicated to the caller by returning
> > N less than `n_pages` passed in. This is exactly how e.g. read()
> > works: if you get less than requested you've hit the end of the file.
> > If the file happens to have size that is equal to the provided buffer
> > length, the next read() will return 0.
> Right now we have:
>
> pagemap_scan_output():
>         if (p->vec_buf_index >=3D p->vec_buf_len)
>                 return PM_SCAN_BUFFER_FULL;
>         if (p->found_pages =3D=3D p->max_pages)
>                 return PM_SCAN_FOUND_MAX_PAGES;

Why do you need to differentiate between those cases?

> pagemap_scan_pmd_entry():
>         ret =3D pagemap_scan_output(bitmap, p, start, n_pages);
>         if (ret >=3D 0) // success
>                 make_UFFD_WP and flush
>         else
>                 buffer_error
>
> You are asking me to do:
>
> pagemap_scan_output():
>         if (p->vec_buf_index >=3D p->vec_buf_len)
>                 return 0;

>         if (p->found_pages =3D=3D p->max_pages)
>                 return PM_SCAN_FOUND_MAX_PAGES;

This should be instead:

n_pages =3D min(p->max_pags - p_found_pages, n_pages)
...
return n_pages;

> pagemap_scan_pmd_entry():
>         ret =3D pagemap_scan_output(bitmap, p, start, n_pages);
>         if (ret > 0) // success
>                 make_UFFD_WP and flush
>         else if (ret =3D=3D 0) // buffer full
>                 return PM_SCAN_BUFFER_FULL;
>         else //other errors
>                 buffer_error

And this would be:

if (ret > 0 && WP)
   WP + flush

if (ret < n_pages)
   return -ENOSPC;

> So you are asking me to go from consie code to write more lines of code. =
I
> would write more lines without any issue if it improves readability and
> logical sense. But I don't see here any benefit.

Please see the clarifications above.

Best Regards
Micha=C5=82 Miros=C5=82aw