Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp6066256rwd; Mon, 19 Jun 2023 01:37:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jsuwsPHP2lt4Xox0W6xWZvOYh+V6+tjBeMAW5HnY/uU2d5T1mh14VPyOC3a2kKeq28F0k X-Received: by 2002:a05:6a21:7886:b0:10f:1f0:9b43 with SMTP id bf6-20020a056a21788600b0010f01f09b43mr13357001pzc.6.1687163826388; Mon, 19 Jun 2023 01:37:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687163826; cv=none; d=google.com; s=arc-20160816; b=ZXMKe2rYXv9Zqq8yuHeCqAsC31I0tP7WDkFv6GQJcGThZYo3TaBtl7W4VkrX1SQ4dt UWiifxGwr8siAI3Ss/E4Hfr1nkkYfiLR874Z+bP23ArydhbTtT3NqDcp5iqgOQFjo7iI FtxqnJemdV6ojz5q4ItqbJG1CN9In40+DIPkmEYQTRFMdT74MfONsedQ2IjgOHAIEAjc Zd72q3H5gHUVP6zP+V8Tr+ZIz8pXW1JdlS1bfN1HGPC3LpxFTeXU5OxtpS1LT911Whem 2E2WPJnISWHLqW8i1IFGCtxd/LRaqiwUGWXjfTR0ce8sLw4JD8H87rp4f98nVegsIHAF RGnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=a98lfGgZ0YILLRSgLh4Z3tH6puPLRHDCS1ubXNMeXoY=; b=nauN/4a5Oy0VRhX+ppTbyOYJoIINh3d9CO1CaZq6ZpC3z04kJ/winBopzS7kpa6aUh uz8YMR8Ol+Ud+Uzk3EZjs6h4RFXW2Toy3vgD8ksE3fbHgC3Rjktj++1BgZBY10eieRhd Orhmv1MNNholK0/7Hk36w56IfkKrUCL+L/RS/WwF5PxqrAIVsDovCpbM1whyohyd3Rhm LfytBG3Gv63hEITq9FikBU+KL3NR25eK3KsWi90nw4fN0hJdxoCfIl33kCA0z28fcois 0LTHIY3W5AANFnKFwFJT8kainGiNZCmk2Qvs+Ydo0t84Dom3IC5jcdNQo+DztSLG9GKK kvsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tFliDPQH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k3-20020a170902c40300b001b53c41c138si5796778plk.26.2023.06.19.01.36.54; Mon, 19 Jun 2023 01:37:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tFliDPQH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230477AbjFSIfz (ORCPT + 99 others); Mon, 19 Jun 2023 04:35:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231124AbjFSIeR (ORCPT ); Mon, 19 Jun 2023 04:34:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF4011990 for ; Mon, 19 Jun 2023 01:33:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4B40615D2 for ; Mon, 19 Jun 2023 08:33:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77257C433C9; Mon, 19 Jun 2023 08:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687163617; bh=vCiGNFmway1xT8+5HeboDaHKKj7jfcsjDO8MygM7DHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tFliDPQHKPU78L2i5PEnlMjzcJKnjOQlcKipokhnjTQQAC+aJvUC7uCtSL8Zejm9g Tpo8yPkXesBzFBF5sY4s+Dz+HFEiok2UrEn0iaiFCM9BgP+/19Df392U+TR7vpqOSV yuYlGEi0QApa3PFhap3tkD8XbsTMkQACvezjHf135y3CQxlLrWg8dztxV3TdSs9fw8 vMCQ8HE0reQPpM1XRv8itZkFoPjpAyiwLjMh5Fx78a3H6+3y6PdXPMgmAB81/EtUt1 sP9WyXpMtwGSqf5pSZv6vuG+JCZ/JX28SXEcIpySO2GlI+GkfzTk8GjOCRpz9yJWhr 1LYVLvn9cdxGQ== Date: Mon, 19 Jun 2023 09:33:33 +0100 From: Lee Jones To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: rsmu: turn rsmu-{core,i2c,spi} into single-object modules Message-ID: <20230619083333.GQ3635807@google.com> References: <20230604042557.900590-1-masahiroy@kernel.org> <20230604042557.900590-2-masahiroy@kernel.org> <20230615140010.GE3635807@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Jun 2023, Masahiro Yamada wrote: > On Thu, Jun 15, 2023 at 11:00 PM Lee Jones wrote: > > > > On Sun, 04 Jun 2023, Masahiro Yamada wrote: > > > > > With the previous fix, these modules are built from a single C file. > > > > > > Rename the source files so they match the module names. > > > > Should this be part of the previous patch? > > > I do not know. It is up to the maintainer's preference (you). > > If you want me to send a squashed patch, I will be > happy to do so. I think it makes sense in this case. -- Lee Jones [李琼斯]