Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac326ebe-4d99-e73d-27bf-c21b532f3c4b@ideasonboard.com>
Date:   Mon, 19 Jun 2023 11:31:59 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v9 0/2] Add DSS support for AM625 SoC
To:     Aradhya Bhatia <a-bhatia1@ti.com>, Jyri Sarha <jyri.sarha@iki.fi>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
Cc:     DRI Development List <dri-devel@lists.freedesktop.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        Linux Kernel List <linux-kernel@vger.kernel.org>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rahul T R <r-ravikumar@ti.com>,
        Devarsh Thakkar <devarsht@ti.com>,
        Jayesh Choudhary <j-choudhary@ti.com>
References: <20230616150900.6617-1-a-bhatia1@ti.com>
Content-Language: en-US
From:   Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
In-Reply-To: <20230616150900.6617-1-a-bhatia1@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/06/2023 18:08, Aradhya Bhatia wrote:
> This patch series adds a new compatible for the Display SubSystem (DSS)
> controller on TI's AM625 SoC. It further adds the required support for
> the same in the tidss driver.
> 
> The AM625-DSS is a newer version of the DSS from the AM65X version with
> the major change being the addition of another OLDI TX. With the help of
> 2 OLDI TXes, the AM625 DSS can support dual-linked OLDI displays with a
> resolution of up-to 2K or WUXGA (1920x1200@60fps) at half the OLDI clock
> frequency or even cloned video outputs on each of the TXes.
> 
> This patch series acts as a continuation of the patches posted in v3[1].
> The OLDI support patches combined from v5 onwards are now separated
> again. The OLDI support will be added subsequently with a separte patch
> series.
> 
> I have tested these patches on AM625 SK-EVM and AM625 based Beagle Play.
> To test this series on AM625 based platforms, basic display support
> patches (for driver + devicetree) can be found in the
> "next_am62-base_support-V2" branch on my github fork[2].

Looks good to me. I'll pick these up to drm-misc.

  Tomi

> 
> [1]: V3: https://patchwork.freedesktop.org/series/105373/
> [2]: https://github.com/aradhya07/linux-ab/tree/next_am62-base_support-V2
> 
> Previous versions:
> - V8: https://patchwork.freedesktop.org/series/119088/
> - V7: https://patchwork.freedesktop.org/series/113328/
> - V6: https://patchwork.freedesktop.org/series/111106/
> - V5: https://patchwork.freedesktop.org/series/109194/
> 
> Changelog:
> V9:
>    - Edit the commit message for Patch 2/2.
>    - Add Krzysztof Kozlowski's and Tomi Valkeinen's tags.
> 
> V8:
>    - Rebase for current merge window.
>    - Drop all the OLDI support patches.
>    - Update the binding to remove the 2nd OLDI port instances.
>    - Drop the Reviewed-by tags of Krzysztof Kozlowski and Rahul T R
>      because of the changes.
> 
> V7:
>    - Rebase to current linux-next.
>    - Address Tomi Valkeinen's comments.
>      1. Separate the DSS VP and output port coupling.
>         v6 introduced 'output_port_bus_type' in addition to 'vp_bus_type'
>         but having both of the variables was redundant. Hence, in v7
>         the 'output_port_bus_type' essentially replaces 'vp_bus_type'.
>      2. Break Patch v6 2/5 into 2 separate patches (v7 1/6 and v7 3/6).
>      3. Change in name and addition of OLDI mode macros.
>      4. Other minor changes.
> 
> V6:
>    - Rebase for current merge window.
>    - Add 'allOf:' condition in the DT binding.
>    - Address Tomi Valkeinen's comments.
>      1. Combine DT binding patches for new compatible and 3rd DSS port.
>      2. Further separate DSS VPs and output ports.
>      3. Separate OLDI mode discovery logic from the panel/bridge
>         discovery (which allowed support for OLDI bridges as well.)
>      4. Organize OLDI IO control register macros platform wise.
> 
> V5:
>    - Rebase for current merge window.
>    - Add max DT ports in DSS features.
>    - Combine the OLDI support series.
> 
> (Changes from OLDI support series v1)
>    - Address Tomi Valkeinen's comments.
>      1. Update the OLDI link detection approach.
>      2. Add port #3 for 2nd OLDI TX.
>      3. Configure 2 panel-bridges for cloned panels.
>      4. Drop the OLDI clock set patch.
>      5. Drop rgb565-to-888 patch.
> 
> V3:
>    - Change yaml enum in alphabetical order.
>    - Correct a typo.
> 
> V2:
>    - Remove redundant register array.
> 
> Aradhya Bhatia (2):
>    dt-bindings: display: ti,am65x-dss: Add am625 dss compatible
>    drm/tidss: Add support for AM625 DSS
> 
>   .../bindings/display/ti/ti,am65x-dss.yaml     | 18 ++++--
>   drivers/gpu/drm/tidss/tidss_dispc.c           | 57 ++++++++++++++++++-
>   drivers/gpu/drm/tidss/tidss_dispc.h           |  2 +
>   drivers/gpu/drm/tidss/tidss_drv.c             |  1 +
>   4 files changed, 71 insertions(+), 7 deletions(-)
>