Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa3f72a1-8f69-e3f1-96c3-5e53c612afe7@ideasonboard.com>
Date:   Mon, 19 Jun 2023 11:40:28 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v14 11/18] media: i2c: ds90ub9xx: Select GPIOLIB rather
 than OF_GPIO
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        Luca Ceresoli <luca.ceresoli@bootlin.com>,
        Matti Vaittinen <Matti.Vaittinen@fi.rohmeurope.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Peter Rosin <peda@axentia.se>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Michael Tretter <m.tretter@pengutronix.de>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        Mike Pagano <mpagano@gentoo.org>,
        =?UTF-8?Q?Krzysztof_Ha=c5=82asa?= <khalasa@piap.pl>,
        Marek Vasut <marex@denx.de>,
        Satish Nagireddy <satish.nagireddy@getcruise.com>
References: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com>
 <20230616135922.442979-12-tomi.valkeinen@ideasonboard.com>
 <ZIxu+IvTSaFW3erU@smile.fi.intel.com>
From:   Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
In-Reply-To: <ZIxu+IvTSaFW3erU@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/06/2023 17:17, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 04:59:15PM +0300, Tomi Valkeinen wrote:
>> Select GPIOLIB rather than OF_GPIO, as the drivers use gpiolib
>> functionality, but no of_gpio (directly).
> 
> This is useful change, but has to be folded in the original code.
> We do not want even a trace of newly added OF_GPIO.

Yes, I think the first three new patches should be squashed:

   media: i2c: ds90ub960: Fix use of UB960_SR_FWD_CTL1
   media: i2c: ds90ub9xx: Add COMMON_CLK kconfig dependency
   media: i2c: ds90ub9xx: Select GPIOLIB rather than OF_GPIO

The rest... Thinking about it now, I should have perhaps left them out, 
as they're not fixing issues, and perhaps they just confuse the merging 
process.

  Tomi

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>> ---
>>   drivers/media/i2c/Kconfig | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>> index 8a5f09a3de6c..29fc00e30d8b 100644
>> --- a/drivers/media/i2c/Kconfig
>> +++ b/drivers/media/i2c/Kconfig
>> @@ -1622,7 +1622,7 @@ config VIDEO_DS90UB913
>>   	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>>   	select I2C_ATR
>>   	select MEDIA_CONTROLLER
>> -	select OF_GPIO
>> +	select GPIOLIB
>>   	select REGMAP_I2C
>>   	select V4L2_FWNODE
>>   	select VIDEO_V4L2_SUBDEV_API
>> @@ -1635,7 +1635,7 @@ config VIDEO_DS90UB953
>>   	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>>   	select I2C_ATR
>>   	select MEDIA_CONTROLLER
>> -	select OF_GPIO
>> +	select GPIOLIB
>>   	select REGMAP_I2C
>>   	select V4L2_FWNODE
>>   	select VIDEO_V4L2_SUBDEV_API
>> @@ -1648,7 +1648,7 @@ config VIDEO_DS90UB960
>>   	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
>>   	select I2C_ATR
>>   	select MEDIA_CONTROLLER
>> -	select OF_GPIO
>> +	select GPIOLIB
>>   	select REGMAP_I2C
>>   	select V4L2_FWNODE
>>   	select VIDEO_V4L2_SUBDEV_API
>> -- 
>> 2.34.1
>>
>