Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71c4ef1e-0982-1ef4-5135-001303b43cd3@oracle.com>
Date:   Mon, 19 Jun 2023 10:31:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v3 2/7] perf metric: Event "Compat" value supports
 matching multiple identifiers
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Robin Murphy <robin.murphy@arm.com>
Cc:     James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1685438374-33287-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1685438374-33287-3-git-send-email-renyu.zj@linux.alibaba.com>
 <c1d8ee9b-4839-1011-4dad-c4777d8f8224@oracle.com>
 <452e724b-2a2c-52fd-274b-60db7a7f730e@linux.alibaba.com>
 <c4b2fca8-602d-9c76-90a7-3eafd92da8bc@oracle.com>
 <76fcb062-61a8-5f90-b39d-b5fb6da35652@linux.alibaba.com>
 <5f38ef6c-8c50-5df9-19dd-c3c9fe590452@oracle.com>
 <e4be7189-a1ba-7758-bff3-e7b8d8ff1419@linux.alibaba.com>
 <892f57c7-8ce2-634c-26f3-4d4ab8b2f2ce@oracle.com>
 <079d7920-2030-2e00-a833-5ec6d450f7dc@oracle.com>
 <552eebae-76bb-a2fe-ccdc-11e8a01717da@linux.alibaba.com>
 <045a49c9-b9ae-bf0e-c4be-858d905bcc55@oracle.com>
 <7c765e0f-ca76-d212-0496-f9c56369e389@linux.alibaba.com>
 <d1ab4947-6bdf-2b9c-5b26-52c572611ca6@oracle.com>
 <a6e1114c-b37c-6999-0668-039aa495db84@linux.alibaba.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <a6e1114c-b37c-6999-0668-039aa495db84@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWZDZlpvTThzL1NLckdSbzJpU3FvSzRkT0p2R0FqaXhoVWFRNUc4QjJqQzNF?=
 =?utf-8?B?MXhPalcya1hVVGFxblNjaGVqamJxeklLRzFacXJ4OVQ5MHg0UWlwbTBzSkp6?=
 =?utf-8?B?WUk4V2lrT0JIc3RxSCtQUGFVVXRzZ1Q1UUkwRUQwQXc4NHZsb1M4K21KRTZF?=
 =?utf-8?B?d2pEamR1YXprS1c1YnBSMGZiWVdicmkzdlYwSVBDajcvOGQwdlB2YnI2QXU0?=
 =?utf-8?B?Q08xVjl5TXZnaytJMG1yU3kyU0FRMXZzai9LQW1Hb0hIWXRudXowWktpcUYw?=
 =?utf-8?B?NjhjYU16K2szU25SUjBiTWxDYTM1a0RoVWVJbWNnQ0JTMXhIdWdBZ2p3NlhG?=
 =?utf-8?B?WnhsV0xvd0V1blVBekllZGFSY0ZrR0V5bGM5SEFsYXVsS0NIUGZPMzdwM0tB?=
 =?utf-8?B?Sm5FNG5WcEhBYTNjR1pzWFZ4b0trMm5JNEsrWndXTXZDUTBDZ2RxaUVIL010?=
 =?utf-8?B?WXhMZ29pb1ExbzA1bFRzRUhuUjVYc09JMDFEUXNBOEwwQWFmNmdVMVRpWTlU?=
 =?utf-8?B?SnBRNkVHV05FeVJRQmxkUDlUM1pqTHNFRlR1MWxKaFNDZU5ERk1VS0JHc2lL?=
 =?utf-8?B?UDVHVVo1MDFGQnljcjV2L3FOZVR1SG5jZmlTNkJEU1VkbWxzUzdpbVdUTU1V?=
 =?utf-8?B?S1UySk5TUzBhMG1hZUNsNVMwRWRwOUhEWlRzUzRxZE9wdnR0azFMcXhTdEk1?=
 =?utf-8?B?VWRUYWcwckFJUmpmZzlTMU04TXRYQzl4U2JtOHZSRzZjd1NKK1JTSFpsM21x?=
 =?utf-8?B?WGM2UFBwdG1MWVdtT1k1dUlPQVBKcm9zTXUraU0wSFFJVU5zd3YvQVFLc0Vu?=
 =?utf-8?B?UmFiK3oyWFdWY3YyL2svOHVVand4eHFjOHRYZDk4bUpyMVhuc28yOUM2OVNB?=
 =?utf-8?B?RjFHdGIzVXA0SWIwcFMxQ2pqQU9pV1JzS0NNNUpRcWs4bWQ2a0VUSWdxUitV?=
 =?utf-8?B?R2NLMWZ6eWpSYVFCWC9IdStNZWNaSWFwVk5qOHgva2NlcDZZTWVqdlZoZkRu?=
 =?utf-8?B?UVdSRkpCa0xQQU1kWGFkTmFiR3NOTFpqM3Fab0FZc2Y3ZEx4anNGc29VeVo1?=
 =?utf-8?B?MUZ5SWZrZCt3eG5XaFFqL3VBUCtmblhnNVZWTGcrT1pKRGVIZ09NUmYwWVk2?=
 =?utf-8?B?ckRyRVlZMEhqY1paNVRHNS9LVU5CaGVVbUNYSE4xQkU5RU5Kejl0dkYwZzY1?=
 =?utf-8?B?U0FpZk5VVXQxR3JNd3pzeFZtRWpXWjQ5S28yTDhRalJkVDduSkFKMHpDeG9X?=
 =?utf-8?B?YVdieXhscVhyYnNIRjRQYkFMY1BDOWxGT2ZJMzl5UkpPNCtHLzA1bUJ3ZHM0?=
 =?utf-8?B?ZUoyVW52bURwaUh4bmp4NUhVcWVwTEN3RnpMNHFXSy9aajhJRDNxVzdWdytj?=
 =?utf-8?B?M09vU1p3VkVPVU1odFhmQmQrUXFpVTJkZnJ4cWVkM3RmYTBUUDJqOEFzVnJV?=
 =?utf-8?B?WW4vZDVCMXN1L2xBNzVydWdGbEs3UUhUZTUxdFE0dWl6UklRcitlV0QrVXp2?=
 =?utf-8?B?azc2VnVkTTFpUTNyT0RpYU9GTFkwcTVBMCtiT0o2b3BQOFQwVDRPY3lEVTc4?=
 =?utf-8?B?d2N5VTNsbjVzdzMyVTlhNFFKN0lacDNMbk82UjJ5b1ZNYlZqYTBsbUJjWmNk?=
 =?utf-8?B?MzRoZ0tqRG43TDRhQTgwM2x1RmtlWmpFTDdLUmI3TDJPUkRCL25IcUdWMFhQ?=
 =?utf-8?B?Z1lTd1hGVG1vQzlLSDNHaFczcWVjM0crWUxoRWdmT3plL0xaS2o4NWV1NUxM?=
 =?utf-8?B?QldZM29rNGdQdlMvK2FOa2FoYWhvNmVtSjNQZW5iL3FEL3RQcU9xSVphb2F6?=
 =?utf-8?B?T2FZakIwZHNEckNCZEZ3djlCdFVDTEpWeEI3Skd6aGtCYkh5d3htRWxSMXlk?=
 =?utf-8?B?WndDZ0dEd0MybEV2aHlkL1U1d2h4dHJWbEZRaytoWXVGOSs4TFBVZGg1SEc1?=
 =?utf-8?B?KzA5UUJGU01yNXlpdFdPSlI3WVRVd2VKaGN2NHQwNGxsZ3lQait0R2FrcU15?=
 =?utf-8?B?WWlxMUVSOEY4c3RzL25HU041VmhLYUVwQzJTTnVJa1JvdGlKNFdPR1RNeThY?=
 =?utf-8?B?ckl2VGlDQW1UbVlvNU0ybFVWQXFkamNvNTM3VFBIMXNJQzNjOWs4MXFQOVZS?=
 =?utf-8?Q?MApxYxrxWGmuYBPbwwLo03vEO?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?MmZlSTZyWVFueG16TVk0Mk1VeU1kSGQyaUQrS0pmVjVjM0hqbUZTdzFRQUEw?=
 =?utf-8?B?Q3Rrd0tJOHFGYXhPRjVBRVU3YXFnVjdnc21UMElEM3hPckgrNHoxdjJsUFU0?=
 =?utf-8?B?aGxjYytPbG5GTGVmR1RGWjQ1YVVIaHV0NlFoQnRrbzl6WTFKZEcxYjIybUk5?=
 =?utf-8?B?MEVNU3Z3MkxrazFOSHFXQ29TZFhUeWdsZEw1Wkc2bzhwUmNxQ2cxZDNCM0Jw?=
 =?utf-8?B?R0NDS09YbmN6RVhqd3ZrTDNwM1lkdnBEY0hrR1ptWUpJVXdTc2JCVjVGd2Fv?=
 =?utf-8?B?QWNXVUd5TzlNZTdvNnZHV2hqd1BOcWVVT3pNMXU0YXJLUmEvaDFWdGY0ZUxl?=
 =?utf-8?B?eSttY2pRVXo4VWtZY2lyenRzZWxYUnJvWjdQYlpBNmI0bU5HTG1nZEtoNmR1?=
 =?utf-8?B?NU9obXY0NXlxbDBnVWs0Qk1tTjNlUDM1NjhsSldIdGZkOVpYZElWUGQ4SEpY?=
 =?utf-8?B?QlVEYXRkS3RhU09QZ3F2NGJhN21BMWtoQkV0eEZIblU3YU5KR3c0NmdRV2hy?=
 =?utf-8?B?UkFHM1h1OEVyZ2J2aDFVYjd1UExiUFZlSUYrS01XUkNIZlAwMVRrdWJXR1VR?=
 =?utf-8?B?ZUk5dWVoelo1cFZKQnYvMGtlNnNLc1V2Qzd3dTdndnczVkRTQnJUS3NmQjcw?=
 =?utf-8?B?VHFNQjBHNlAxVlZ2UnVlNFVrSGNpNERzV3JrWHZjcFB5YzdFdTZTdlR2STMv?=
 =?utf-8?B?QXZQMTdEK0pXaHMyV3dCWUN3L3hKQnZpTlBpUnF0NXJ1akpWb0ZmekdkQnpr?=
 =?utf-8?B?UzEzZ2Z4bkQzaHNsUHBvTjRNbDdRVllCdndxYW5ERTZ4dVZkbHFHNDhaRmZx?=
 =?utf-8?B?ZldRbmI3K2tXU0EzbkgrNzBVYmJVcU9xR0NORzFjaXZzU3RHRlUwUkpTdlFq?=
 =?utf-8?B?eTVFMXcvVDMwVTEwRjhXNVdUZVFHTm5LTFJkVTlmOFBwV0lHa2V1bTIzUnRH?=
 =?utf-8?B?enhFclJXUXJVV1Nrd3ZlMnQxdit2Rm5qNkdtc0I4WmVvWW50M0R1NHhDMk55?=
 =?utf-8?B?WERqdDR3VXJxTnNQM2FVUTRKL1c3VWVqWmxrSC9qeDlSeXA3blRJaDd4bDFG?=
 =?utf-8?B?dndLTGg2RmVWV01Dc3NNWFFlOTYwMFByRmgzQ3dkUjBEY1dhY1Y4cERJZXFY?=
 =?utf-8?B?NDI5bnNKUEJBNkQwZjZlN3lIK05nWlNud2ZoZkdqdUtiYnI1UzhVcEJ1V0Zq?=
 =?utf-8?B?d0ZaN2hZZG96K2tURE9CSzJ3RUZVdEhFTXFobitNQkRLbTB4ejIybmZsWjFT?=
 =?utf-8?B?RUdZazYrdDBjSFk3MnRZblBzeUtKQVVzUGNSUVg5V1E1L01sS2FwMUJDTjBz?=
 =?utf-8?B?RG5iS2h1b3g3bFRZK2xjTzZadURlN1U4akh1ZTZraThtYVhkem9CK0Y1dk9w?=
 =?utf-8?B?OU11bzJBSEFQMDk2KytaTmZhSCtNT0xUbmc1bm1pS2VRa0dxdGZFMkl0NENr?=
 =?utf-8?B?NWlhTlRqUmE2a0duK3JieVhCSjRoUmFLUmxCbklQSDJXY2x4V2d0QnROUWdX?=
 =?utf-8?Q?S5DsHQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef2958c7-b9ac-4294-3a96-08db70a7ef64
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 09:31:18.3392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gu1NzO/zq2/wDVkdqjUuUEj9Vb0sPWC7H7d3NUkkgolE8TCdtJcWqj3tLfT66um5zEIrK7KJFQtI0MDbA1wU9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4890
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-19_06,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306190086
X-Proofpoint-GUID: 3GwVfPQP38P9AUe3FzJ3AsfmSvpbYx6v
X-Proofpoint-ORIG-GUID: 3GwVfPQP38P9AUe3FzJ3AsfmSvpbYx6v
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19/06/2023 09:59, Jing Zhang wrote:
>> Please verify running these metrics with 'perf stat', like 'perf stat -v -M slc_miss_rate'
>>
> Ok, it shows:
> #./perf stat -v -M slc_miss_rate sleep 1
> 
> metric expr hnf_cache_miss / hnf_slc_sf_cache_access for slc_miss_rate
> found event duration_time
> found event hnf_slc_sf_cache_access

In the earlier RFC series you had 
tools/perf/pmu-events/arch/arm64/arm/cmn700/sys/cmn.json, which 
describes event hnf_slc_sf_cache_access

But that JSON is not in this series. Why is it not included?

The cmn kernel driver exposes event hnf_slc_sf_cache_access, but I did 
not think that perf tool metric code matches those events described in 
/bus/event_sourcs/devices/<PMU>/events

> found event hnf_cache_miss
> Parsing metric events '{hnf_slc_sf_cache_access/metric-id=hnf_slc_sf_cache_access/,hnf_cache_miss/metric-id=hnf_cache_miss/}:W,duration_time'
> hnf_slc_sf_cache_access -> arm_cmn_0/type=0x5,eventid=0x2/
> hnf_slc_sf_cache_access -> arm_cmn_1/type=0x5,eventid=0x2/
> hnf_cache_miss -> arm_cmn_0/type=0x5,eventid=0x1/
> hnf_cache_miss -> arm_cmn_1/type=0x5,eventid=0x1/
> Control descriptor is not initialized
> hnf_slc_sf_cache_access: 127615 1001344900 1001344900
> hnf_cache_miss: 36829 1001344900 1001344900
> hnf_slc_sf_cache_access: 131526 1001343540 1001343540
> hnf_cache_miss: 40587 1001343540 1001343540
> duration_time: 1001381687 1001381687 1001381687
> 
>   Performance counter stats for 'system wide':
> 
>             259,141      hnf_slc_sf_cache_access   #     29.9 %  slc_miss_rate
>              77,416      hnf_cache_miss
>       1,001,381,687 ns   duration_time
> 
>         1.001381687 seconds time elapsed
> 
> 
> 
> #./perf list
> ...
>   arm_cmn_0/hnf_cache_miss/                          [Kernel PMU event]
>   arm_cmn_0/hnf_slc_sf_cache_access/                 [Kernel PMU event]
> ...
>   arm_cmn_1/hnf_cache_miss/                          [Kernel PMU event]
>   arm_cmn_1/hnf_slc_sf_cache_access/                 [Kernel PMU event]
> ...
> 
>>> In the past, I always thought that the function of the alias was to explain the meaning of these events in the perf list.
>>> Or maybe I'm missing something?
>> Event aliases do give the ability to describe the event in perf list. But we can also run them for 'perf stat', like:
>>
>> ./perf list uncore
>> List of pre-defined events (to be used in -e or -M):
>>
>>    uncore_cbox_0/clockticks/                          [Kernel PMU event]
>>    uncore_cbox_1/clockticks/                          [Kernel PMU event]
>>    uncore_imc/data_reads/                             [Kernel PMU event]
>>    uncore_imc/data_writes/                            [Kernel PMU event]
>>    uncore_imc/gt_requests/                            [Kernel PMU event]
>>    uncore_imc/ia_requests/                            [Kernel PMU event]
>>    uncore_imc/io_requests/                            [Kernel PMU event]
>>
>> uncore cache:
>>    unc_cbo_cache_lookup.any_es
>>         [L3 Lookup any request that access cache and found line in E or S-state. Unit: uncore_cbox]
>> ...
>>
>> sudo ./perf stat -v -e unc_cbo_cache_lookup.any_es
>> Using CPUID GenuineIntel-6-3D-4
>> unc_cbo_cache_lookup.any_es -> uncore_cbox_0/event=0x34,umask=0x86/
>> unc_cbo_cache_lookup.any_es -> uncore_cbox_1/event=0x34,umask=0x86/
>> Control descriptor is not initialized
>> ^Cunc_cbo_cache_lookup.any_es: 14361103 1853372468 1853372468
>> unc_cbo_cache_lookup.any_es: 14322188 1853360415 1853360415
>>
>>   Performance counter stats for 'system wide':
>>
>>          14,361,103      unc_cbo_cache_lookup.any_es
>>          14,322,188      unc_cbo_cache_lookup.any_es
>>
>>         1.853388227 seconds time elapsed
>>
> Ok, thanks. If I use events without a prefix, such as perf stat -e clockticks sleep 1, will this also work?

In this case, yes - it would work for uncore_cbox_0/clockticks/ and 
uncore_cbox_1/clockticks/

But you need to be careful to here - if another PMU has same event name, 
then it might also match.

Thanks,
John