Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp6142583rwd; Mon, 19 Jun 2023 03:02:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6xbNHLLP/1uPN7RUuzqACXPfpLIXPPpcAdP5CCr9q6drxm+fqT3zT5Y2ZCT7Q1CGfJmRTt X-Received: by 2002:a17:902:f7d2:b0:1b5:450a:4b5e with SMTP id h18-20020a170902f7d200b001b5450a4b5emr318520plw.17.1687168968468; Mon, 19 Jun 2023 03:02:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687168968; cv=none; d=google.com; s=arc-20160816; b=Emu9kH2q2UCdE+BR0+smcDpFG2WcokQyfv+JTUsC4hkSEsKFPoiibaKKsB0WsROeMG HUeA4kl//InFXXNnF7TRia/GYhgVNg+7UoG2gk5RRfmKgZ05AOkVmdQYJ1Xa8RqXLyPG lK5uO3jHFEur5ysfCdjx6bclrMjR2WKT2GcJdieMM2KClDKyZsPAUgZ5Y0T4kEm+CIlC ZeoiukViKyxhoMzmT6+LvlDPT4IKtGRLaq1MZIZSrZvLXxGPRd/Gf3hv4sul+5Ny1u2B Tz0rgjqEVET82qq2vBkLXNbCr8bgFUiH9ijLgqOUO5YrbZEjQvXrclItyoySILHn133D XQhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=GZ67eYp0xidD7yf0q5E58c4Opw2pRmvbtVhqjrSnPYE=; b=xlNKve1bEeq6K0aAMWc8O154Vf6qzBN3Wqf3XsHuRbXzRkoThNJo9u9DwelS+xQnAS 4Ovgzpb2OBDuvoZNG+0LguBfT3tNcx7dUZjzrnli0tSY3sctTpfpnBoPWqb+UskB4PQZ 0vfeNHvV3vb4gfz6/B+HM2vYUfe8bB2/F7cry9wkvEnhPa0o1NEL79S27Te5Y4ZdmnH9 WFdL6ouhVx+HFV0REgJIuY3nxjHSDBW34S2+k5x2RugBpWWYLB693JLqK0gzpEa6sSKm ApH+Zjaw7lriNSlIBO6/EGIZ4ysZOrQnqPbJ/9xucF/x9kOQCPsenAzAIvmAhBjLHYDm Y18g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IAfwywvQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j18-20020a170902da9200b001b3d8ac8dadsi10919047plx.476.2023.06.19.03.02.29; Mon, 19 Jun 2023 03:02:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IAfwywvQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231182AbjFSJaz (ORCPT + 99 others); Mon, 19 Jun 2023 05:30:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231661AbjFSJ3s (ORCPT ); Mon, 19 Jun 2023 05:29:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3C6D137 for ; Mon, 19 Jun 2023 02:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687166912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GZ67eYp0xidD7yf0q5E58c4Opw2pRmvbtVhqjrSnPYE=; b=IAfwywvQRHp7kBGpoGchhALPRyM55olPNx7c53uio1gvMRnBKkvk7c564f4Z2z3Qc31Bj1 Ke+3Ya/nV4Viy9UAFzrxtWI/2okHV6nl5+WcUyx1xfTlVY7EhOOetD7JdRddLU1tv08hOp d25hEHdH2vCj40FIoaixvZzxOcTjLFE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-417-wy7vn5_rOYuWr0fZ_lhqeg-1; Mon, 19 Jun 2023 05:28:29 -0400 X-MC-Unique: wy7vn5_rOYuWr0fZ_lhqeg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 05F2180067D; Mon, 19 Jun 2023 09:28:28 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1AC6112132C; Mon, 19 Jun 2023 09:28:24 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <55e7058b-07d0-3619-3481-2d70e95875ea@grimberg.me> References: <55e7058b-07d0-3619-3481-2d70e95875ea@grimberg.me> <648f353c55ce8_33cfbc29413@willemb.c.googlers.com.notmuch> <20230617121146.716077-1-dhowells@redhat.com> <20230617121146.716077-11-dhowells@redhat.com> <755077.1687109321@warthog.procyon.org.uk> To: Sagi Grimberg Cc: dhowells@redhat.com, Willem de Bruijn , netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Keith Busch , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , linux-nvme@lists.infradead.org Subject: Re: [PATCH net-next v2 10/17] nvme: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <775803.1687166903.1@warthog.procyon.org.uk> Date: Mon, 19 Jun 2023 10:28:23 +0100 Message-ID: <775804.1687166903@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sagi Grimberg wrote: > The patch looks good to me, taking it to run some tests > (from sendpage-3-frag branch in your kernel.org tree correct?) Yep, but you'll patches 1 also and patch 2 might help with seeing what's going on. David