Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 13:41:43 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Marc Zyngier <maz@kernel.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Thierry Reding <treding@nvidia.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO
 IRQ chip
Message-ID: <ZJAw507ODTUX2elD@smile.fi.intel.com>
References: <20230616135313.76338-1-andriy.shevchenko@linux.intel.com>
 <CACRpkdbPEvVvaehB521gdjkkzh+wFnFxsCNm36PD-hnTb1Na_w@mail.gmail.com>
 <87y1kipeui.wl-maz@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87y1kipeui.wl-maz@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sat, Jun 17, 2023 at 11:23:17AM +0100, Marc Zyngier wrote:
> On Sat, 17 Jun 2023 10:08:10 +0100,
> Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:

(...)

> > > -               /* Some drivers provide custom irqdomain ops */
> > >                 gc->irq.domain = irq_domain_create_simple(fwnode,
> > >                         gc->ngpio,
> > >                         gc->irq.first,
> > > -                       gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > > +                       &gpiochip_domain_ops,
> > 
> > We better run this by Marc Zyngier, and Thierry who introduced it.
> > 
> > But some grepping and looking seems to conclude you are righ!
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> No objection from my end. If this is unused, let's kill it.

Grepping by two independent people and so far no complains from CI, I believe
the patch tells truth.

> Acked-by: Marc Zyngier <maz@kernel.org>

Thank you!

-- 
With Best Regards,
Andy Shevchenko