Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3dda6808-cda2-e587-88a7-00621b2cfca3@ideasonboard.com>
Date:   Mon, 19 Jun 2023 13:57:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v14 18/18] media: i2c: ds90ub953: Support non-sync mode
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        Luca Ceresoli <luca.ceresoli@bootlin.com>,
        Matti Vaittinen <Matti.Vaittinen@fi.rohmeurope.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Peter Rosin <peda@axentia.se>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Michael Tretter <m.tretter@pengutronix.de>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        Mike Pagano <mpagano@gentoo.org>,
        =?UTF-8?Q?Krzysztof_Ha=c5=82asa?= <khalasa@piap.pl>,
        Marek Vasut <marex@denx.de>,
        Satish Nagireddy <satish.nagireddy@getcruise.com>
References: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com>
 <20230616135922.442979-19-tomi.valkeinen@ideasonboard.com>
 <ZIx17WC7plfDPpmc@smile.fi.intel.com>
 <dc79de4e-4043-5448-db44-ef8f7749a376@ideasonboard.com>
 <ZJAyb9WHjWrdSsBw@smile.fi.intel.com>
From:   Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
In-Reply-To: <ZJAyb9WHjWrdSsBw@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 19/06/2023 13:48, Andy Shevchenko wrote:
> On Mon, Jun 19, 2023 at 12:00:57PM +0300, Tomi Valkeinen wrote:
>> On 16/06/2023 17:47, Andy Shevchenko wrote:
>>> On Fri, Jun 16, 2023 at 04:59:22PM +0300, Tomi Valkeinen wrote:
>>>> Add support for FPD-Link non-sync mode with external clock. The only
>>>> thing that needs to be added is the calculation for the clkout.
> 
> ...
> 
>>>> +	switch (priv->mode) {
>>>> +	case UB953_MODE_SYNC:
>>>> +		if (priv->hw_data->is_ub971)
>>>> +			return priv->plat_data->bc_rate * 160ull;
>>>> +		else
>>>> +			return priv->plat_data->bc_rate / 2 * 160ull;
>>>
>>> Redundant 'else'.
>>
>> True, but I like the symmetry in:
>>
>> if (foo)
>> 	return 123;
>> else
>> 	return 321;
> 
> At the same time it will be symmetry with other switch-case(s). That's why the
> question about fallthrough below.
> 
>>> Do I understand correctly you don't want to fallthrough because it will give
>>> ±160 in the rate (depending if it's even or odd)?
>>
>> Sorry, can you clarify? Fallthrough to what?
> 
> To the below case since '/ 2 * 160 ~= *80'. Why ~ because it might give
> off-by-one error due to even/odd input.

The below case is different. "priv->plat_data->bc_rate" vs 
"clk_get_rate(priv->clkin)".

As to the order of the calculation (/ 2 * 160 versus * 160 / 2), 
generally speaking, I have never figured out what are the correct ways 
to calculate clock rates.

I wrote "x / 2 * 160" as that's what the documentation gives (there's a 
hardware /2 divider in non-ub971 chips, followed by a 160 multiplier). 
But does the documentation presume that the calculation is done 
precisely, not in integers? If so, "x * 160 / 2" would be better (but 
then, do we need to round?). Or does the /2 hardware divider basically 
actually work as a an integer division, in case "x / 2 * 160" is the 
correct one.

>>>> +	case UB953_MODE_NONSYNC_EXT:
>>>> +		/* CLKIN_DIV = 1 always */
>>>> +		return clk_get_rate(priv->clkin) * 80ull;
> 

  Tomi