Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Li Dong <lidong@vivo.com>
To:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Aric Cyr <aric.cyr@amd.com>,
        Tom Rix <trix@redhat.com>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Anthony Koo <Anthony.Koo@amd.com>,
        "Leo (Hanghong) Ma" <hanghong.ma@amd.com>,
        Li Dong <lidong@vivo.com>,
        Dillon Varone <Dillon.Varone@amd.com>,
        Austin Zheng <austin.zheng@amd.com>,
        Mike Hsieh <Mike.Hsieh@amd.com>,
        amd-gfx@lists.freedesktop.org (open list:AMD DISPLAY CORE),
        dri-devel@lists.freedesktop.org (open list:DRM DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com
Subject: [PATCH] gpu: drm/amd: Fix traditional comparison using max method
Date:   Mon, 19 Jun 2023 18:54:45 +0800
Message-Id: <20230619105514.1888-1-lidong@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dHfrkXeJ+aWLt6NXHGKX10UD+ocpvbEGlpcSSBpmvskth7Saq8DPoLvlatU1?=
 =?us-ascii?Q?czuRvkLU/GNB+CFdkDB+P1SYbVr5VzILDIn3uJg7fK30cdY2yBe90lI5czrF?=
 =?us-ascii?Q?MH1f9znks8roVAdlZPsIgq5bXb0L3bZY2yCaeV1hEnjQRkxQI0MJKt51Wt0I?=
 =?us-ascii?Q?tKr4/GTVOzrFI/qKJUF9CfDLd2UJm8aWVSido5gQQzEBLEIQmRcYCEI81ygG?=
 =?us-ascii?Q?mklVoh9128rXIURRjgvUrNn8o1CTvjYnvvHwcGMZWwe6ZzK5XwU5azjYA3lg?=
 =?us-ascii?Q?oUqfWeUoakvrpnJBWMB8aTxr4EFB8xY0pwyF9I32nIHxI4dH6fB/kboCsBgX?=
 =?us-ascii?Q?9XhKYZZ50EPpLi8NYEedxtzWcZVJR33oFQGqwcou+njsKVcC0ja4OVgKiHUD?=
 =?us-ascii?Q?8/klJmrN4mjg81xIqRdqr6/tJHr+7b5Zz4rCv/1xA0BGeUxKRJo2dsfIM5xu?=
 =?us-ascii?Q?2ylIBzffbidsIU1lMBSnN2wqwxjg5jP8lymry0LJwH9fEt4ckNze1Di8u5mL?=
 =?us-ascii?Q?TBQ7xCNyNLziQWBF2or34IhrREi2DzBnmzfRG4R/ICzciL8BZsHk6a47sYLY?=
 =?us-ascii?Q?Q+Aku5xiZYC6v8DqVbrY4JYueObLjdjIUWCyf5V7hEAHTa5V1GQ/QbasPrL7?=
 =?us-ascii?Q?Q2XobAUG6RTLybuGMCSNtwVhLghqdCdC37ZmhUqNtIgBIL6Q9S35O3fp4zus?=
 =?us-ascii?Q?6bZxJWBJ/Fz/L8TYHNY3iMcSB8LN3bYRR3NLYg9g1fruVBFVC8aKhcf0Y+dQ?=
 =?us-ascii?Q?tgydx8jFR+XeU/xBBySR3yIh83Dyq79U6lD79tC9ctnf7sYiypVWhMSzTubx?=
 =?us-ascii?Q?1T0Ym6RM60NRtYkdM57he+aj3gPVmDKtqykPcYPBpN7rMOzfbXF/2OtxhG3P?=
 =?us-ascii?Q?yajav+8P+4ncOf99SAYjnv3//BQACAWhQEez50IYkZKjylEdoZrOzdtPPtw0?=
 =?us-ascii?Q?w+/Zi13SlEjyiBTYk0Y7d9hnH5jOAFvDFgaGXEkUe2YZSoJ9pZEuHJN4sCNG?=
 =?us-ascii?Q?nsKRfe0EqbaNlKAiI/FyBhwmPSkKF5bQnv+/QRC0hSngSkcsbKF+Ft8Cg3PA?=
 =?us-ascii?Q?xMsgNkpayjPTOUOPsw5hkKrCr2VpYoOn0ACVdgu34+XIt002bbyAjyJ4WzoZ?=
 =?us-ascii?Q?d/CeWd0p5gRthOkVqF69UFlxP8iEMy+7sFcSvbSI2MdwNU75hWgAsvWJXgy3?=
 =?us-ascii?Q?dQkS0yECG3HFv0VmYRVgOmzEwfSg6N9Ki84ORkmbE0xKbPzSWC8KbTDW6tY+?=
 =?us-ascii?Q?HihjPOvtiKG8sj+o3cZ3ZAEDEg42b7CPJWRK2oXcyRs2e8u/0N16LOQulnED?=
 =?us-ascii?Q?ULsk/sHbnLPuxbDWNe9RCkzZi8HuvCHRpiaFyhO+8wL0nKwyUSCAzK8eNnNk?=
 =?us-ascii?Q?Pw4P47qzp+J8PyrYViTAqSpICsLc2c/4AvcOiuOvHk9ZdfvZyuno+Njuqwhj?=
 =?us-ascii?Q?NOXU500KanPQQEpsIfqwE3j/3p4FoKEeXQWqWaYlt5KqsNV1kQVNfXZtj4PZ?=
 =?us-ascii?Q?Wres30O23FipdFae5jbsR+L1xLStDuzSPhKkFlmMqjRmtO6Ce94pcQq3JVIt?=
 =?us-ascii?Q?H3v42iM3UE55M7+3x/UfJYsU16pzlzfrj81w2upZ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 061b6f3b-f862-4025-5d1a-08db70b472f0
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5022.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 11:00:53.1894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UNhjA7SaKE19oryodqvX6Touw3yOPA8h7S+V0F8bLdmnd2Hv1KG2+EkpYDVLY5GLNBDlqFQZSQRvJiQM/FUnmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6566
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It would be better to replace the traditional ternary conditional operator with max()

Signed-off-by: Li Dong <lidong@vivo.com>
---
 drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
index dbd60811f95d..a5eabde53fa4 100644
--- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
+++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
@@ -1005,8 +1005,7 @@ void mod_freesync_build_vrr_params(struct mod_freesync *mod_freesync,
 			(stream->timing.h_total * stream->ctx->dc->caps.max_v_total));
 	}
 	/* Limit minimum refresh rate to what can be supported by hardware */
-	min_refresh_in_uhz = min_hardware_refresh_in_uhz > in_config->min_refresh_in_uhz ?
-		min_hardware_refresh_in_uhz : in_config->min_refresh_in_uhz;
+	min_refresh_in_uhz = max(min_hardware_refresh_in_uhz, in_config->min_refresh_in_uhz);
 	max_refresh_in_uhz = in_config->max_refresh_in_uhz;
 
 	/* Full range may be larger than current video timing, so cap at nominal */
-- 
2.31.1.windows.1