Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad43c064-0593-a30a-84eb-33618d0c868e@linaro.org>
Date:   Mon, 19 Jun 2023 15:12:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C
 and SPI
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        cros-qcom-dts-watchers@chromium.org,
        Nikita Travkin <nikita@trvn.ru>,
        Stephan Gerhold <stephan@gerhold.net>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230617171541.286957-1-krzysztof.kozlowski@linaro.org>
 <20230617171541.286957-3-krzysztof.kozlowski@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230617171541.286957-3-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C and SPI controller bindings do not allow label property:
> 
>   apq8016-sbc.dtb: spi@78b7000: Unevaluated properties are not allowed ('label' was unexpected)
>   apq8016-sbc.dtb: i2c@78b6000: Unevaluated properties are not allowed ('label' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index f3d65a606194..e0993e32ee38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -172,15 +172,13 @@ led@6 {
>  };
>  
>  &blsp_i2c2 {
> -	/* On Low speed expansion */
> +	/* On Low speed expansion: LS-I2C0 */
>  	status = "okay";
> -	label = "LS-I2C0";
>  };
>  
>  &blsp_i2c4 {
> -	/* On High speed expansion */
> +	/* On High speed expansion: HS-I2C2 */
>  	status = "okay";
> -	label = "HS-I2C2";
>  
>  	adv_bridge: bridge@39 {
>  		status = "okay";
> @@ -228,21 +226,18 @@ adv7533_out: endpoint {
>  };
>  
>  &blsp_i2c6 {
> -	/* On Low speed expansion */
> +	/* On Low speed expansion: LS-I2C1 */
>  	status = "okay";
> -	label = "LS-I2C1";
>  };
>  
>  &blsp_spi3 {
> -	/* On High speed expansion */
> +	/* On High speed expansion: HS-SPI1 */
>  	status = "okay";
> -	label = "HS-SPI1";
>  };
>  
>  &blsp_spi5 {
> -	/* On Low speed expansion */
> +	/* On Low speed expansion: LS-SPI0 */
>  	status = "okay";
> -	label = "LS-SPI0";
>  };
>  
>  &blsp_uart1 {