Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp6414236rwd; Mon, 19 Jun 2023 07:03:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6tgDLUXeLUVqxadu78xtaOVxSbVknbEp9rH1Gg5wN3sMtLLzk+dc4ufsjvfzilPTYH8lGw X-Received: by 2002:a05:6a20:4304:b0:121:cff2:a44b with SMTP id h4-20020a056a20430400b00121cff2a44bmr1702521pzk.25.1687183383499; Mon, 19 Jun 2023 07:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687183383; cv=none; d=google.com; s=arc-20160816; b=e49SKQseaoEJorZAOi409zt7DiM7OfN7kRbkryo1arwkZp9hhCuksTaF6tEJfLmGdb 5U5H75xQce9xp8Jm6yWbTemCxWqOKuubtjYdJlU4ZbRhINjgRJETpNJBQzGSNVEzSp0K 9B8LNbgcPp1FKBCwSF50ew3D3jyvmjggqcdOJgJCzTmuPERQwAFB+lliYD1PBGizisAs Xjxt50E9w80/n8WeV2HjHuItBDmCUu+FD851Mw/6/ztprJUqPehmk1f7OQdcEF4DqCZn PYvf85/omRVgOE933s9dy1Nqrt7q050Q40yIMAldBFw10QBcL95GUZswN4ZcRdue8hml NtDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Vk302f39rRkI3sCTLAPNFkOrhjgiDmscCE65ATB/Apo=; b=IlL5WWihkmE1T6KUCHvIakYWn1yZf2XL/TCfAOKmSDtnnx639HSGjrK0WjTWjYjMbM igN4xoukRZUcNG//c/fKiNvH8I4DBdlit4FFrjB7gng/dxzAw46jElW9fT6uTN3OjMvE fttO8w+aZVi9rX+kgnNrilMkmLR0cAMb2/6r/NObhDOo3+oQhO9QzkExknPmUm3khpMl xMuLH4hE45TYnLTsy54mDbcw7R5yD3arxiVJolOZUjSb2nMlyZA9fcSwjQLeSvaj9dzc S8uA+/vxQpvLO2NqJNaIwl7XEPdF4eFoiQUXmUA7u6oc+Y4bJdAxZioo/bM37a/ep6Lv x/5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="hifi/w+3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l70-20020a639149000000b0055387a0517dsi5931396pge.529.2023.06.19.07.02.39; Mon, 19 Jun 2023 07:03:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="hifi/w+3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbjFSNm6 (ORCPT + 99 others); Mon, 19 Jun 2023 09:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjFSNm5 (ORCPT ); Mon, 19 Jun 2023 09:42:57 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 400F8E59 for ; Mon, 19 Jun 2023 06:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687182131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Vk302f39rRkI3sCTLAPNFkOrhjgiDmscCE65ATB/Apo=; b=hifi/w+3aABiqsjA/JuIAwxxyBYff023nzkttrVH6nH7VEPH5PghJEm0CiUI8/Iq4I72lt OgYyLW6uWc/AXPLfqEWIKuuNFUfOn680l5zkp4GIfZ1eURLYoOtwhoPaQJyMvYx5gr7o79 ZHHZHui30OFglmd/11+Vy/qDYQNM2II= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-257-tQFX428lNvKBr4q8ftaEaQ-1; Mon, 19 Jun 2023 09:42:09 -0400 X-MC-Unique: tQFX428lNvKBr4q8ftaEaQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 912E51C08DAF; Mon, 19 Jun 2023 13:42:08 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id BCA7D112132C; Mon, 19 Jun 2023 13:42:07 +0000 (UTC) From: David Howells To: Linus Torvalds Cc: David Howells , Marc Dionne , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] afs: Fix writeback Date: Mon, 19 Jun 2023 14:42:02 +0100 Message-ID: <20230619134204.922713-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Could you apply these fixes to AFS writeback code from Vishal? (1) Release the acquired batch before returning if we got >=5 skips. (2) Retry a page we had to wait for rather than skipping over it after the wait. The patches can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes Thanks, David --- %(shortlog)s %(diffstat)s Vishal Moola (Oracle) (2): afs: Fix dangling folio ref counts in writeback afs: Fix waiting for writeback then skipping folio fs/afs/write.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)