Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 15:20:43 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Steven Rostedt <rostedt@goodmis.org>, hexingwei001@208suo.com,
        senozhatsky@chromium.org, linux-kernel@vger.kernel.org,
        linux@rasmusvillemoes.dk
Subject: Re: [PATCH] lib/test_printf.c: space required after that ','
Message-ID: <ZJBWK01h7xCO0olj@alley>
References: <20230614082523.63191-1-panzhiai@cdjrlc.com>
 <f2d8eb955890bc1db1b307db713d4a4a@208suo.com>
 <ZImzXhc7ZRbSvz7/@smile.fi.intel.com>
 <20230614110640.57817123@gandalf.local.home>
 <ZInZ1BcHHQbok+wg@smile.fi.intel.com>
 <ZI/5guHaSPrld+Cv@duo.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZI/5guHaSPrld+Cv@duo.ucw.cz>
Precedence: bulk

On Mon 2023-06-19 08:45:22, Pavel Machek wrote:
> On Wed 2023-06-14 18:16:36, Andy Shevchenko wrote:
> > On Wed, Jun 14, 2023 at 11:06:40AM -0400, Steven Rostedt wrote:
> > > On Wed, 14 Jun 2023 15:32:30 +0300
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@208suo.com wrote:
> > > > > Add missing spaces to clear checkpatch errors:
> > > > > 
> > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).  
> > > > 
> > > > Doesn't make any difference to the code, so let do this (unneeded) churn
> > > > to calm checkpatch down.
> > > > 
> > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > 
> > > checkpatch is for patches (new code) and should not be run on existing code.
> > 
> > Why does it have -f option? What do you propose to prevent people from using it?
> 
> Brain needs to be used while using checkpatch.

I agree.

Also I agree with Sergey that these changes just complicate
backport.

I would prefer if people did not send these cosmetic "fixes".


> Plus, autosel is "great" trying to backport anything that mentions
> "error", so better don't do this.

Autosel is another tool which would deserve a human filter. Well, we have
it because of lack of resources...

I am surprised that checkpatch.po reports the missing space as an "ERROR"
in the first place.

Best Regards,
Petr