Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 19:36:35 +0530
From:   Kanchan Joshi <joshi.k@samsung.com>
To:     Pavel Begunkov <asml.silence@gmail.com>
Cc:     David Ahern <dsahern@kernel.org>, Breno Leitao <leitao@debian.org>,
        io-uring@vger.kernel.org, axboe@kernel.dk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        Matthieu Baerts <matthieu.baerts@tessares.net>,
        Mat Martineau <martineau@kernel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
        Xin Long <lucien.xin@gmail.com>, leit@fb.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        dccp@vger.kernel.org, mptcp@lists.linux.dev,
        linux-sctp@vger.kernel.org, ast@kernel.org, kuniyu@amazon.com,
        martin.lau@kernel.org, Jason Xing <kernelxing@tencent.com>,
        Joanne Koong <joannelkoong@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Willem de Bruijn <willemb@google.com>,
        Guillaume Nault <gnault@redhat.com>,
        Andrea Righi <andrea.righi@canonical.com>
Subject: Re: [RFC PATCH v2 1/4] net: wire up support for
 file_operations->uring_cmd()
Message-ID: <20230619140635.GA4046@green245>
MIME-Version: 1.0
In-Reply-To: <d9c9bd5f-b17e-fbd8-5646-4f51b927cc6b@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Content-Type: multipart/mixed;
        boundary="----PcSJ1RlEyPKfjXIiTsweH-7MCPtMf9v3nlMrb72LWO-fIHxy=_7a99d_"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230614110757.3689731-1-leitao@debian.org>
        <20230614110757.3689731-2-leitao@debian.org>
        <6b5e5988-3dc7-f5d6-e447-397696c0d533@kernel.org>
        <CGME20230619092935epcas5p26ad065e6c9d339687802b9c26a4f0fbc@epcas5p2.samsung.com>
        <d9c9bd5f-b17e-fbd8-5646-4f51b927cc6b@gmail.com>
Precedence: bulk

------PcSJ1RlEyPKfjXIiTsweH-7MCPtMf9v3nlMrb72LWO-fIHxy=_7a99d_
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Disposition: inline

On Mon, Jun 19, 2023 at 10:28:30AM +0100, Pavel Begunkov wrote:
>On 6/14/23 16:15, David Ahern wrote:
>>On 6/14/23 5:07 AM, Breno Leitao wrote:
>>>diff --git a/include/linux/net.h b/include/linux/net.h
>>>index 8defc8f1d82e..58dea87077af 100644
>>>--- a/include/linux/net.h
>>>+++ b/include/linux/net.h
>>>@@ -182,6 +182,8 @@ struct proto_ops {
>>>  	int	 	(*compat_ioctl) (struct socket *sock, unsigned int cmd,
>>>  				      unsigned long arg);
>>>  #endif
>>>+	int		(*uring_cmd)(struct socket *sock, struct io_uring_cmd *cmd,
>>>+				     unsigned int issue_flags);
>>>  	int		(*gettstamp) (struct socket *sock, void __user *userstamp,
>>>  				      bool timeval, bool time32);
>>>  	int		(*listen)    (struct socket *sock, int len);
>>>diff --git a/include/net/sock.h b/include/net/sock.h
>>>index 62a1b99da349..a49b8b19292b 100644
>>>--- a/include/net/sock.h
>>>+++ b/include/net/sock.h
>>>@@ -111,6 +111,7 @@ typedef struct {
>>>  struct sock;
>>>  struct proto;
>>>  struct net;
>>>+struct io_uring_cmd;
>>>  typedef __u32 __bitwise __portpair;
>>>  typedef __u64 __bitwise __addrpair;
>>>@@ -1259,6 +1260,9 @@ struct proto {
>>>  	int			(*ioctl)(struct sock *sk, int cmd,
>>>  					 int *karg);
>>>+	int			(*uring_cmd)(struct sock *sk,
>>>+					     struct io_uring_cmd *cmd,
>>>+					     unsigned int issue_flags);
>>>  	int			(*init)(struct sock *sk);
>>>  	void			(*destroy)(struct sock *sk);
>>>  	void			(*shutdown)(struct sock *sk, int how);
>>>@@ -1934,6 +1938,8 @@ int sock_common_recvmsg(struct socket *sock, struct msghdr *msg, size_t size,
>>>  			int flags);
>>>  int sock_common_setsockopt(struct socket *sock, int level, int optname,
>>>  			   sockptr_t optval, unsigned int optlen);
>>>+int sock_common_uring_cmd(struct socket *sock, struct io_uring_cmd *cmd,
>>>+			  unsigned int issue_flags);
>>>  void sk_common_release(struct sock *sk);
>>>diff --git a/net/core/sock.c b/net/core/sock.c
>>>index 1df7e432fec5..339fa74db60f 100644
>>>--- a/net/core/sock.c
>>>+++ b/net/core/sock.c
>>>@@ -3668,6 +3668,18 @@ int sock_common_setsockopt(struct socket *sock, int level, int optname,
>>>  }
>>>  EXPORT_SYMBOL(sock_common_setsockopt);
>>>+int sock_common_uring_cmd(struct socket *sock, struct io_uring_cmd *cmd,
>>>+			  unsigned int issue_flags)
>>>+{
>>>+	struct sock *sk = sock->sk;
>>>+
>>>+	if (!sk->sk_prot || !sk->sk_prot->uring_cmd)
>>>+		return -EOPNOTSUPP;
>>>+
>>>+	return sk->sk_prot->uring_cmd(sk, cmd, issue_flags);
>>>+}
>>>+EXPORT_SYMBOL(sock_common_uring_cmd);
>>>+
>>
>>
>>io_uring is just another in-kernel user of sockets. There is no reason
>>for io_uring references to be in core net code. It should be using
>>exposed in-kernel APIs and doing any translation of its op codes in
>>io_uring/  code.
>
>That callback is all about file dependent operations, just like ioctl.
>And as the patch in question is doing socket specific stuff, I think
>architecturally it fits well. 

I also feel that it fits well.
Other users of uring-cmd (nvme, ublk) follow the same model.

------PcSJ1RlEyPKfjXIiTsweH-7MCPtMf9v3nlMrb72LWO-fIHxy=_7a99d_
Content-Type: text/plain; charset="utf-8"


------PcSJ1RlEyPKfjXIiTsweH-7MCPtMf9v3nlMrb72LWO-fIHxy=_7a99d_--