Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230617171512.286795-1-krzysztof.kozlowski@linaro.org> <4c71208b-5621-2495-a5de-3622a44d05d4@linaro.org>
In-Reply-To: <4c71208b-5621-2495-a5de-3622a44d05d4@linaro.org>
From:   Steev Klimaszewski <steev@kali.org>
Date:   Mon, 19 Jun 2023 09:11:48 -0500
Message-ID: <CAKXuJqhQJftK9rjG_CRmuc93Sdi1-p0LCNZQ56Uwfxsa-V8WUA@mail.gmail.com>
Subject: Re: [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jun 19, 2023 at 8:16=E2=80=AFAM Konrad Dybcio <konrad.dybcio@linaro=
.org> wrote:
>
> On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> > Panel bindings (boe,nv133fhm-n61) require supply which here actually ca=
n
> > be turned on/off via GPIO control:
> >
> >   sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required prop=
erty
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > ---
> >
> > Not tested on hardware
> > ---
> +Steev
>
> Konrad
> >  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arc=
h/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > index cfbc4fc1eba9..3d871567cf81 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > @@ -87,6 +87,25 @@ sn65dsi86_refclk: sn65dsi86-refclk {
> >               clock-frequency =3D <19200000>;
> >       };
> >
> > +     vph_pwr: regulator-vph-pwr {
> > +             compatible =3D "regulator-fixed";
> > +             regulator-name =3D "vph_pwr";
> > +             regulator-min-microvolt =3D <3700000>;
> > +             regulator-max-microvolt =3D <3700000>;
> > +     };
> > +
> > +     vlcm_3v3: regulator-vlcm-3v3 {
> > +             compatible =3D "regulator-fixed";
> > +             regulator-name =3D "vlcm_3v3";
> > +
> > +             vin-supply =3D <&vph_pwr>;
> > +             regulator-min-microvolt =3D <3300000>;
> > +             regulator-max-microvolt =3D <3300000>;
> > +
> > +             gpio =3D <&tlmm 88 GPIO_ACTIVE_HIGH>;
> > +             enable-active-high;
> > +     };
> > +
> >       backlight: backlight {
> >               compatible =3D "pwm-backlight";
> >               pwms =3D <&sn65dsi86 1000000>;
> > @@ -419,6 +438,7 @@ aux-bus {
> >                       panel: panel {
> >                               compatible =3D "boe,nv133fhm-n61";
> >                               backlight =3D <&backlight>;
> > +                             power-supply =3D <&vlcm_3v3>;
> >
> >                               port {
> >                                       panel_in_edp: endpoint {

I've tested this on my c630, which does have the nv133fhm-n61,
however... the c630 has 2 different LCD panels available, and I do not
have a c630 which has the other panel (anymore).  I reached out on IRC
to the person who has it, but have not yet heard back.

-- steev