Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp6497907rwd; Mon, 19 Jun 2023 08:06:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4l3/25tVE7py7ywxSR+tlcMuh5ms79BjMjFejDQ+DVZFemJVNfQZItTSB+3RKGhMYevuwC X-Received: by 2002:a17:903:445:b0:1b3:f3ae:e1ed with SMTP id iw5-20020a170903044500b001b3f3aee1edmr9669927plb.37.1687187187583; Mon, 19 Jun 2023 08:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687187187; cv=none; d=google.com; s=arc-20160816; b=R9dVkyJsfe15Plx57cC0Nj3PSOu/G4tFBCznKJwrYZwV6+e3p2qPhYZlNH4TwZy/iY SO8F+crZCpuKcCOGqy55izWtEGPxr9YYTss8cnQOPepIN4UN9xxSrPiI0PgpYv9Mo+8l 9Xro6xtgsV14zrdjZkqcEUbtxHhApSsLfSMRASu6lIDP+xA3x/kd7AewdH4SBHdAnqJH AbqTHrN4ztIXtMe8hirbxI5lwt0X1AeBXp9IUAPo7HUuhlHFkXOCEF/QbDwJ3ZtKsL5k auN5l0uWR/XD28NtJXzVp3Pb2PJeSyH8LweX3sj32qVOeKkyZLe4pxYDVrNPSuUiBJ81 WvNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I48lyfS0GmZOpSPq6hUqoQ8Jww6eDc24FRgdhdcvuCo=; b=hwZs0a79rsnQ5Uy7zxjTW/UTaKHJTVzWNea4Ghi+Vv7VfSNE70C0fA3i8f/QMrQJvl um2OejZio4Zghd5Vqxv94HLbC3BaQMt//CZh6MTQzBsY9RYT12lLABgzRk3LV6W/rOWk Zvi/opg2sL+wo4ObyRkmc2Po9eIimwv8G3e5NgKWPUd0NEDjIlujhYn6/Tsb2wBiH46c omX5z3gsnt4iUtCEbbMozufuaLNQAOeMKnrec3gdUU/ClSLt6HfGzllyzSpQrersF4fR i8QEvLfQNGYtD1Dpj9Y/Z1sCO1f25PdLwcNP3Ot0ECes9XWPIWPQbGoK7b+7Nu4hbP4u fP8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="YYLBDj/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a12-20020a1709027d8c00b001b6740207cbsi576595plm.588.2023.06.19.08.06.10; Mon, 19 Jun 2023 08:06:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="YYLBDj/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232216AbjFSO4e (ORCPT + 99 others); Mon, 19 Jun 2023 10:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjFSO4d (ORCPT ); Mon, 19 Jun 2023 10:56:33 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18464AA; Mon, 19 Jun 2023 07:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687186592; x=1718722592; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HukD5kUMPNH473OwrZ3/aKlQsAS1ptDXh1LdoJoOMcg=; b=YYLBDj/F3NcLHDa8lM9oQ2zGaGphUGqKlLylICZytB53eeBBDQh8Q7Vs LumC3obxkmVcMF1yCPUzILGGVS3q6xxtEhNque1zqsbdreKlsddEQZ12Y sluMdNI2MIuSvzqxh9OL82xcr4rXqyodZ6DGiNzjwJv1dikLVJfzGbqf0 thneBY7NrfZ2l4N6m7y2jcVU58o9x+a1u2fuoca/Fio4HWLyLRsyVW9gR ooCsLUPu4k5N6T0lYNCcAnaRPQI1RgSXZoCljVwkM6iRnupEm7++tOfpK mQF+D6uvhq5LUWR86rwCXKRk+L73ADFewsEL1ZOGv2JxuXML581ykl6xX A==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="363073173" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="363073173" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 07:56:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="858245407" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="858245407" Received: from leitchrx-mobl1.ger.corp.intel.com (HELO box.shutemov.name) ([10.249.45.32]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 07:56:25 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 01FD210DD6D; Mon, 19 Jun 2023 17:56:22 +0300 (+03) Date: Mon, 19 Jun 2023 17:56:22 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "nik.borisov@suse.com" , "linux-kernel@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "tglx@linutronix.de" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 15/20] x86/virt/tdx: Configure global KeyID on all packages Message-ID: <20230619145622.cjyis472geajrmnk@box.shutemov.name> References: <30358db4eff961c69783bbd4d9f3e50932a9a759.1685887183.git.kai.huang@intel.com> <49bd9f7f-9a2b-8b8c-f408-49b9b5982eb7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2023 at 10:24:17PM +0000, Huang, Kai wrote: > Hi Kirill/Dave, > > Since I have received couple of tags from you, may I know which way do you > prefer? I agree with Nikolay, removing these "if (ret)" helps readability. -- Kiryl Shutsemau / Kirill A. Shutemov