Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c7cc6b2-5c63-f893-d4ac-fcea40b2a4b4@infradead.org>
Date:   Mon, 19 Jun 2023 08:18:25 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH] s390/net: lcs: use IS_ENABLED() for kconfig detection
Content-Language: en-US
To:     Alexandra Winter <wintera@linux.ibm.com>,
        patchwork-bot+netdevbpf@kernel.org
Cc:     linux-kernel@vger.kernel.org, wenjia@linux.ibm.com,
        linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
        borntraeger@linux.ibm.com, svens@linux.ibm.com
References: <20230615222152.13250-1-rdunlap@infradead.org>
 <168690302072.8823.785077843270614259.git-patchwork-notify@kernel.org>
 <4f2afa34-830a-3c17-99e7-1cb5b874e7ce@linux.ibm.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <4f2afa34-830a-3c17-99e7-1cb5b874e7ce@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/19/23 03:04, Alexandra Winter wrote:
> 
> 
> On 16.06.23 10:10, patchwork-bot+netdevbpf@kernel.org wrote:
>> Hello:
>>
>> This patch was applied to netdev/net-next.git (main)
>> by David S. Miller <davem@davemloft.net>:
>>
>> On Thu, 15 Jun 2023 15:21:52 -0700 you wrote:
>>> When CONFIG_ETHERNET=m or CONFIG_FDDI=m, lcs.s has build errors or
>>> warnings:
>>>
>  
> IIUC, CONFIG_ETHERNET is bool.

duh, yes. Thanks.

> I reproduced this with CONFIG_ETHERNET=n and CONFIG_FDDI=m,
> and verified that it does compile with your patch.
> 
> Thank you Randy for correcting this.
> 
>>> ../drivers/s390/net/lcs.c:40:2: error: #error Cannot compile lcs.c without some net devices switched on.
>>>    40 | #error Cannot compile lcs.c without some net devices switched on.
>>> ../drivers/s390/net/lcs.c: In function 'lcs_startlan_auto':
>>> ../drivers/s390/net/lcs.c:1601:13: warning: unused variable 'rc' [-Wunused-variable]
>>>  1601 |         int rc;
>>>
>>> [...]
>>
>> Here is the summary with links:
>>   - s390/net: lcs: use IS_ENABLED() for kconfig detection
>>     https://git.kernel.org/netdev/net-next/c/128272336120
>>
>> You are awesome, thank you!
> 

-- 
~Randy