Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Cyrill Gorcunov <gorcunov@gmail.com>,
        Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Cc:     linux-kernel@vger.kernel.org, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        suresh.b.siddha@intel.com,
        Kishon Vijay Abraham I <kvijayab@amd.com>,
        Vasant Hegde <vasant.hegde@amd.com>
Subject: Re: [PATCH v1] x86/apic: Fix kernel panic when "intremap=off" and
 "x2apic_phys" are set
In-Reply-To: <ZI+EARkh3xsvkRfA@grain>
References: <20230616212236.1389-1-dheerajkumar.srivastava@amd.com>
 <ZI+EARkh3xsvkRfA@grain>
Date:   Mon, 19 Jun 2023 17:25:41 +0200
Message-ID: <874jn3qxsa.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Mon, Jun 19 2023 at 01:24, Cyrill Gorcunov wrote:
>
> Hi! Good catch! In long term I think we could switch to use
> x2apic_state variable instead since at the moment the code is somehow
> hard to read and remember which exactly deps are to be satisfied to
> enable x2apic mode.

It's on my todo list for a very long time. Unfortunately that list is
growing only into one direction...