Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yunlei He <heyunlei@oppo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yunlei He <heyunlei@oppo.com>
Subject: [f2fs-dev][PATCH v2] f2fs: count mmap write io more accurately
Date:   Mon, 19 Jun 2023 23:44:32 +0800
Message-Id: <20230619154432.2205654-1-heyunlei@oppo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0RvtKxkgglXnwDerk4t659lElg6J1bA667gd85BTkmGoryEYu2aClrjAPLn+?=
 =?us-ascii?Q?rSAGuf6tpnhb1+Ijl9IidJGtqBTjwm4xSOsx+WrW/0UxikXJYX1KLaCSP3lF?=
 =?us-ascii?Q?owRRo0LhV+p3Vgwwn6ydZh72kU+2ZFl0vtQvo1m/mz4VQHIp5I8krBvfU1y/?=
 =?us-ascii?Q?wmxfoozHaLa+g52y9cg5Pm/L3dd4vH2Y+5lO5XtT4b3qZC6k2O5Yz9kaLApy?=
 =?us-ascii?Q?21xe4q/QBbkmb89rKYKM9N1wkD6FCdwSIPYJdex+ygbDtL9xVimmA1Nxcfxn?=
 =?us-ascii?Q?P1t99SACZ1U4vsex2aKC1xoYkJ6TjOxLkerUZ+R75u/CqtUEKUdfHtSv7iac?=
 =?us-ascii?Q?3LeBp0MFjzzN2i/ISDtKw0IoEjX+o9uYF5pUdiScnLFgo6y6108ECI0NqZGP?=
 =?us-ascii?Q?qiP8PQuaILrZtLEYt4Exkq/G3d8Ro5bdJOL8+HoWUtp30dmFL4GMgKwf7CHJ?=
 =?us-ascii?Q?vwJtJBD40bUFgCPxnWvNn2untDr58zLwX5mLtjJQleqe5nZPhiRAQfD5O/G/?=
 =?us-ascii?Q?ocuULfuKf0wV60I/Cs3SCf/hrBrDvh5VaydWtN4ie91NeFHXLP8zyxmmnf2L?=
 =?us-ascii?Q?5SW710RgkFyha6y1DQPAc4fE6GTbbiIKd+ziWtnUc/SqUE2B68bZxKjxl1LV?=
 =?us-ascii?Q?DTDVhMRTpAlojAW6kDXN5SzQZgoIW5x53p5jhFMto/DtCVXPd/5JlHMz9mSH?=
 =?us-ascii?Q?GduPXOB09PMyB7u9TJjDYIA+m0TN/V9Mheidv1EVtZNofeEYQLZ+VNmqEt34?=
 =?us-ascii?Q?+S0RiL6uHN07Td9lY58F8xN1OaxOat+Enqw3oUeV01+d7WNgPsjpkZRfTE+N?=
 =?us-ascii?Q?NZUPVWSVXvkHHXXEmmf2575uph9aW6PhIhvxy1N4QC7zF3s9gweAL1C/51pZ?=
 =?us-ascii?Q?Js58jwZxom4Ll7FhUc5Co2NJtFwS3TlxV670f7qVKF8e/JGOdZEqK+iJYqRD?=
 =?us-ascii?Q?lSyoHSpl4K/XWrWtUNE9AMwajtt4XJ/GsrbTojQQbytB/mmotzUIO2FPsfis?=
 =?us-ascii?Q?g1C3nnYCWARrNj8hXxXi/gg5w+3ljFarMo4fawN/hYx9gOqKY3UUAB32bBNJ?=
 =?us-ascii?Q?UbQ6Tugws1pnG//OWy6UlchWmmMprVlydu9WaojCffolsmJJDfVCbn4fNXRs?=
 =?us-ascii?Q?LSfaThdKwbs7nojwikESCWwiOXF6h/IvPVK/NwvsdxOhf0jrVw+0MaKeUMed?=
 =?us-ascii?Q?aS4s/aFxBOrfchmeqcoTGYQb0e2qSkGZIKP3QJjdZRjC50fhkRQUT9NZwBVH?=
 =?us-ascii?Q?GmjBh+Ivl1xNDsgCe2TTC/YByfBVemrqfepRiUyUlMY38hHEXafx6DKLm1cA?=
 =?us-ascii?Q?nACH//5kcCZMZpS7koR19DtjVGTJJDCFFXwmItJMnYZf70PDs9o8JCNLWWqo?=
 =?us-ascii?Q?/tqgUxbFQBW4jdHnHy8W3+zFBguIQ5nVN3Cl2Iqh7Hdyq7t97jOh7bYdOtQX?=
 =?us-ascii?Q?d5mnh6l6cYwpm0LIsGLyyBjDtSlTAuA4VfxrXuooBAEExquwosIKYx5Dphl6?=
 =?us-ascii?Q?ZhYqolHp+uITKjbxpf5cVH3TfbXGyGt7B8OlZrMzdYtmFcwOuLs0kncuHmg2?=
 =?us-ascii?Q?Hcvn1z62OUNq5abylcoUCeKbD+Ainxzjcr8xa89T?=
X-OriginatorOrg: oppo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 456806a2-8035-4ac6-2cae-08db70dc1de0
X-MS-Exchange-CrossTenant-AuthSource: TY2PR02MB4479.apcprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 15:44:50.1887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SgRVG6REoPJa+9TnfpDqBeDHyjZJk9WU/nKhIxblxjVROdSTqmYe8A7SPiRu5n237ewvCJF5XyTkRQxy6KFWKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR02MB5684
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch count mmap write io more accurately.

Signed-off-by: Yunlei He <heyunlei@oppo.com>
---
 fs/f2fs/file.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index f05209a62370..cb42d8464ad9 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -150,11 +150,13 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 	}
 	set_page_dirty(page);
 
-	f2fs_update_iostat(sbi, inode, APP_MAPPED_IO, F2FS_BLKSIZE);
-	f2fs_update_time(sbi, REQ_TIME);
-
-	trace_f2fs_vm_page_mkwrite(page, DATA);
 out_sem:
+	if (!err) {
+		f2fs_update_iostat(sbi, inode, APP_MAPPED_IO, F2FS_BLKSIZE);
+		f2fs_update_time(sbi, REQ_TIME);
+
+		trace_f2fs_vm_page_mkwrite(page, DATA);
+	}
 	filemap_invalidate_unlock_shared(inode->i_mapping);
 
 	sb_end_pagefault(inode->i_sb);
-- 
2.40.1