Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932946AbXJRHou (ORCPT ); Thu, 18 Oct 2007 03:44:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932535AbXJRHoh (ORCPT ); Thu, 18 Oct 2007 03:44:37 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:39513 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932514AbXJRHog (ORCPT ); Thu, 18 Oct 2007 03:44:36 -0400 Date: Wed, 17 Oct 2007 23:58:19 -0700 From: Andrew Morton To: Steffen Klassert Cc: Jeff Garzik , Badari Pulavarty , netdev@vger.kernel.org, lkml , satyam@infradead.org Subject: Re: [PATCH] vortex_up should initialize "err" Message-Id: <20071017235819.25bf1d5d.akpm@linux-foundation.org> In-Reply-To: <20071018060506.GA30544@newton.mathematik.tu-chemnitz.de> References: <1192662956.14504.14.camel@dyn9047017100.beaverton.ibm.com> <4716A8B4.5060406@garzik.org> <20071018060506.GA30544@newton.mathematik.tu-chemnitz.de> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 28 On Thu, 18 Oct 2007 08:05:06 +0200 Steffen Klassert wrote: > On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote: > > Badari Pulavarty wrote: > > >Simple compile warning fix. (against 2.6.23-git12) > > > > > >Thanks, > > >Badari > > > > > >vortex_up() should initialize 'err' for a successful return. > > > > > >drivers/net/3c59x.c: In function `vortex_up': > > >drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in > > >this function > > > > applied as an obvious bug fix (Steffen added to CC) > > > > Hm, we had already the 3c59x-fix-uninitialized-variable-bug.patch from > Satyam Sharma in -mm to fix this, but the patch was removed from -mm > some time ago. Andrew, what happened to this one? It's fixed in Jeff's netdev tree. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/