Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 10:51:39 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     LKML <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "Tony Battersby" <tonyb@cybernetics.com>,
        Ashok Raj <ashok.raj@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Arjan van de Veen <arjan@linux.intel.com>,
        Eric Biederman <ebiederm@xmission.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch v3 1/7] x86/smp: Make stop_other_cpus() more robust
Message-ID: <ZJCVq/cBCDFBcpwa@a4bf019067fa.jf.intel.com>
References: <20230615190036.898273129@linutronix.de>
 <20230615193330.263684884@linutronix.de>
 <ZIvByEFqiJZOyau2@a4bf019067fa.jf.intel.com>
 <87mt0z7si2.ffs@tglx>
 <ZIxt9Er5nJRjCUXh@a4bf019067fa.jf.intel.com>
 <87h6r770bv.ffs@tglx>
 <ZIzM13q+zI7d1eZs@araj-dh-work>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZIzM13q+zI7d1eZs@araj-dh-work>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PjmRhT62YxvfmzrmggrzHvqv4Nuxrb8xnhe5B4tr8+is+tFdmsP4goHlBd4n?=
 =?us-ascii?Q?GgZK3KWBoAA1w6IheSI7ikzsbgp2CWoGW87ZKJvmnXD7p8UhS4wGJHzZ/CxT?=
 =?us-ascii?Q?J/5/LjZNQ9VB8FiOlbLv8lsT5WVgNXYXyRzc9+WE/j7+kpn0MH7OLAXIiicG?=
 =?us-ascii?Q?nK/RIG+ifhTyMElfoh1vtDWJ4KGxgL+J7Ye9NUnjlNqbFd2WMRfWhxIlx5Cq?=
 =?us-ascii?Q?wt9wLVRL8mD1LREUjGZ4PNknXf+6VnqLZBySo8Y6yjqyPon5WuRxGjEaWES2?=
 =?us-ascii?Q?oY3EKQUiSNeH7ZTGD6RxhEtOE9ScHi81oioXUz/WRg7GI62PosL5N3Q1HDXn?=
 =?us-ascii?Q?umkQejvf68PBmbQIlalPCsWEXbdPmnZ979u4iuSoFb/bK3eVL0rtU+cu8GIs?=
 =?us-ascii?Q?RWUupd3KsU4DjiXpGRjU5FhsldTjNVgP+8sYF+F6bgEorJdu4SPGhEkldost?=
 =?us-ascii?Q?7ZQpTDwoNX4jYapRjyrDOqz2oWzVGhzOGJSFSVB0CKUpdIYXVW2sn5p5yRYD?=
 =?us-ascii?Q?EtKBtDOFhPsfkKivZKzR+SPiL1HWsOaYVgWpnAqH+elQkPtez1aNvka9mRtT?=
 =?us-ascii?Q?CUT26bzkNzrUci7JOogSuUmvoZIRSr44KDK4uL5RdU686cB3PeuDRuPRkPlZ?=
 =?us-ascii?Q?f+50oBANzqi80rXUs7Kn/taTBUHufs/lGbybRVUxErWkLDnh9eHezxjoFhoy?=
 =?us-ascii?Q?js4YtHmO8+HnaVhzB48mRUQWUXgRCl1QDE4DSKMwwyptZpni0oneYccwXEGE?=
 =?us-ascii?Q?hIQdT1qzCDpuimpwwt0XSohepWdc9RGMIZUPKUUUa8eqqbd4d72Z2ffnqS2k?=
 =?us-ascii?Q?jxofOtar0HbVISY41reIhPFpssN/UNwrDL/PmzmT9sL0UnJ1shoH8FJlZ54W?=
 =?us-ascii?Q?9o2qPZsg/gHU1kmmZBUI0/kVgWphNBz4UoNdTbbHw8ymZib5AKO2Ac5SvSrV?=
 =?us-ascii?Q?g7HH8nPsMsKsWwwSINYEbsmXWMCSBzG0W9z/ael4tfwsgO9R+mQQqRG6yaox?=
 =?us-ascii?Q?Co5+KZ4bNXb+0bD+KDYKhSBVSfFUHylRzDo8pcVSGieDxXYeRoDrqv2MGcEb?=
 =?us-ascii?Q?kUjC/OHoZmhiMKRWxbR9+PcLkEnRKWIFr2sC21zOq5DNu2kNTQgjzcodkWch?=
 =?us-ascii?Q?bocSThxSmFXd04iKLKzutuYZLb+mQrEY9LR+1wsIacd8Zebe+uQoSerwLU0o?=
 =?us-ascii?Q?t5HmY1hkwtmYVfKaSTwAOAb4w6JeVlVIOwT4I0ouH1yeJb9gBg6ap502bTMS?=
 =?us-ascii?Q?NA8wYvBtJ4DYSLmm5TyQ86RrV/mp4mCYRg3Cwy9Jqzo5Cn/AU2iEzw27fvdW?=
 =?us-ascii?Q?tIWo3k6M3JTGIqX8ryV5EbG5UgEd1YzTp+enoLnKp0ONOXDEOeOkjLyAeaej?=
 =?us-ascii?Q?3g0d8awrpcQCohBUVK9SI9GPuqYhEY5T8+ed4ZnPdvPGSw+qi39qAX5em8O1?=
 =?us-ascii?Q?5evx9exKm/efINd3kUGw2ZjhM4VSL2ZpqPqnrm5wNAEIWu4XleW6jqdJjTok?=
 =?us-ascii?Q?+U18PTdddSevAjC+mEkQhw5yeI6y4DU3G6nwuQRu4HPWcqFJYXXoz1rPxap/?=
 =?us-ascii?Q?gw5qVGdWdC/L6t+JQzH1vq1w3y6RpZh8pzrq0k7b?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e36d017-86ce-4024-3cf6-08db70edd788
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 17:51:43.0068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3EuTTRk4XtWjG3LRjulZxLMrwFunxFtebSJ+V9/gr88tgsXqQbcGp2DBGIzISt425tZ87kb18O+WAoXj3KCrsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6718
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 16, 2023 at 01:57:59PM -0700, Ashok Raj wrote:
> On Fri, Jun 16, 2023 at 08:01:56PM +0200, Thomas Gleixner wrote:
> > On Fri, Jun 16 2023 at 07:13, Ashok Raj wrote:
> > > On Fri, Jun 16, 2023 at 09:53:25AM +0200, Thomas Gleixner wrote:
> > >> > can we simplify this by just apic->send_IPI(cpu, NMI_VECTOR); ??
> > >> 
> > >> That would not set APIC_DM_NMI in delivery mode and the IPI would be
> > >> sent with APIC_DM_FIXED.
> > >
> > > That's correct. 
> > >
> > > Maybe if we use apic->send_IPI_mask(cpumask_of(cpu), NMI_VECTOR)
> > >
> > > apic->send_IPI_mask(cpumask_of(cpu),NMI_VECTOR)
> > >    __x2apic_send_IPI_mask() 
> > >       __x2apic_send_IPI_dest()
> > > 	  unsigned long cfg = __prepare_ICR(0, vector, dest);
> > > 	  native_x2apic_icr_write(cfg, apicid);
> > >
> > > __prepare_ICR() seems to have the magic for APIC_DM_NMI?
> > 
> > Bah. I clearly neither can read nor can remember any of the internals of
> > that code:
> > 
> > apic->send_IPI()
> >   x2apic_send_IPI()
> >     __x2apic_send_IPI_dest()
> > 
> > It also works for all other APIC incarnations. 
> 
> Works!
> 

Forgot to add 

Reviewed-by: Ashok Raj <ashok.raj@intel.com>