Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ca501364-a7d6-8d56-1f32-91430b9bcf4b@amd.com>
Date:   Mon, 19 Jun 2023 12:37:03 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v2 1/5] cpupower: Recognise amd-pstate active mode driver
Content-Language: en-US
To:     Wyes Karny <wyes.karny@amd.com>
Cc:     trenn@suse.com, shuah@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, rafael@kernel.org,
        gautham.shenoy@amd.com, Ray.Huang@amd.com, Perry.Yuan@amd.com
References: <20230616120620.147643-1-wyes.karny@amd.com>
 <20230616120620.147643-2-wyes.karny@amd.com>
 <348fbe1a-6c2d-68d2-b4fc-278407ede33c@amd.com>
 <ZJCQ2ypbQgZOOjt3@BLR-5CG13462PL.amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <ZJCQ2ypbQgZOOjt3@BLR-5CG13462PL.amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUFoZUVkcU5CSndYUUdwL0hwenAxWkxVS3ZXKzRIdUhydDhzUmp3TWQwUFFG?=
 =?utf-8?B?VVcyYUVZejVIRGlEcGplN1Rpb0Qzei9vZG9iZmRmTU1JT3AwU2lyUzR2WlE1?=
 =?utf-8?B?cmwwZElkWWlkVDNuaWdwN0p2UjhhQkJ2R3p3RVA3b0JnYkhhZDJNZWRaOW5l?=
 =?utf-8?B?TWJQaHNGdzArYWR5VC85Q2lHck9zZzl5VWt6NUI4ZFdCWHdsbTRXbUkvQkhX?=
 =?utf-8?B?RXNqVHhYdHp3YkNsdHpSQlp2MmYveDByemNXMDlWWWN6SGhyeWFzYVpkcHVM?=
 =?utf-8?B?TjNja1AxU2VBbkdXMVYvcElQeDdrSDJndDFWL2xvV2VOMFdyZUU0bDJ4eUxC?=
 =?utf-8?B?ZkZuaTFQNUhZc25vQmhjOG5kSlUxSmh0RnE4UkxXL2ZYSEJId1FnWTFLcG5V?=
 =?utf-8?B?TFlnS2F1TnVmN2hBQjlwQlhKV3d2bFVrNVJYT01yVHdQQXVTanByZ3E5TXFY?=
 =?utf-8?B?UmVCelV3akIwZEdDZ09wSlNDZk8ybzJET3ZQZnR3WWd2VFQrYkpHc09FSHpK?=
 =?utf-8?B?Q1NBZkxvRUUydlZEQWEyZTNlTHRxVDdDOU9LVVc3SVgwbzFTV0FQVlp6dFZp?=
 =?utf-8?B?QnF5YWJuTDBPcGFhRUhZNmlraG1sRFFieTN6b0l6K2s0ejlOU1pyUklKMmUy?=
 =?utf-8?B?Q3ZadjlDYlBValMrcGtqeFZJRXNmSFR4cG16dk9aTmxHaEE5QkJaZXdFZGFJ?=
 =?utf-8?B?LzNkemplV0JrZDRZUHdIM3dZZk5LSWNWalZIdTR6OTMrMC8vdW5xUGpJQUMv?=
 =?utf-8?B?a1FibGczbmpvL1E1dVpVOVRXUmQzeGREblphUzRhYjNRODhoVXpMRjBoRmhy?=
 =?utf-8?B?UTZrTlAvSVpDT3RKUkV4TS84cXhVTHVITlJxVXNiUmRiaU1DT2lUSnBDVmlL?=
 =?utf-8?B?S0tVMTNMRVlrTEg5MWJGRkJBUUQwSjJEcm9EY0FCZkJlTERLdXpYV05qZWZw?=
 =?utf-8?B?Q3U4UXNIL0FGdkt4Rk1qbU5uU3JLMlNzOHhLbUZjZkVsTXBBbDNoK1NvNXU2?=
 =?utf-8?B?aFdhcW9aNHhpY0oxMDNqakJlTXFKeFVEbXlxdmlHcFJMZTF6WlJ2c0JIOWVh?=
 =?utf-8?B?cGYzeml0M2FSY3YySncvWmVEZEtiRUpOV0pNVDlLZ0twOEM3anBJTkh4WDVK?=
 =?utf-8?B?TEtZR1RzZFYzRC92N1Z2NjV2anFheUdsYlk0N3RpZGVveTcxaGd4elhGVkVy?=
 =?utf-8?B?NjJMVFFKNkE2emgrOGtUVEpkUzVhWEk3ZmlFNi9lOVRwc2IvdkJMSFd2ZFhR?=
 =?utf-8?B?Tkh1RkFyVnd5MUFuR051MHd2eFhEQVlYdEhMTmV4SEo5WTBqcmpYbSs4V1hK?=
 =?utf-8?B?bVViU0lhTjcwalUxTGQvMExCcGphdXd0aHFRdlp4eHFOQ2puaHRpNmtJUTJB?=
 =?utf-8?B?VVVNT0lIaUVhRktUdlRMNHR5NWRNeHJ1RVp0cFZpTHY0am5oMWZYKzNrbDNu?=
 =?utf-8?B?UjVmSUMvTU9QVktSNExRK1NZZ3JrZW5CNjlGNjN0YzZGNWx2N2FFZjMxZ3RX?=
 =?utf-8?B?emN5RnhMcHkwTjg3Mzc3cUhtVmMxc2gvL1hpRzRSbHBNV2FpTWlaenl4NDk5?=
 =?utf-8?B?V3dUZ3VPY0E3SE1EWnB4QUw3Z1pKVzhUaUpCaFkrRmt3WEd4UDN4OTVzaFhu?=
 =?utf-8?B?N01wNlhwNzJvdjBaTjdyVU9qSTdSbkJ2MHBiMTdOZGJmaTR6NVlHa3NjMVQz?=
 =?utf-8?B?a2pZVE1NbWxaVi9MejBTSjBkNHFDcHRXRDVMWjI2QjkwbW5qbzk3SWF4aEtw?=
 =?utf-8?B?UEE3L0hQbnJQWmtRRXBtbmE2OEhBLzJOU3BLRUpBQU02bHRuOW1kcVJJY2g4?=
 =?utf-8?B?RnN0UlF0R202cTFtMGYrQjVuRktYSDVxREhkWkY0TjBsMVdmSkE1WnN4aGoy?=
 =?utf-8?B?YlhZdTAyR1VNWVR2dEFrYWhyYnB2L21lcnhkRUh5QUYzRGRPOTVUbGxpcTF3?=
 =?utf-8?B?V2FSczBDaVFEa3VWa0xacy9nMTd3OHFQTnBqelV2SUVQQzBjdXo3VUNxN2to?=
 =?utf-8?B?Mi8wYWhmK1lDY3N2K051WHBmdFZOQVMyWWNHNDBFTXEwTHBVdUNXaHEwa2Mz?=
 =?utf-8?B?WEpxYVRJc3JtdWZISFI5UVpvVjVJK3RYUjlzTEdDS3p4b0xGdDJuS0NsTGN5?=
 =?utf-8?Q?+jeUT/n3VzcQsMZaOqwEl844i?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc9c3310-e2cd-4fed-3a4c-08db70ebccff
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 17:37:06.3140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o58AUm4DG0fQgGWRTdTRl0nGu+MkXzVCy3jk977pD+JKTY2wQtkWKcRT/ZCWAU6/MsCZ1ooZfERnJOdEXKE/TQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5207
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/19/2023 12:31 PM, Wyes Karny wrote:
> Hi Mario,
>
> On 18 Jun 20:58, Mario Limonciello wrote:
>> On 6/16/23 07:06, Wyes Karny wrote:
>>> amd-pstate active mode driver name is "amd-pstate-epp".  Add this to the
>>> string matching condition to recognise amd-pstate active mode driver.
>>>
>>> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
>>> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
>>> ---
>>>    tools/power/cpupower/utils/helpers/misc.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
>>> index 9547b29254a7..21f653cd472c 100644
>>> --- a/tools/power/cpupower/utils/helpers/misc.c
>>> +++ b/tools/power/cpupower/utils/helpers/misc.c
>>> @@ -95,7 +95,7 @@ bool cpupower_amd_pstate_enabled(void)
>>>    	if (!driver)
>>>    		return ret;
>>> -	if (!strcmp(driver, "amd-pstate"))
>>> +	if (!strcmp(driver, "amd-pstate") || !strcmp(driver, "amd-pstate-epp"))
>> To avoid getting caught in the case that a kernel didn't have the patch
>> separated from this series (for example if a distro missed it in a backport
>> from separate directories), how about using strncmp() instead and just look
>> for the prefix?
> Sure, I'll update the patch.
> I'm thinking of using strncmp(driver, "amd", 3), because in the above
> case the epp driver would be "amd_pstate_epp" therefore common prefix is
> only "amd".
>
> Thanks,
> Wyes
Sounds good, thanks!
>> This would also let the tool be more future proofed in the case another
>> amd-pstate driver was introduced later down the road as long as it stuck to
>> "amd-pstate*"
>>
>>>    		ret = true;
>>>    	cpufreq_put_driver(driver);