Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
        "Kang, Shan" <shan.kang@intel.com>
Subject: RE: [PATCH v8 01/33] x86/traps: let common_interrupt() handle
 IRQ_MOVE_CLEANUP_VECTOR
Thread-Topic: [PATCH v8 01/33] x86/traps: let common_interrupt() handle
 IRQ_MOVE_CLEANUP_VECTOR
Thread-Index: AQHZa4g62amPAW2/oE6/VfNOqnc7za9542QAgALl3wCAAACfgIABxIeAgBOgaQCAAG0NgIAASD3Q
Date:   Mon, 19 Jun 2023 18:47:08 +0000
Message-ID: <SA1PR11MB673465675DA199C2C7EB1ADFA85FA@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230410081438.1750-1-xin3.li@intel.com>
 <20230410081438.1750-2-xin3.li@intel.com> <87leh08e1h.ffs@tglx>
 <87edmp6doh.ffs@tglx> <70ef07f1-e3b7-7c4e-01ac-11f159a87a6b@zytor.com>
 <877csgl5eo.ffs@tglx>
 <SA1PR11MB67344FE6C8A83810D0CAF175A85FA@SA1PR11MB6734.namprd11.prod.outlook.com>
 <877crzr0pq.ffs@tglx>
In-Reply-To: <877crzr0pq.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3bNMZnovdLGuoq7dWT4G+VvYf6uFW3+tlq663hZqdWMA1blxNEbiXE5Bse6N?=
 =?us-ascii?Q?HpJgA4HxLhbiQEiItbFgF7dsV6EDZi9TXWaM8aPJW1oeY4ikBZnqOyIi1Zl7?=
 =?us-ascii?Q?wzaemRoqStN8CKCawNMT6UoqhQZcBGkAhT60OHI5qU/cQAoZ4CVsIgjjfNWZ?=
 =?us-ascii?Q?0Hz0WItXwjHZMhqJIoJ10ioNgVI5mFvBm4CwYZ+4+JYMdenIDtMh5/+qP30X?=
 =?us-ascii?Q?Rdlz3PQbNwMu2k8/lgHF1zo74H/cVQdUQeE8eOXpsnm8YxJN4AkhWc/Fxrm6?=
 =?us-ascii?Q?+KGYUQPOjIWtSRHmLGMtdbT/tNhsJiaAiYrB8lXgauTahggN74f4Y9gGEk0y?=
 =?us-ascii?Q?ei1Kja4rpVcjVgG8QnNbfvzLKxSCV3zvcg4rt4QOcKclzuAmMmp3g1WOSAI6?=
 =?us-ascii?Q?iePzcgeUdyya/6q0EF625UqBkyG5hx6a1A65rKrlEQRz71kQvQVTIzqFhGrv?=
 =?us-ascii?Q?r3JfgVHA6835XeD8+QD1xklbwLC4QBLSi0G4QzNnWjOanLjRMfdoAqBTTKWE?=
 =?us-ascii?Q?yKBgVQJomNoCPyd+f0LDOx/wfVgXC/tTpICbHEzBe4T+queJDYZjHkNNYptR?=
 =?us-ascii?Q?KzVIH0XGrEhpgp93nKANPvHSnrEEHrWNu5Wv8XFMKVpo2uv78lScvVV1VwuN?=
 =?us-ascii?Q?/MGqL5SZf9qUb4sYK9L7lr6NX6F3pGc9OslGfLW4jTJ9yorvNpiISJeHv2gQ?=
 =?us-ascii?Q?SoI94cx8VIsXt5aoCNl5dieUY0ISbLtuCE/Rdd4w2cpp51j2RbsGYBTHPlmz?=
 =?us-ascii?Q?/Iy5il/lEmXO74M/Xr6Nj0v1gniL3JBy73yRPIT6bo8FjZAGDMj9N0St8RVz?=
 =?us-ascii?Q?X/qk2Ebv3VfoiMgbGwiLFAl0n4Q8MfGI9T05ZwBIQnJv1mv4l6z2KF48ACG7?=
 =?us-ascii?Q?2Y6XOBB97gilnFiRIvh1o38l9UUjoD6V/ZvdR40/UO46v4saduXcDnnUz2gC?=
 =?us-ascii?Q?ujUtnb+d9bjIQRzWP/JrNpLGtHVcsHf/hNnwR53JnxnzlzYF4LTVVJ4PwiCQ?=
 =?us-ascii?Q?CWfUV1zjTkwBRqzv3wsvP5FLsrGbRrDM4tNOthw+s6Pr8SBrd9egStWBpXJ0?=
 =?us-ascii?Q?KqZk+fVDM0bBM2zKqauzd2gZ3K5YlEbak5FfYdJ8Zf2wb3UXAldJfJATNBYm?=
 =?us-ascii?Q?JuBvblqcAvCAqRdIV+OeOea6oWzIqiM5y96244n7SVWY0UbKSTnxCxORiENb?=
 =?us-ascii?Q?zISsdsMRzRzjvtoZv9TFooC8Jy1F50FznrzTg1NoJ5irWRQW4gPmRcT1NY6c?=
 =?us-ascii?Q?j9rEQK78iPhhnv7F6WYX1I6cQtjZkD8cdsnbbDG8tflz4qzUcE5VY0YfwcH+?=
 =?us-ascii?Q?LUjiwWtSGtBRzktJG2xwDv5rQwy6tNDN59BhOdKbDw2DbIHyWzmpe3enJ7VL?=
 =?us-ascii?Q?NLo/oKG8OKq7mmRFuXm0NC0cW3cv0rQoilKg63CAYeuAJibsvPjnd5YMgd1o?=
 =?us-ascii?Q?QIwfIOvFW8JNc80gQF81bTVv33Vt9NXctR2pnq/uQbYEs3f6344TYtQY1Rp3?=
 =?us-ascii?Q?u5XPTUrvk8b/NLpmcvdajitlEdalYOduX1C4xhSj46PNdqlfVyFKLDpMt+wb?=
 =?us-ascii?Q?uxziGodZvpVyHQDP4Vw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18df199c-3feb-40b3-9d9d-08db70f5958d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2023 18:47:08.0715
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t1eIYVnWBZb/N8izZC1dJw9cu0Z7fcInOgRpUXLVptt28utvcZ5oioAFq6XiFXsRHeDYbS6vi08LUNUJ88XE7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5541
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > To me it's better to keep the changes in one patch, thus the
> > differences are more obvious.
>=20
> The rename to vector_schedule_cleanup() can be obviously done first.

Okay, it's a bit wired to me to rename before any actual code logic change.

>=20
> > We need a second patch to do vector cleanup in lapic_offline() in case
> > the vector cleanup timer has not expired.
>=20
> Right. I was lazy and just put a WARN_ON() there under the assumption tha=
t you
> will figure it out.

I see that, as your changes to lapic_offline() are completely new.

> But a second patch?
>=20
> We don't switch things over into a broken state first and then fix it up =
afterwards.

Make sense!